[RESEND] xfree86: prune duplicate monitor modes.

Adam Jackson ajax at redhat.com
Fri Sep 2 17:03:02 UTC 2016


On Thu, 2016-09-01 at 20:39 +0200, Hans de Goede wrote:

> AFAICT there is still a leak / problem:
> 
> hw/xfree86/modes/xf86EdidModes.c: xf86EdidMonitorSet()
> appends all modes from EDID, if it calls twice, all the
> modes will end up twice in Monitor->Modes, or am I missing
> something here ?
> 
> Maybe the caller of xf86EdidMonitorSet() clears
> the Modes list each time before it calls xf86EdidMonitorSet() ?

Indirectly, yeah. EDID really only changes on output plug events, and
usually when that happens the unplug will clear the mode list, and then
the next plug will compute it from the new EDID.

- ajax


More information about the xorg-devel mailing list