[v5,xserver,3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

Michel Dänzer michel at daenzer.net
Wed Sep 7 00:57:35 UTC 2016


On 06/09/16 08:31 PM, Hans De Goede wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This is a preparation patch for adding prime hw-cursor support.

[...]

> diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c
> index dda4349..a832406 100644
> --- a/hw/xfree86/ramdac/xf86Cursor.c
> +++ b/hw/xfree86/ramdac/xf86Cursor.c
> @@ -337,16 +337,9 @@ xf86CursorSetCursor(DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCurs,
>              return;
>          }
>  
> -        if (infoPtr->pScrn->vtSema && xorg_list_is_empty(&pScreen->pixmap_dirty_list) &&
> +        if (infoPtr->pScrn->vtSema &&

If you remove the check for empty pScreen->pixmap_dirty_list already in
this patch, we will attempt to use HW cursors on PRIME slave outputs,
but it won't work correctly, right?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list