[v5,xserver,3/7] xf86Cursor: Add xf86CheckHWCursor() helper function

[Hans de Goede]

Hi,

On 07-09-16 02:57, Michel Dänzer wrote:
> On 06/09/16 08:31 PM, Hans De Goede wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This is a preparation patch for adding prime hw-cursor support.
>
> [...]
>
>> diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c
>> index dda4349..a832406 100644
>> --- a/hw/xfree86/ramdac/xf86Cursor.c
>> +++ b/hw/xfree86/ramdac/xf86Cursor.c
>> @@ -337,16 +337,9 @@ xf86CursorSetCursor(DeviceIntPtr pDev, ScreenPtr pScreen, CursorPtr pCurs,
>>              return;
>>          }
>>
>> -        if (infoPtr->pScrn->vtSema && xorg_list_is_empty(&pScreen->pixmap_dirty_list) &&
>> +        if (infoPtr->pScrn->vtSema &&
>
> If you remove the check for empty pScreen->pixmap_dirty_list already in
> this patch, we will attempt to use HW cursors on PRIME slave outputs,
> but it won't work correctly, right?

Right I clearly got that wrong while splitting
this out into a separate patch, will fix for v6.

Regards,

Hans