[PATCH xserver] glamor: Store the actual EGL/GLX context pointer in lastGLContext

Keith Packard keithp at keithp.com
Thu Jun 1 14:49:22 UTC 2017

Michel Dänzer <michel at daenzer.net> writes:

>> Thanks for debugging -- this sounds like a pain.
> Indeed, it was. :}

I agree, nice work.

> Setting lastGLContext = NULL from CloseScreen would also prevent the
> problem; I considered doing that instead of or in addition to the fix in
> glamor_make_current, but finally decided against it because it would be
> more of a workaround than a fix for the actual problem (and could
> unnecessarily force a MakeCurrent call after a server reset in some cases).

And it looks like FreeScreen is already doing the right stuff.

Might be nice to have the glx side also clean up at some point, but I'm
not sure where we'd stick that as we just use glXGetCurrentContext() for
that, and have no control over lifetime.

I think we're done here; this looks like a simple "thinko" to me.

Reviewed-by: Keith Packard <keithp at keithp.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170601/5392a977/attachment.sig>

More information about the xorg-devel mailing list