[PATCH xserver] glamor: Store the actual EGL/GLX context pointer in lastGLContext

Michel Dänzer michel at daenzer.net
Tue Jun 6 07:53:49 UTC 2017

On 01/06/17 11:49 PM, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
>>> Thanks for debugging -- this sounds like a pain.
>> Indeed, it was. :}
> I agree, nice work.
>> Setting lastGLContext = NULL from CloseScreen would also prevent the
>> problem; I considered doing that instead of or in addition to the fix in
>> glamor_make_current, but finally decided against it because it would be
>> more of a workaround than a fix for the actual problem (and could
>> unnecessarily force a MakeCurrent call after a server reset in some cases).
> And it looks like FreeScreen is already doing the right stuff.
> Might be nice to have the glx side also clean up at some point, but I'm
> not sure where we'd stick that as we just use glXGetCurrentContext() for
> that, and have no control over lifetime.

I don't think the GLX code is affected by the same issue.

> I think we're done here; this looks like a simple "thinko" to me.
> Reviewed-by: Keith Packard <keithp at keithp.com>

Thanks Keith and Eric for the review! Fix pushed.

Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

More information about the xorg-devel mailing list