[PATCH RFC xserver 0/2] glamor pixmap FBO array can be NULL

Adam Jackson ajax at nwnk.net
Wed Mar 15 19:55:13 UTC 2017

On Tue, 2017-03-14 at 14:58 +0100, Olivier Fourdan wrote:

> There are some cases where we don't have a fallback code path, in which
> case we'll avoid the crash in glamor_set_destination_drawable() but won't
> render properly, but this is a rare occurence and not rendering properly
> is still better than crashing the X server and the user losing his/her
> entire session...

Discarding rendering on allocation failure is fine, yeah. Or at any
rate fb and mi already have that property.

2/2 doesn't seem to check all the glamor_set_destination_drawable calls
though (see: glamor_glyphs_flush, glamor_dash_loop, glamor_text,
glamor_xv_render). Just an oversight?

- ajax

More information about the xorg-devel mailing list