[PATCH RFC xserver 0/2] glamor pixmap FBO array can be NULL

Adam Jackson ajax at nwnk.net
Wed Mar 15 20:14:08 UTC 2017

On Wed, 2017-03-15 at 15:55 -0400, Adam Jackson wrote:
> On Tue, 2017-03-14 at 14:58 +0100, Olivier Fourdan wrote:
> > There are some cases where we don't have a fallback code path, in which
> > case we'll avoid the crash in glamor_set_destination_drawable() but won't
> > render properly, but this is a rare occurence and not rendering properly
> > is still better than crashing the X server and the user losing his/her
> > entire session...
> Discarding rendering on allocation failure is fine, yeah. Or at any
> rate fb and mi already have that property.
> 2/2 doesn't seem to check all the glamor_set_destination_drawable calls
> though (see: glamor_glyphs_flush, glamor_dash_loop, glamor_text,
> glamor_xv_render). Just an oversight?

Pushed anyway, easy enough to fix more spots later:

remote: I: patch #143942 updated using rev 04b4bad7c048fd077fe839f10634c99ef1e488af.
remote: I: patch #143944 updated using rev 455051a0f1d2bc84f605c325f647bd64d414c47d.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   b0ce1d0..455051a  master -> master

- ajax

More information about the xorg-devel mailing list