[PATCH xserver 1/3] xfree86: Clean up DPMS support

Eric Anholt eric at anholt.net
Fri Mar 24 17:34:57 UTC 2017

Adam Jackson <ajax at redhat.com> writes:

> Rather than setting up a per-screen private, just conditionally
> initialize ScrnInfoRec::DPMSSet based on the config options, and inspect
> that to determine whether DPMS is supported.
> We also move the "turn the screen back on at CloseScreen" logic into the
> DPMS extension's (new) reset hook. This would be a behavior change for
> the non-xfree86 servers, if any of them had non-stub DPMS support.

Doesn't this move when the DPMSSet(On) happens in the CloseScreen
sequence for xorg?  Is that going to be OK?

I'm pretty sure the motivation of this call is for UMS drivers to try to
successfully restore back to the console (for KMS, this is the kernel's
job, not ours), but I think UMS drivers should all be doing that already
and the close-time call should probably just be removed instead.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170324/1db4b09a/attachment.sig>

More information about the xorg-devel mailing list