[PATCH xserver 1/3] xfree86: Clean up DPMS support

Adam Jackson ajax at redhat.com
Fri Mar 24 19:40:01 UTC 2017

On Fri, 2017-03-24 at 10:34 -0700, Eric Anholt wrote:
> > Adam Jackson <ajax at redhat.com> writes:
> > Rather than setting up a per-screen private, just conditionally
> > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect
> > that to determine whether DPMS is supported.
> > 
> > We also move the "turn the screen back on at CloseScreen" logic into the
> > DPMS extension's (new) reset hook. This would be a behavior change for
> > the non-xfree86 servers, if any of them had non-stub DPMS support.
> Doesn't this move when the DPMSSet(On) happens in the CloseScreen
> sequence for xorg?  Is that going to be OK?

It does move it, and I expect it to be okay. It moves the DPMS-on
earlier, because CloseDownExtensions happens way before CloseScreen.
CDE is so close to Dispatch that this should be indistinguishable from
"the last request processed was a DPMS on", and if we can't CloseScreen
in that scenario then we're already in a world of hurt.

- ajax

More information about the xorg-devel mailing list