[PATCH xserver 1/3] xfree86: Clean up DPMS support

Eric Anholt eric at anholt.net
Fri Mar 24 20:20:58 UTC 2017

Adam Jackson <ajax at redhat.com> writes:

> On Fri, 2017-03-24 at 10:34 -0700, Eric Anholt wrote:
>> > Adam Jackson <ajax at redhat.com> writes:
>> > Rather than setting up a per-screen private, just conditionally
>> > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect
>> > that to determine whether DPMS is supported.
>> > 
>> > We also move the "turn the screen back on at CloseScreen" logic into the
>> > DPMS extension's (new) reset hook. This would be a behavior change for
>> > the non-xfree86 servers, if any of them had non-stub DPMS support.
>> Doesn't this move when the DPMSSet(On) happens in the CloseScreen
>> sequence for xorg?  Is that going to be OK?
> It does move it, and I expect it to be okay. It moves the DPMS-on
> earlier, because CloseDownExtensions happens way before CloseScreen.
> CDE is so close to Dispatch that this should be indistinguishable from
> "the last request processed was a DPMS on", and if we can't CloseScreen
> in that scenario then we're already in a world of hurt.

That's basically what I was looking for.  Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20170324/c906eece/attachment.sig>

More information about the xorg-devel mailing list