[PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

Adam Jackson ajax at redhat.com
Mon Mar 27 16:35:32 UTC 2017


On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote:

> This is the only functional change I spotted: SaveScreen is now going to
> return FALSE instead of TRUE.  Given that we haven't actually blanked
> the screen, this seems like an appropriate return value.

I don't think this is a functional change:

> > @@ -645,34 +614,7 @@ KdCloseScreen(ScreenPtr pScreen)
> >  static Bool
> >  KdSaveScreen(ScreenPtr pScreen, int on)
> >  {
> > -    KdScreenPriv(pScreen);
> > -    int dpmsState;
> > -
> > -    if (!pScreenPriv->card->cfuncs->dpms)
> > -        return FALSE;
> > -

->dpms was always null so we were always returning false anyway.

- ajax


More information about the xorg-devel mailing list