[PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

Adam Jackson ajax at nwnk.net
Mon Mar 27 17:14:43 UTC 2017


On Mon, 2017-03-27 at 12:35 -0400, Adam Jackson wrote:
> On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote:
> 
> > This is the only functional change I spotted: SaveScreen is now
> > going to
> > return FALSE instead of TRUE.  Given that we haven't actually
> > blanked
> > the screen, this seems like an appropriate return value.
> 
> I don't think this is a functional change:
> 
> > > @@ -645,34 +614,7 @@ KdCloseScreen(ScreenPtr pScreen)
> > >  static Bool
> > >  KdSaveScreen(ScreenPtr pScreen, int on)
> > >  {
> > > -    KdScreenPriv(pScreen);
> > > -    int dpmsState;
> > > -
> > > -    if (!pScreenPriv->card->cfuncs->dpms)
> > > -        return FALSE;
> > > -
> 
> ->dpms was always null so we were always returning false anyway.

I am a filthy dirty liar. It was set to a stub that returned TRUE.

TRUE appears to be what the rest of the DPMS stubs do, so how about I
change KdSaveScreen to match?

- ajax


More information about the xorg-devel mailing list