[PATCH xserver] dri3: cap the version returned to the client

Emil Velikov emil.l.velikov at gmail.com
Mon Mar 19 21:11:52 UTC 2018


On 19 March 2018 at 19:59, Adam Jackson <ajax at nwnk.net> wrote:
> On Mon, 2018-03-19 at 12:04 +0000, Emil Velikov wrote:
>> On 13 March 2018 at 18:38, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> > From: Emil Velikov <emil.velikov at collabora.com>
>> >
>> > As per the protocol, the server should not return version greater than
>> > the one supported by the client.
>> >
>> > Add a spec quote and tweak the numbers accordingly.
>> >
>> > Fixes: 563138298868 ("dri3: Add DRI3 extension")
>> > Cc: Daniel Stone <daniels at collabora.com>
>> > Cc: Keith Packard <keithp at keithp.com>
>> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>
> Merged:
>
> remote: I: patch #210343 updated using rev ae5c0dd199a5fbfbdf7a2d6b8c1b28c410289106.
> remote: I: 1 patch(es) updated to state Accepted.
> To ssh://git.freedesktop.org/git/xorg/xserver
>    6a5d51e082..ae5c0dd199  master -> master
>
> Though I think both this and the corresponding present patch are broken
> if the client sends a version number of 0.42...
>
True. We could bail out if the client sends a too old (garbage) version - WDYT?

In general handling of server_major != client_major could also be
improved, yet major won't be bumped in the foreseeable future.

Thanks
-Emil


More information about the xorg-devel mailing list