[PATCH xserver] dri3: cap the version returned to the client

Adam Jackson ajax at nwnk.net
Mon Mar 19 21:21:52 UTC 2018


On Mon, 2018-03-19 at 21:11 +0000, Emil Velikov wrote:
> On 19 March 2018 at 19:59, Adam Jackson <ajax at nwnk.net> wrote:
> > Merged:
> > 
> > remote: I: patch #210343 updated using rev ae5c0dd199a5fbfbdf7a2d6b8c1b28c410289106.
> > remote: I: 1 patch(es) updated to state Accepted.
> > To ssh://git.freedesktop.org/git/xorg/xserver
> >    6a5d51e082..ae5c0dd199  master -> master
> > 
> > Though I think both this and the corresponding present patch are broken
> > if the client sends a version number of 0.42...
> 
> True. We could bail out if the client sends a too old (garbage) version - WDYT?

We probably should. In practice it's not going to matter as no client
is that broken (and supporting two major versions of an extension is
nearly impossible in most cases), but technically correct is the best
kind of correct.

- ajax


More information about the xorg-devel mailing list