[PATCH xf86-video-savage] Changing result parameter type for ScreenWakeupHandlerProcPtr

Matt Turner mattst88 at gmail.com
Fri Feb 1 05:23:59 UTC 2019


On Thu, Jan 31, 2019 at 3:32 PM Kevin Brace <kevinbrace at gmx.com> wrote:
>
> For ABI_VIDEODRV_VERSION >= 23, it was changed to int from unsigned
> long.
>
> Signed-off-by: Kevin Brace <kevinbrace at gmx.com>
> ---
>  src/compat-api.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/compat-api.h b/src/compat-api.h
> index 44daea4..7cf29d0 100644
> --- a/src/compat-api.h
> +++ b/src/compat-api.h
> @@ -82,7 +82,7 @@

A little more context would have made this a bit easier to review. The
line immediately above this hunk is

#if ABI_VIDEODRV_VERSION >= SET_ABI_VERSION(23, 0)

>  #define BLOCKHANDLER_ARGS_DECL ScreenPtr arg, pointer pTimeout
>  #define BLOCKHANDLER_ARGS arg, pTimeout
>
> -#define WAKEUPHANDLER_ARGS_DECL ScreenPtr arg, unsigned long result
> +#define WAKEUPHANDLER_ARGS_DECL ScreenPtr arg, int result
>  #define WAKEUPHANDLER_ARGS arg, result

Reviewed-by: Matt Turner <mattst88 at gmail.com>

(and for the identical -tdfx patch as well)


More information about the xorg-devel mailing list