[patch] Another savage bugfix

Felix Kühling fxkuehl at gmx.de
Sat Sep 18 07:47:42 PDT 2004


below is another bugfix for the savage 2D driver. It moves vbeFree in
SavageCloseScreen to after SavageWriteMode. It's still needed there if
the UseBios option is set. This fixes a "Frequency not supported"
problem my monitor has after the Xserver terminates.

I'm unsure how strict CVS policies are in Xorg. I don't feel comfortable
yet, committing stuff to the 2D driver that I don't fully understand
because it may have unexpected effects on other parts of the code or on
different hardware. If someone tells me not to worry too much when we're
far from a release deadline I could commit such small fixes without
asking in the future. If someone prefers to review my patches first,
that's fine with me too. Let me know what you prefer.

Is there an official maintainer of the Savage driver who I should refer

Best regards,

| Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
| PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |

--- ./savage_driver.c.~1.7.~	2004-09-17 12:45:48.000000000 +0200
+++ ./savage_driver.c	2004-09-18 16:29:12.000000000 +0200
@@ -3341,10 +3341,6 @@
-    if (psav->pVbe)
-      vbeFree(psav->pVbe);
-    psav->pVbe = NULL;
     if( psav->AccelInfoRec ) {
         XAADestroyInfoRec( psav->AccelInfoRec );
 	psav->AccelInfoRec = NULL;
@@ -3364,6 +3360,11 @@
 	SavageUnmapMem(pScrn, 0);
+    /* This is still needed in SavageWriteMode. */
+    if (psav->pVbe)
+      vbeFree(psav->pVbe);
+    psav->pVbe = NULL;
     pScrn->vtSema = FALSE;
     pScreen->CloseScreen = psav->CloseScreen;

More information about the xorg mailing list