[patch] Another savage bugfix

Alex Deucher alexdeucher at gmail.com
Sat Sep 18 08:14:43 PDT 2004

On Sat, 18 Sep 2004 16:47:42 +0200, Felix Kühling <fxkuehl at gmx.de> wrote:
> Hello,
> below is another bugfix for the savage 2D driver. It moves vbeFree in
> SavageCloseScreen to after SavageWriteMode. It's still needed there if
> the UseBios option is set. This fixes a "Frequency not supported"
> problem my monitor has after the Xserver terminates.
> I'm unsure how strict CVS policies are in Xorg. I don't feel comfortable
> yet, committing stuff to the 2D driver that I don't fully understand
> because it may have unexpected effects on other parts of the code or on
> different hardware. If someone tells me not to worry too much when we're
> far from a release deadline I could commit such small fixes without
> asking in the future. If someone prefers to review my patches first,
> that's fine with me too. Let me know what you prefer.

The patch looks ok to me.  I think you can commit it.

> Is there an official maintainer of the Savage driver who I should refer
> to?

Tim Roberts used to be AFAIK, but I'm not sure if he still does.  I
don't know that xorg has official maintainers for drivers, other than
maybe sis.


> Best regards,
>   Felix
> | Felix Kühling <fxkuehl at gmx.de>                     http://fxk.de.vu |
> | PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3  B152 151C 5CC1 D888 E595 |

More information about the xorg mailing list