committing the wsfb driver

Eric Anholt eta at
Sat Sep 25 09:13:48 PDT 2004

On Sat, 2004-09-25 at 05:17, Adam Jackson wrote:
> On Saturday 25 September 2004 06:17, Matthieu Herrb wrote:
> > Are there any objections?
> This looks bad:
>         if (!osname || strcmp(osname, "openbsd") != 0) {
>                 if (errmaj)
>                         *errmaj = LDR_BADOS;
>                 if (errmin)
>                         *errmin = 0;
>                 return NULL;
>         }
> How does this work on NetBSD?
> It's nice to be able to compile all drivers on all OSes for various reasons 
> (tinderboxing, dlloader sanity checks) even if they won't run correctly on 
> all OSes.  AFAICT the "#include <dev/wscons/wsconsio.h>" is the only major 
> problem.  I'd like to change that to include a wsconsio.h from, say, 
> os-support/, which then imports the real one on Net or Open or fakes the 
> necessary defines for anything else.  Does that sound reasonable?
> Other than that, looks good, merge away.

I don't mind the basic idea of compiling all drivers too much, but
please don't install them if there's no chance of them running.   fbdev
on FreeBSD, for example.

Eric Anholt                                eta at          anholt at

More information about the xorg mailing list