committing the wsfb driver

Adam Jackson ajax at
Sat Sep 25 05:17:23 PDT 2004

On Saturday 25 September 2004 06:17, Matthieu Herrb wrote:
> Are there any objections?

This looks bad:

        if (!osname || strcmp(osname, "openbsd") != 0) {
                if (errmaj)
                        *errmaj = LDR_BADOS;
                if (errmin)
                        *errmin = 0;
                return NULL;

How does this work on NetBSD?

It's nice to be able to compile all drivers on all OSes for various reasons 
(tinderboxing, dlloader sanity checks) even if they won't run correctly on 
all OSes.  AFAICT the "#include <dev/wscons/wsconsio.h>" is the only major 
problem.  I'd like to change that to include a wsconsio.h from, say, 
os-support/, which then imports the real one on Net or Open or fakes the 
necessary defines for anything else.  Does that sound reasonable?

Other than that, looks good, merge away.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <>

More information about the xorg mailing list