[PATCH] EXA support for i830 (for real this time!)

Eric Anholt eta at lclark.edu
Wed Aug 31 10:25:07 PDT 2005

On Wed, 2005-08-31 at 13:06 -0400, Adam Jackson wrote:
> On Wednesday 31 August 2005 04:51, Alan Hourihane wrote:
> > On Sun, 2005-08-28 at 21:48 -0700, Jesse Barnes wrote:
> > > This one addresses the cleanup aspect of things (yay lots of #ifdefs
> > > removed!)--I've adding i830_xaa.c and i830_exa.c files and fixed up
> > > some other related stuff.  I tested Xv and it's busted but haven't
> > > fixed and tested dual head yet.  So this is more of a checkpoint than
> > > anything else.
> >
> > Jesse,
> >
> > Another problem with your patch is the use of I830_USE_XAA and
> > I830_USE_EXA where you should really be using pI830->useEXA.
> In general, I would prefer that EXA patches not attempt to also conditionalize 
> XAA out at compile time.  We don't want to even give people the option of 
> disabling XAA for at least a release cycle.
> I want to be able to look at a patch and see all the conditionalization 
> happening based on runtime flags.  If I have to learn news ifdefs to follow 
> the code too, I'm much less likely to understand it when I read it, and that 
> makes me less likely to want to merge it.

That said, if we've already done the conditionalization, should we rip
it out?  I hope not -- it was really annoying, and I'd rather someone
not have to do it again.

Eric Anholt                                     eta at lclark.edu
http://people.freebsd.org/~anholt/              anholt at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20050831/d9c787c6/attachment.pgp>

More information about the xorg mailing list