[PATCH] EXA support for i830 (for real this time!)
ajax at nwnk.net
Wed Aug 31 10:31:13 PDT 2005
On Wednesday 31 August 2005 13:25, Eric Anholt wrote:
> On Wed, 2005-08-31 at 13:06 -0400, Adam Jackson wrote:
> > In general, I would prefer that EXA patches not attempt to also
> > conditionalize XAA out at compile time. We don't want to even give
> > people the option of disabling XAA for at least a release cycle.
> > I want to be able to look at a patch and see all the conditionalization
> > happening based on runtime flags. If I have to learn news ifdefs to
> > follow the code too, I'm much less likely to understand it when I read
> > it, and that makes me less likely to want to merge it.
> That said, if we've already done the conditionalization, should we rip
> it out? I hope not -- it was really annoying, and I'd rather someone
> not have to do it again.
If it's already there I don't mind, as long as the submitter doesn't mind
getting bug reports for any possible permutation ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the xorg