[PATCH] xorg-server: pixan-include
arekm at maven.pl
Thu Sep 20 23:18:08 PDT 2007
On Friday 21 of September 2007, Dan Nicholson wrote:
> On 9/20/07, Hanno Böck <ml at hboeck.de> wrote:
> > miscstruct.h contains an include of pixman.h without a path.
> > This will e.g. cause synaptics build to fail. Attached patch for
> > xorg-xserver fixes it. Please apply.
> Not if they're using pkg-config:
> $ pkg-config --cflags pixman-1
The problem is that now every external app that uses these headers needs to
use pkgconfig to get pixman -I flags.
Why the include wasn't written as #include <pixman-1/whatever.h>?
pixman-1 name was choosen afaik to be able to easily change api/abi in future
and still have posibility go have both (old and new) pixman packages
installed (without conflicts). Since now xserver uses pixman-1 API only and
it simply could directly include <pixman-1/xyz> avoiding all the problems.
(That's what we did in PLD)
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
More information about the xorg