[PATCH] xkb: when copying the keymap, make sure the structs default to 0/NULL.

Daniel Stone daniel at fooishbar.org
Fri Feb 8 00:51:35 PST 2008


On Fri, Feb 08, 2008 at 01:08:10PM +1030, Peter Hutterer wrote:
> Daniel Stone wrote:
>> On Thu, Feb 07, 2008 at 11:23:08PM +1030, Peter Hutterer wrote:
>>> so I take it the following patch may be a good idea too?
>>
>> Nope, that part is actually correct (far as I know), since we've always
>> allocated it to num_foo, and set one of num or sz correctly.
>
> So I gather sz_doodads is supposed to be the number of allocated structs
> and num_doodads the actual number of contents? (which just happens to be
> the same here)

Yep!

> thanks for the review.

No problem, thanks for the patch.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20080208/71bf5136/attachment.pgp>


More information about the xorg mailing list