Intel driver: increasing the maximum Xv image size

[Nicolas George]

Le nonidi 19 floréal, an CCXVI, Eric Anholt a écrit :
> 2048x2048 will hit the BIGREQUESTS limit and your movie players will all
> fall over when they try to render something that big.

Unless I am mistaken, the BIGREQUESTS limit was raised between xserver 1.3
and 1.4: it was 4 Mo, which is just above 1920×1088×2, and it now is 16 Mo,
which is well above 2048×2048×2.

But you probably know better than me, since as far as I can see, you are the
one who committed it (f499c2ea0a90a69713daef8f9497463229384964).

If this is true, the maximum image size could therefore be raised
conditionally to the value of XORG_VERSION_CURRENT. This could lead to
something like the following patch.

Regards,

-- 
  Nicolas George


diff --git a/src/i830_video.c b/src/i830_video.c
index e109578..81ee019 100644
--- a/src/i830_video.c
+++ b/src/i830_video.c
@@ -127,12 +127,20 @@ static Atom xvGamma0, xvGamma1, xvGamma2, xvGamma3, xvGamma4, xvGamma5;
  * and 845, larger sizes resulted in the card hanging, so we keep the limits
  * lower there.
  *
+ * The bigrequests limit was raised with the 1.4 release, and is no longer a
+ * problem.
+ *
  * While the HD resolution is actually 1920x1080, we increase our advertised
  * size to 1088 because some software wants to send an image aligned to
  * 16-pixel boundaries.
  */
-#define IMAGE_MAX_WIDTH		1920
-#define IMAGE_MAX_HEIGHT	1088
+#if XORG_VERSION_CURRENT >= 10400000
+# define IMAGE_MAX_WIDTH	2048
+# define IMAGE_MAX_HEIGHT	2048
+#else
+# define IMAGE_MAX_WIDTH	1920
+# define IMAGE_MAX_HEIGHT	1088
+#endif
 #define IMAGE_MAX_WIDTH_LEGACY	1024
 #define IMAGE_MAX_HEIGHT_LEGACY	1088
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg/attachments/20080508/7a81b4f6/attachment.pgp>