xorg/driver/xf86-input-synaptics: [PATCH 2/2] Janitor: compile warnings and "missing" symbols.

[Paulo César Pereira de Andrade]

Daniel Stone wrote:
> On Fri, Feb 06, 2009 at 05:50:58AM -0800, Dan Nicholson wrote:
>> This is probably fine, but it's a little safer to use the
>> AC_CHECK_LIBM macro from libtool.
>>
>> configure.ac:
>> AC_CHECK_LIBM
>>
>> src/Makefile.am:
>> @DRIVER_NAME at _drv_la_LIBADD = $(LIBM)
>
> Oooh, cool.  We've got a few hardcoded -lm's around.

  In this specific case, it should not really matter much
as the X Server must be linked with libm.
  But for example, I believe xf86-input-acecad is better
with:

if HAVE_LIBSYSFS
@DRIVER_NAME at _drv_la_LIBADD = -lsysfs
endif

then the hack it had previously to dlopen libsysfs.

  The @DRIVER_NAME@ patterns probably would be better
also not used. As it is very unlikely a single Makefile.am
could be used for all drivers, and I don't see it much
useful, other then if someone wants to give a different
name to a driver every week. But then some work must be
done to expand @DRIVER_NAME@ in the C file also...

Paulo