[PATCH] Remove Unused Barrier macros on Alpha

Matt Turner mattst88 at gmail.com
Fri Feb 6 12:00:40 PST 2009


Hi,

My mail client thinks it's a good idea to line wrap patches, so I'll
attach it instead.

Also made one change: we want to also remove the comment pertaining to
the IMB macro since we've removed the IMB macro.

Thanks,

Matt Turner

On Fri, Feb 6, 2009 at 10:13 AM, Matt Turner <mattst88 at gmail.com> wrote:
> Hi,
>
> As a follow up to ajax's bde028dd8d856f8d47c39e3c6d3731c34c398c74
> commit, this patch fully removes the (now unused) instruction barrier
> macro on Alpha.
>
> It also removes some ifdef logic choosing whether we're using ELF or
> ECOFF. I can't find any other references to ECOFF in the source, so I
> assume it's just waiting to be removed.
>
> Thanks,
>
> Matt Turner
>
> Signed-off-by: Matt Turner <mattst88 at gmail.com>
> ---
> diff --git a/hw/xfree86/common/compiler.h b/hw/xfree86/common/compiler.h
> index 0c6928c..7c28c2c 100644
> --- a/hw/xfree86/common/compiler.h
> +++ b/hw/xfree86/common/compiler.h
> @@ -358,15 +358,8 @@ static __inline__ void stw_u(unsigned long r5,
> unsigned short * r11)
>  }
>
>  /* to flush the I-cache before jumping to code which just got loaded */
> -#    define PAL_imb 134
> -#    define istream_mem_barrier() \
> -       __asm__ __volatile__("call_pal %0 #imb" : : "i" (PAL_imb) : "memory")
>  #    define mem_barrier()        __asm__ __volatile__("mb"  : : : "memory")
> -#    ifdef __ELF__
> -#     define write_mem_barrier()  __asm__ __volatile__("wmb" : : : "memory")
> -#    else  /*  ECOFF gas 2.6 doesn't know "wmb" :-(  */
> -#     define write_mem_barrier()  mem_barrier()
> -#    endif
> +#    define write_mem_barrier()  __asm__ __volatile__("wmb" : : : "memory")
>
>
>  #   elif defined(linux) && defined(__ia64__)
> ---
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-old-alpha-macros.patch
Type: application/octet-stream
Size: 910 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20090206/3fbf7601/attachment.obj>


More information about the xorg mailing list