[PATCH] xdm compile failed due to asprintf()

Alan Coopersmith Alan.Coopersmith at Sun.COM
Mon Jul 20 22:38:55 PDT 2009


Thanks - pushed to git master.   Sorry about the typo.   (Can tell I never
build without IPv6 support - was actually wondering when working on that
code last week if it was time yet to delete the ifdefs to make IPv6 always
be built in.)

	-Alan Coopersmith-           alan.coopersmith at sun.com
	 Sun Microsystems, Inc. - X Window System Engineering


Jeff Chua wrote:
> 
> 
> xdm no longer compiles due to recent commit
> 56a14b8a1f4d3aa883485b794c818581b8f07cd8 that changed to use asprintf().
> There is an additional right-bracket that causes the problem.
> 
> 
> commit 56a14b8a1f4d3aa883485b794c818581b8f07cd8
> Author: Alan Coopersmith <alan.coopersmith at sun.com>
> Date:   Fri Jul 17 20:37:51 2009 -0700
> 
>      sprintf -> snprintf/asprintf conversions
> 
>      Signed-off-by: Alan Coopersmith <alan.coopersmith at sun.com>
> 
> 
> Below is a patch to fix the problem.
> 
> 
> Thanks,
> Jeff
> 
> --- xorg/app/xdm/xdmcp.c    2009-07-19 01:51:07 +0800
> +++ xorg/app/xdm/xdmcp.c    2009-07-20 21:21:46 +0800
> @@ -706,7 +706,7 @@
> 
>           if (asprintf(&name, "%d.%d.%d.%d:%d",
>                    data[0], data[1], data[2], data[3],
> -                 displayNumber) < 0)) {
> +                 displayNumber) < 0) {
>               return NULL;
>           }
>           }
> 
> 
> 



More information about the xorg mailing list