dri-devel January 2021

dri-devel@lists.freedesktop.org

322 participants
737 discussions

[PATCH] drm/syncobj: make lockdep complain on WAIT_FOR_SUBMIT v3
by Christian König 19 Jan '21

19 Jan '21

DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT can't be used when we hold locks since we are basically waiting for userspace to do something. Holding a lock while doing so can trivial deadlock with page faults etc... So make lockdep complain when a driver tries to do this. v2: Add lockdep_assert_none_held() macro. v3: Add might_sleep() and also use lockdep_assert_none_held() in the IOCTL path. Signed-off-by: Christian König <christian.koenig(a)amd.com> --- drivers/gpu/drm/drm_syncobj.c | 12 ++++++++++++ include/linux/lockdep.h | 5 +++++ 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 6e74e6745eca..9ecfec1e5567 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -387,6 +387,15 @@ int drm_syncobj_find_fence(struct drm_file *file_private, if (!syncobj) return -ENOENT; + /* Waiting for userspace with locks help is illegal cause that can + * trivial deadlock with page faults for example. Make lockdep complain + * about it early on. + */ + if (flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT) { + might_sleep(); + lockdep_assert_none_held_once(); + } + *fence = drm_syncobj_fence_get(syncobj); drm_syncobj_put(syncobj); @@ -940,6 +949,9 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs, uint64_t *points; uint32_t signaled_count, i; + if (flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT) + lockdep_assert_none_held_once(); + points = kmalloc_array(count, sizeof(*points), GFP_KERNEL); if (points == NULL) return -ENOMEM; diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index b9e9adec73e8..6eb117c0d0f3 100644 --- a/include/linux/lockdep.h +++ b/include/linux/lockdep.h @@ -310,6 +310,10 @@ extern void lock_unpin_lock(struct lockdep_map *lock, struct pin_cookie); WARN_ON_ONCE(debug_locks && !lockdep_is_held(l)); \ } while (0) +#define lockdep_assert_none_held_once() do { \ + WARN_ON_ONCE(debug_locks && current->lockdep_depth); \ + } while (0) + #define lockdep_recursing(tsk) ((tsk)->lockdep_recursion) #define lockdep_pin_lock(l) lock_pin_lock(&(l)->dep_map) @@ -387,6 +391,7 @@ extern int lockdep_is_held(const void *); #define lockdep_assert_held_write(l) do { (void)(l); } while (0) #define lockdep_assert_held_read(l) do { (void)(l); } while (0) #define lockdep_assert_held_once(l) do { (void)(l); } while (0) +#define lockdep_assert_none_held_once() do { } while (0) #define lockdep_recursing(tsk) (0) -- 2.25.1

3 2

[PATCH v4 0/6] drm: Move struct drm_device.pdev to legacy
by Thomas Zimmermann 19 Jan '21

19 Jan '21

I merged more patches into drm-misc-next. I'm mostly sending out v4 of this patchset to split the final patch into the core changes and the patch for moving pdev behind CONFIG_DRM_LEGACY. The former are required to fix a reported bug. [1] There's also a fix to vmwgfx. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device stored in struct drm_device.dev. To reduce duplication and remove the special case of PCI, this patchset converts all modesetting drivers from pdev to dev and makes pdev a field for legacy UMS drivers. For PCI devices, the pointer in struct drm_device.dev can be upcasted to struct pci_device; or tested for PCI with dev_is_pci(). In several places the code can use the dev field directly. After converting all drivers and the DRM core, the pdev fields becomes only relevant for legacy drivers. In a later patchset, we may want to convert these as well and remove pdev entirely. v4: * merged several patches * moved core changes into separate patch * vmwgfx build fix v3: * merged several patches * fix one pdev reference in nouveau (Jeremy) * rebases v2: * move whitespace fixes into separate patches (Alex, Sam) * move i915 gt/ and gvt/ changes into separate patches (Joonas) [1] https://lore.kernel.org/dri-devel/7851c78c-8c57-3c84-cd49-a72703095a5d@suse… Thomas Zimmermann (6): drm: Upcast struct drm_device.dev to struct pci_device; replace pdev drm/i915: Remove references to struct drm_device.pdev drm/i915/gt: Remove references to struct drm_device.pdev drm/i915/gvt: Remove references to struct drm_device.pdev drm/vmwgfx: Remove reference to struct drm_device.pdev drm: Move struct drm_device.pdev to legacy section drivers/gpu/drm/drm_agpsupport.c | 9 ++++--- drivers/gpu/drm/drm_bufs.c | 4 +-- drivers/gpu/drm/drm_edid.c | 7 ++++- drivers/gpu/drm/drm_irq.c | 12 +++++---- drivers/gpu/drm/drm_pci.c | 26 +++++++++++-------- drivers/gpu/drm/drm_vm.c | 2 +- drivers/gpu/drm/i915/display/intel_bios.c | 2 +- drivers/gpu/drm/i915/display/intel_cdclk.c | 14 +++++----- drivers/gpu/drm/i915/display/intel_csr.c | 2 +- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 2 +- .../gpu/drm/i915/display/intel_lpe_audio.c | 5 ++-- drivers/gpu/drm/i915/display/intel_opregion.c | 6 ++--- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 4 +-- drivers/gpu/drm/i915/display/intel_quirks.c | 2 +- drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +- drivers/gpu/drm/i915/display/intel_vga.c | 8 +++--- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 6 ++--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 10 +++---- drivers/gpu/drm/i915/gt/intel_ppgtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +-- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 8 +++--- drivers/gpu/drm/i915/gt/intel_reset.c | 6 ++--- drivers/gpu/drm/i915/gvt/cfg_space.c | 5 ++-- drivers/gpu/drm/i915/gvt/firmware.c | 10 +++---- drivers/gpu/drm/i915/gvt/gtt.c | 12 ++++----- drivers/gpu/drm/i915/gvt/gvt.c | 6 ++--- drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +-- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 20 +++++++------- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++-- drivers/gpu/drm/i915/i915_getparam.c | 5 ++-- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 6 ++--- drivers/gpu/drm/i915/i915_pmu.c | 2 +- drivers/gpu/drm/i915/i915_suspend.c | 4 +-- drivers/gpu/drm/i915/i915_switcheroo.c | 4 +-- drivers/gpu/drm/i915/i915_vgpu.c | 2 +- drivers/gpu/drm/i915/intel_device_info.c | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +- drivers/gpu/drm/i915/intel_uncore.c | 4 +-- .../gpu/drm/i915/selftests/mock_gem_device.c | 1 - drivers/gpu/drm/i915/selftests/mock_gtt.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 - include/drm/drm_device.h | 6 ++--- 50 files changed, 137 insertions(+), 125 deletions(-) -- 2.29.2

4 11

[PATCH 1/4] drm/ttm: add debugfs directory v2
by Christian König 19 Jan '21

19 Jan '21

As far as I can tell the buffer_count was never used by an userspace application. The number of BOs in the system is far better suited in debugfs than sysfs and we now should be able to add other information here as well. v2: add that additionally to sysfs Signed-off-by: Christian König <christian.koenig(a)amd.com> Acked-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/gpu/drm/ttm/ttm_bo.c | 48 ++------------------------------ drivers/gpu/drm/ttm/ttm_module.c | 4 +++ drivers/gpu/drm/ttm/ttm_module.h | 6 ++-- 3 files changed, 11 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index b65f4b12f986..c289a6a37ff9 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -44,8 +44,6 @@ #include "ttm_module.h" -static void ttm_bo_global_kobj_release(struct kobject *kobj); - /* * ttm_global_mutex - protecting the global BO state */ @@ -54,11 +52,6 @@ unsigned ttm_bo_glob_use_count; struct ttm_bo_global ttm_bo_glob; EXPORT_SYMBOL(ttm_bo_glob); -static struct attribute ttm_bo_count = { - .name = "bo_count", - .mode = S_IRUGO -}; - /* default destructor */ static void ttm_bo_default_destroy(struct ttm_buffer_object *bo) { @@ -84,32 +77,6 @@ static void ttm_bo_mem_space_debug(struct ttm_buffer_object *bo, } } -static ssize_t ttm_bo_global_show(struct kobject *kobj, - struct attribute *attr, - char *buffer) -{ - struct ttm_bo_global *glob = - container_of(kobj, struct ttm_bo_global, kobj); - - return snprintf(buffer, PAGE_SIZE, "%d\n", - atomic_read(&glob->bo_count)); -} - -static struct attribute *ttm_bo_global_attrs[] = { - &ttm_bo_count, - NULL -}; - -static const struct sysfs_ops ttm_bo_global_ops = { - .show = &ttm_bo_global_show -}; - -static struct kobj_type ttm_bo_glob_kobj_type = { - .release = &ttm_bo_global_kobj_release, - .sysfs_ops = &ttm_bo_global_ops, - .default_attrs = ttm_bo_global_attrs -}; - static void ttm_bo_del_from_lru(struct ttm_buffer_object *bo) { struct ttm_bo_device *bdev = bo->bdev; @@ -1228,14 +1195,6 @@ size_t ttm_bo_dma_acc_size(struct ttm_bo_device *bdev, } EXPORT_SYMBOL(ttm_bo_dma_acc_size); -static void ttm_bo_global_kobj_release(struct kobject *kobj) -{ - struct ttm_bo_global *glob = - container_of(kobj, struct ttm_bo_global, kobj); - - __free_page(glob->dummy_read_page); -} - static void ttm_bo_global_release(void) { struct ttm_bo_global *glob = &ttm_bo_glob; @@ -1247,6 +1206,7 @@ static void ttm_bo_global_release(void) kobject_del(&glob->kobj); kobject_put(&glob->kobj); ttm_mem_global_release(&ttm_mem_glob); + __free_page(glob->dummy_read_page); memset(glob, 0, sizeof(*glob)); out: mutex_unlock(&ttm_global_mutex); @@ -1279,10 +1239,8 @@ static int ttm_bo_global_init(void) INIT_LIST_HEAD(&glob->device_list); atomic_set(&glob->bo_count, 0); - ret = kobject_init_and_add( - &glob->kobj, &ttm_bo_glob_kobj_type, ttm_get_kobj(), "buffer_objects"); - if (unlikely(ret != 0)) - kobject_put(&glob->kobj); + debugfs_create_atomic_t("buffer_objects", 0444, ttm_debugfs_root, + &glob->bo_count); out: mutex_unlock(&ttm_global_mutex); return ret; diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c index c0906437cb1c..f6566603a60f 100644 --- a/drivers/gpu/drm/ttm/ttm_module.c +++ b/drivers/gpu/drm/ttm/ttm_module.c @@ -32,12 +32,14 @@ #include <linux/module.h> #include <linux/device.h> #include <linux/sched.h> +#include <linux/debugfs.h> #include <drm/drm_sysfs.h> #include "ttm_module.h" static DECLARE_WAIT_QUEUE_HEAD(exit_q); static atomic_t device_released; +struct dentry *ttm_debugfs_root; static struct device_type ttm_drm_class_type = { .name = "ttm", @@ -77,6 +79,7 @@ static int __init ttm_init(void) if (unlikely(ret != 0)) goto out_no_dev_reg; + ttm_debugfs_root = debugfs_create_dir("ttm", NULL); return 0; out_no_dev_reg: atomic_set(&device_released, 1); @@ -94,6 +97,7 @@ static void __exit ttm_exit(void) */ wait_event(exit_q, atomic_read(&device_released) == 1); + debugfs_remove(ttm_debugfs_root); } module_init(ttm_init); diff --git a/drivers/gpu/drm/ttm/ttm_module.h b/drivers/gpu/drm/ttm/ttm_module.h index 45fa318c1585..2f03c2fcf570 100644 --- a/drivers/gpu/drm/ttm/ttm_module.h +++ b/drivers/gpu/drm/ttm/ttm_module.h @@ -31,10 +31,12 @@ #ifndef _TTM_MODULE_H_ #define _TTM_MODULE_H_ -#include <linux/kernel.h> +#define TTM_PFX "[TTM] " + struct kobject; +struct dentry; -#define TTM_PFX "[TTM] " extern struct kobject *ttm_get_kobj(void); +extern struct dentry *ttm_debugfs_root; #endif /* _TTM_MODULE_H_ */ -- 2.25.1

2 6

[PATCH 1/1] drm/atomic: put state on error path
by Pan Bian 19 Jan '21

19 Jan '21

Put the state before returning error code. Fixes: 44596b8c4750 ("drm/atomic: Unify conflicting encoder handling.") Signed-off-by: Pan Bian <bianpan2016(a)163.com> --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index ba1507036f26..4a8cbec832bc 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3021,7 +3021,7 @@ int drm_atomic_helper_set_config(struct drm_mode_set *set, ret = handle_conflicting_encoders(state, true); if (ret) - return ret; + goto fail; ret = drm_atomic_commit(state); -- 2.17.1

2 1

[PATCH 1/4] drm/ttm: add debugfs directory v2
by Christian König 19 Jan '21

19 Jan '21

As far as I can tell the buffer_count was never used by an userspace application. The number of BOs in the system is far better suited in debugfs than sysfs and we now should be able to add other information here as well. v2: add that additionally to sysfs Signed-off-by: Christian König <christian.koenig(a)amd.com> Acked-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> --- drivers/gpu/drm/ttm/ttm_bo.c | 48 ++------------------------------ drivers/gpu/drm/ttm/ttm_module.c | 4 +++ drivers/gpu/drm/ttm/ttm_module.h | 6 ++-- 3 files changed, 11 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 31e8b3da5563..cd55e3104e50 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -44,8 +44,6 @@ #include "ttm_module.h" -static void ttm_bo_global_kobj_release(struct kobject *kobj); - /* * ttm_global_mutex - protecting the global BO state */ @@ -54,11 +52,6 @@ unsigned ttm_bo_glob_use_count; struct ttm_bo_global ttm_bo_glob; EXPORT_SYMBOL(ttm_bo_glob); -static struct attribute ttm_bo_count = { - .name = "bo_count", - .mode = S_IRUGO -}; - /* default destructor */ static void ttm_bo_default_destroy(struct ttm_buffer_object *bo) { @@ -84,32 +77,6 @@ static void ttm_bo_mem_space_debug(struct ttm_buffer_object *bo, } } -static ssize_t ttm_bo_global_show(struct kobject *kobj, - struct attribute *attr, - char *buffer) -{ - struct ttm_bo_global *glob = - container_of(kobj, struct ttm_bo_global, kobj); - - return snprintf(buffer, PAGE_SIZE, "%d\n", - atomic_read(&glob->bo_count)); -} - -static struct attribute *ttm_bo_global_attrs[] = { - &ttm_bo_count, - NULL -}; - -static const struct sysfs_ops ttm_bo_global_ops = { - .show = &ttm_bo_global_show -}; - -static struct kobj_type ttm_bo_glob_kobj_type = { - .release = &ttm_bo_global_kobj_release, - .sysfs_ops = &ttm_bo_global_ops, - .default_attrs = ttm_bo_global_attrs -}; - static void ttm_bo_del_from_lru(struct ttm_buffer_object *bo) { struct ttm_bo_device *bdev = bo->bdev; @@ -1226,14 +1193,6 @@ size_t ttm_bo_dma_acc_size(struct ttm_bo_device *bdev, } EXPORT_SYMBOL(ttm_bo_dma_acc_size); -static void ttm_bo_global_kobj_release(struct kobject *kobj) -{ - struct ttm_bo_global *glob = - container_of(kobj, struct ttm_bo_global, kobj); - - __free_page(glob->dummy_read_page); -} - static void ttm_bo_global_release(void) { struct ttm_bo_global *glob = &ttm_bo_glob; @@ -1245,6 +1204,7 @@ static void ttm_bo_global_release(void) kobject_del(&glob->kobj); kobject_put(&glob->kobj); ttm_mem_global_release(&ttm_mem_glob); + __free_page(glob->dummy_read_page); memset(glob, 0, sizeof(*glob)); out: mutex_unlock(&ttm_global_mutex); @@ -1277,10 +1237,8 @@ static int ttm_bo_global_init(void) INIT_LIST_HEAD(&glob->device_list); atomic_set(&glob->bo_count, 0); - ret = kobject_init_and_add( - &glob->kobj, &ttm_bo_glob_kobj_type, ttm_get_kobj(), "buffer_objects"); - if (unlikely(ret != 0)) - kobject_put(&glob->kobj); + debugfs_create_atomic_t("buffer_objects", 0444, ttm_debugfs_root, + &glob->bo_count); out: mutex_unlock(&ttm_global_mutex); return ret; diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c index c0906437cb1c..f6566603a60f 100644 --- a/drivers/gpu/drm/ttm/ttm_module.c +++ b/drivers/gpu/drm/ttm/ttm_module.c @@ -32,12 +32,14 @@ #include <linux/module.h> #include <linux/device.h> #include <linux/sched.h> +#include <linux/debugfs.h> #include <drm/drm_sysfs.h> #include "ttm_module.h" static DECLARE_WAIT_QUEUE_HEAD(exit_q); static atomic_t device_released; +struct dentry *ttm_debugfs_root; static struct device_type ttm_drm_class_type = { .name = "ttm", @@ -77,6 +79,7 @@ static int __init ttm_init(void) if (unlikely(ret != 0)) goto out_no_dev_reg; + ttm_debugfs_root = debugfs_create_dir("ttm", NULL); return 0; out_no_dev_reg: atomic_set(&device_released, 1); @@ -94,6 +97,7 @@ static void __exit ttm_exit(void) */ wait_event(exit_q, atomic_read(&device_released) == 1); + debugfs_remove(ttm_debugfs_root); } module_init(ttm_init); diff --git a/drivers/gpu/drm/ttm/ttm_module.h b/drivers/gpu/drm/ttm/ttm_module.h index 45fa318c1585..2f03c2fcf570 100644 --- a/drivers/gpu/drm/ttm/ttm_module.h +++ b/drivers/gpu/drm/ttm/ttm_module.h @@ -31,10 +31,12 @@ #ifndef _TTM_MODULE_H_ #define _TTM_MODULE_H_ -#include <linux/kernel.h> +#define TTM_PFX "[TTM] " + struct kobject; +struct dentry; -#define TTM_PFX "[TTM] " extern struct kobject *ttm_get_kobj(void); +extern struct dentry *ttm_debugfs_root; #endif /* _TTM_MODULE_H_ */ -- 2.25.1

3 11

[Bug 211219] drm: panel: panel-raydium68200 driver fails to write MIPI DSI init commands
by bugzilla-daemon＠bugzilla.kernel.org 19 Jan '21

19 Jan '21

https://bugzilla.kernel.org/show_bug.cgi?id=211219 Aleksandr Makarov (aleksandr.o.makarov(a)gmail.com) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dri-devel(a)lists.freedesktop | |.org -- You may reply to this email to add a comment. You are receiving this mail because: You are on the CC list for the bug.

1 0

[PATCH 1/5] drm/nouveau/kms/nv50-: Use drm_dbg_kms() in crc.c
by Lyude Paul 19 Jan '21

19 Jan '21

Cc: Martin Peres <martin.peres(a)free.fr> Cc: Jeremy Cline <jcline(a)redhat.com> Cc: Simon Ser <contact(a)emersion.fr> Signed-off-by: Lyude Paul <lyude(a)redhat.com> --- drivers/gpu/drm/nouveau/dispnv50/crc.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/crc.c b/drivers/gpu/drm/nouveau/dispnv50/crc.c index b8c31b697797..3c50b29a37ff 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/crc.c +++ b/drivers/gpu/drm/nouveau/dispnv50/crc.c @@ -84,7 +84,8 @@ static void nv50_crc_ctx_flip_work(struct kthread_work *base) struct nv50_crc *crc = container_of(work, struct nv50_crc, flip_work); struct nv50_head *head = container_of(crc, struct nv50_head, crc); struct drm_crtc *crtc = &head->base.base; - struct nv50_disp *disp = nv50_disp(crtc->dev); + struct drm_device *dev = crtc->dev; + struct nv50_disp *disp = nv50_disp(dev); u8 new_idx = crc->ctx_idx ^ 1; /* @@ -92,18 +93,15 @@ static void nv50_crc_ctx_flip_work(struct kthread_work *base) * try again for the next vblank if we don't grab the lock */ if (!mutex_trylock(&disp->mutex)) { - DRM_DEV_DEBUG_KMS(crtc->dev->dev, - "Lock contended, delaying CRC ctx flip for head-%d\n", - head->base.index); + drm_dbg_kms(dev, "Lock contended, delaying CRC ctx flip for %s\n", crtc->name); drm_vblank_work_schedule(work, drm_crtc_vblank_count(crtc) + 1, true); return; } - DRM_DEV_DEBUG_KMS(crtc->dev->dev, - "Flipping notifier ctx for head %d (%d -> %d)\n", - drm_crtc_index(crtc), crc->ctx_idx, new_idx); + drm_dbg_kms(dev, "Flipping notifier ctx for %s (%d -> %d)\n", + crtc->name, crc->ctx_idx, new_idx); nv50_crc_program_ctx(head, NULL); nv50_crc_program_ctx(head, &crc->ctx[new_idx]); @@ -189,9 +187,9 @@ void nv50_crc_handle_vblank(struct nv50_head *head) * updates back-to-back without waiting, we'll just be * optimistic and assume we always miss exactly one frame. */ - DRM_DEV_DEBUG_KMS(head->base.base.dev->dev, - "Notifier ctx flip for head-%d finished, lost CRC for frame %llu\n", - head->base.index, crc->frame); + drm_dbg_kms(head->base.base.dev, + "Notifier ctx flip for head-%d finished, lost CRC for frame %llu\n", + head->base.index, crc->frame); crc->frame++; nv50_crc_reset_ctx(ctx); -- 2.29.2

2 1

Let lockdep complain when locks are taken while waiting for userspace.
by Christian König 19 Jan '21

19 Jan '21

Hi guys, because of the Vulkan graphics API we have a specialized synchronization object to handle both inter process as well as process to hardware synchronization. The problem is now that when drivers call this interface with some lock help it is trivial to create a deadlock when those locks are also needed in a page fault for example. The idea of this patch is now to let lockdep complain when any locks are called when the interface is used. Please review and/or comment. Thanks, Christian.

4 6

[PATCH v7 0/5] drm/i915: Add support for Intel's eDP backlight controls
by Lyude Paul 19 Jan '21

19 Jan '21

A while ago we ran into issues while trying to enable the eDP backlight control interface as defined by VESA, in order to make the DPCD backlight controls on newer laptop panels work. The issue ended up being much more complicated however, as we also apparently needed to add support for an Intel-specific DPCD backlight control interface as the VESA interface is broken on many laptop panels. For lack of a better name, we just call this the Intel HDR backlight interface. While this only adds support for the SDR backlight mode (I think), this will fix a lot of user's laptop panels that we weren't able to properly automatically detect DPCD backlight controls on previously. Series-wide changes in v7: * Add another patch that allows passing the current display pipe to intel_panel_bl_funcs.get(), which should fix the lockdep issues we were seeing with Intel's CI Lyude Paul (5): drm/i915: Pass port to intel_panel_bl_funcs.get() drm/i915: Keep track of pwm-related backlight hooks separately drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now) drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight drm/dp: Revert "drm/dp: Introduce EDID-based quirks" drivers/gpu/drm/drm_dp_helper.c | 83 +--- drivers/gpu/drm/drm_dp_mst_topology.c | 3 +- .../drm/i915/display/intel_display_types.h | 16 +- drivers/gpu/drm/i915/display/intel_dp.c | 9 +- .../drm/i915/display/intel_dp_aux_backlight.c | 290 +++++++++++-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +- .../i915/display/intel_dsi_dcs_backlight.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 395 ++++++++++-------- drivers/gpu/drm/i915/display/intel_panel.h | 4 + drivers/gpu/drm/i915/display/intel_psr.c | 2 +- drivers/gpu/drm/i915/i915_params.c | 2 +- include/drm/drm_dp_helper.h | 21 +- 12 files changed, 519 insertions(+), 311 deletions(-) -- 2.29.2

3 9

[drm-intel:drm-intel-next 8/19] drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'.
by Dan Carpenter 19 Jan '21

19 Jan '21

tree: git://anongit.freedesktop.org/drm-intel drm-intel-next head: d5a0d4b9380a499cc140c7ee04ec80e15a8d49e5 commit: 2a743b7b8a8be8c8fc7c130c304c1243f6bbe9b7 [8/19] drm/i915/hdcp: Configure HDCP1.4 MST steram encryption status config: x86_64-randconfig-m001-20210115 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> smatch warnings: drivers/gpu/drm/i915/display/intel_hdcp.c:817 _intel_hdcp_disable() error: uninitialized symbol 'ret'. vim +/ret +817 drivers/gpu/drm/i915/display/intel_hdcp.c ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 788 static int _intel_hdcp_disable(struct intel_connector *connector) ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 789 { 7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 790 struct intel_digital_port *dig_port = intel_attached_dig_port(connector); 486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 791 struct drm_i915_private *dev_priv = to_i915(connector->base.dev); 486bba4524e00c drivers/gpu/drm/i915/display/intel_hdcp.c Ville Syrjälä 2019-12-04 792 struct intel_hdcp *hdcp = &connector->hdcp; 7801f3b792b0fd drivers/gpu/drm/i915/display/intel_hdcp.c Lucas De Marchi 2020-06-30 793 enum port port = dig_port->base.port; 692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 794 enum transcoder cpu_transcoder = hdcp->cpu_transcoder; 2cc0c7b520bf8e drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 795 u32 repeater_ctl; ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 796 int ret; ^^^^^^^ ee5e5e7a5e0fde drivers/gpu/drm/i915/intel_hdcp.c Sean Paul 2018-01-08 797 65833c463886fa drivers/gpu/drm/i915/display/intel_hdcp.c Wambui Karuga 2020-01-22 798 drm_dbg_kms(&dev_priv->drm, "[%s:%d] HDCP is being disabled...\n", cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 799 connector->base.name, connector->base.base.id); cb340bf37173d6 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2018-02-03 800 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 801 if (hdcp->shim->stream_encryption) { 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 802 ret = hdcp->shim->stream_encryption(connector, false); 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 803 if (ret) { 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 804 drm_err(&dev_priv->drm, "[%s:%d] Failed to disable HDCP 1.4 stream enc\n", 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 805 connector->base.name, connector->base.base.id); 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 806 return ret; 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 807 } 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 808 drm_dbg_kms(&dev_priv->drm, "HDCP 1.4 transcoder: %s stream encryption disabled\n", 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 809 transcoder_name(hdcp->stream_transcoder)); 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 810 } 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 811 36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 812 /* 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 813 * If there are other connectors on this port using HDCP, don't disable it 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 814 * until it disabled HDCP encryption for all connectors in MST topology. 36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 815 */ 2a743b7b8a8be8 drivers/gpu/drm/i915/display/intel_hdcp.c Anshuman Gupta 2021-01-11 816 if (dig_port->num_hdcp_streams > 0) 36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 @817 return ret; Presumably an error code was intended instead of an unintialized variable. 36e5e7042b2020 drivers/gpu/drm/i915/display/intel_hdcp.c Sean Paul 2020-08-18 818 09d56393c1d8d5 drivers/gpu/drm/i915/intel_hdcp.c Ramalingam C 2019-02-16 819 hdcp->hdcp_encrypted = false; 667944ad77f197 drivers/gpu/drm/i915/display/intel_hdcp.c Jani Nikula 2020-01-27 820 intel_de_write(dev_priv, HDCP_CONF(dev_priv, cpu_transcoder, port), 0); 692059318c0fc6 drivers/gpu/drm/i915/display/intel_hdcp.c Ramalingam C 2019-08-28 821 if (intel_de_wait_for_clear(dev_priv, --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

← Newer
1
...
42
43
44
45
46
47
48
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2021