dri-devel August 2021

dri-devel@lists.freedesktop.org

324 participants
762 discussions

[PATCH] drm/plane: Fix comment typo
by Alyssa Rosenzweig 29 Aug '21

29 Aug '21

Minor typofix noticed when reading the KMS documentation. Signed-off-by: Alyssa Rosenzweig <alyssa(a)rosenzweig.io> --- include/drm/drm_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index fed97e35626f..0c1102dc4d88 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -43,7 +43,7 @@ enum drm_scaling_filter { /** * struct drm_plane_state - mutable plane state * - * Please not that the destination coordinates @crtc_x, @crtc_y, @crtc_h and + * Please note that the destination coordinates @crtc_x, @crtc_y, @crtc_h and * @crtc_w and the source coordinates @src_x, @src_y, @src_h and @src_w are the * raw coordinates provided by userspace. Drivers should use * drm_atomic_helper_check_plane_state() and only use the derived rectangles in -- 2.30.2

2 1

Re: [PATCH v3 0/3] Remove all strcpy() uses
by ahmad almhmwd 29 Aug '21

29 Aug '21

1 0

Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual device
by ahmad almhmwd 29 Aug '21

29 Aug '21

1 0

dri, nouveau: BUG: KASAN: use-after-free in dma_fence_signal_timestamp_locked+0x399/0x430
by Mike Galbraith 29 Aug '21

29 Aug '21

Enabling kasan or kcsan in my GTX-980 equipped box will in fairly short order result in emission of a use-after-free detection gripe (no access assert in kcsan case.. same same), immediately followed by a small mushroom cloud as the kernel attempts to access the twilight zone. The below (brought to you by me forgetting to boot nomodeset despite knowing full well that nouveau WILL muck up any testing with either of these tools:) is x86-tip, with lockdep and kasan enabled. Branch isn't really irrelevant, it explodes just as readily in master. [ 604.071721] ================================================================== [ 604.072204] BUG: KASAN: use-after-free in dma_fence_signal_timestamp_locked+0x399/0x430 [ 604.072269] Read of size 8 at addr ffff8881fffa0b28 by task swapper/1/0 [ 604.072330] [ 604.072351] CPU: 1 PID: 0 Comm: swapper/1 Kdump: loaded Tainted: G E 5.14.0.g29fb75d-tip_debug #19 [ 604.072439] Hardware name: MEDION MS-7848/MS-7848, BIOS M7848W08.20C 09/23/2013 [ 604.072502] Call Trace: [ 604.072530] <IRQ> [ 604.072563] dump_stack_lvl+0x45/0x59 [ 604.072605] print_address_description.constprop.0+0x1f/0x140 [ 604.072650] ? dma_fence_signal_timestamp_locked+0x399/0x430 [ 604.072708] kasan_report.cold+0x83/0xdf [ 604.072761] ? dma_fence_signal_timestamp_locked+0x399/0x430 [ 604.072820] dma_fence_signal_timestamp_locked+0x399/0x430 [ 604.072865] ? perf_trace_dma_fence+0x940/0x940 [ 604.072916] ? ktime_get+0x64/0x160 [ 604.072955] ? ktime_get+0x99/0x160 [ 604.072981] nouveau_fence_signal+0x11/0x210 [nouveau] [ 604.073161] nouveau_fence_wait_uevent_handler+0x116/0x220 [nouveau] [ 604.073333] ? __lock_release+0xec/0x4e0 [ 604.073367] nvif_notify+0x276/0x4f0 [nouveau] [ 604.073490] ? nvif_notify_get+0x170/0x170 [nouveau] [ 604.073623] ? nvkm_notify_send+0x195/0x510 [nouveau] [ 604.073760] ? do_raw_spin_unlock+0x55/0x1f0 [ 604.073814] nvkm_notify_send+0x238/0x510 [nouveau] [ 604.073903] ? do_raw_spin_unlock+0x55/0x1f0 [ 604.073934] nvkm_event_send+0x1e3/0x2d0 [nouveau] [ 604.074069] ? validate_chain+0x124/0xd50 [ 604.074096] nvkm_fifo_uevent+0x60/0x70 [nouveau] [ 604.074257] ? nvkm_fifo_cevent+0x20/0x20 [nouveau] [ 604.074367] ? check_prev_add+0x20c0/0x20c0 [ 604.074409] ? mark_lock+0xc3/0xac0 [ 604.074448] gk104_fifo_intr+0x627/0x960 [nouveau] [ 604.074585] nvkm_mc_intr+0x407/0x5e0 [nouveau] [ 604.074715] ? __lock_acquire+0xad9/0x17b0 [ 604.074765] nvkm_pci_intr+0x12b/0x190 [nouveau] [ 604.074912] ? nvkm_pci_init+0x1d0/0x1d0 [nouveau] [ 604.075076] ? nvkm_pci_init+0x1d0/0x1d0 [nouveau] [ 604.075202] __handle_irq_event_percpu+0x24a/0x640 [ 604.075240] handle_irq_event+0xef/0x230 [ 604.075285] ? handle_irq_event_percpu+0x100/0x100 [ 604.075348] handle_edge_irq+0x20d/0xb70 [ 604.075408] __common_interrupt+0x94/0x1e0 [ 604.075459] common_interrupt+0x9f/0xd0 [ 604.075503] </IRQ> [ 604.075533] asm_common_interrupt+0x1e/0x40 [ 604.075576] RIP: 0010:cpuidle_enter_state+0x1f8/0x8d0 [ 604.075629] Code: 00 41 8b 77 04 bf ff ff ff ff e8 43 ef ff ff 31 ff e8 0c 15 fe fe 80 7c 24 08 00 0f 85 9e 01 00 00 e8 bc aa 22 ff fb 45 85 e4 <0f> 88 8c 02 00 00 49 63 ec 48 8d 44 6d 00 48 8d 44 85 00 48 8d 7c [ 604.075781] RSP: 0018:ffff8881009bfdc8 EFLAGS: 00000206 [ 604.075835] RAX: 0000000000701531 RBX: ffffffff83a34520 RCX: 1ffffffff078ba21 [ 604.075899] RDX: 0000000000000000 RSI: ffffffff82e83020 RDI: ffffffff82fa1660 [ 604.075962] RBP: 0000000000000003 R08: 0000000000000001 R09: ffffffff83c5f617 [ 604.076025] R10: fffffbfff078bec2 R11: 0000000000000001 R12: 0000000000000003 [ 604.076088] R13: ffff8883ce8c564c R14: 0000008ca56ecfa2 R15: ffff8883ce8c5648 [ 604.076179] ? cpuidle_enter_state+0x1f4/0x8d0 [ 604.076238] cpuidle_enter+0x4a/0xa0 [ 604.076283] cpuidle_idle_call+0x255/0x3c0 [ 604.076328] ? arch_cpu_idle_exit+0x40/0x40 [ 604.076372] ? tsc_verify_tsc_adjust+0x9c/0x2e0 [ 604.076418] ? lockdep_hardirqs_off+0x90/0xd0 [ 604.076472] do_idle+0xd7/0x140 [ 604.076513] cpu_startup_entry+0x19/0x20 [ 604.076554] start_secondary+0x250/0x2f0 [ 604.076598] ? set_cpu_sibling_map+0x1c20/0x1c20 [ 604.076657] secondary_startup_64_no_verify+0xb0/0xbb [ 604.076742] [ 604.076762] Allocated by task 2004: [ 604.076796] kasan_save_stack+0x1b/0x40 [ 604.076836] __kasan_kmalloc+0x7c/0x90 [ 604.076873] nouveau_gem_object_close+0x300/0x7f0 [nouveau] [ 604.077060] drm_gem_object_release_handle+0x69/0xf0 [drm] [ 604.077171] drm_gem_handle_delete+0x5b/0xa0 [drm] [ 604.077260] drm_ioctl_kernel+0x1a7/0x240 [drm] [ 604.077349] drm_ioctl+0x400/0x8b0 [drm] [ 604.077453] nouveau_drm_ioctl+0xec/0x230 [nouveau] [ 604.077630] __x64_sys_ioctl+0x11c/0x170 [ 604.077671] do_syscall_64+0x38/0x90 [ 604.077707] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 604.077754] [ 604.077772] Freed by task 4941: [ 604.077803] kasan_save_stack+0x1b/0x40 [ 604.077840] kasan_set_track+0x1c/0x30 [ 604.077877] kasan_set_free_info+0x20/0x30 [ 604.077917] __kasan_slab_free+0xec/0x130 [ 604.077955] slab_free_freelist_hook+0x90/0x1a0 [ 604.077999] kfree+0xcc/0x510 [ 604.078031] nouveau_gem_object_delete_work+0x7f/0xa0 [nouveau] [ 604.078215] nouveau_cli_work+0x1ec/0x330 [nouveau] [ 604.078390] process_one_work+0x89c/0x14d0 [ 604.078431] worker_thread+0x57d/0x1310 [ 604.078468] kthread+0x335/0x400 [ 604.078501] ret_from_fork+0x1f/0x30 [ 604.078537] [ 604.078555] The buggy address belongs to the object at ffff8881fffa0b00 which belongs to the cache kmalloc-96 of size 96 [ 604.078654] The buggy address is located 40 bytes inside of 96-byte region [ffff8881fffa0b00, ffff8881fffa0b60) [ 604.078747] The buggy address belongs to the page: [ 604.078790] page:000000005085aa1b refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1fffa0 [ 604.078868] flags: 0x2ffe00000000200(slab|node=0|zone=2|lastcpupid=0x7ff) [ 604.078931] raw: 02ffe00000000200 0000000000000000 dead000000000122 ffff888100042780 [ 604.078996] raw: 0000000000000000 0000000000200020 00000001ffffffff 0000000000000000 [ 604.079059] page dumped because: kasan: bad access detected [ 604.079107] [ 604.079125] Memory state around the buggy address: [ 604.079168] ffff8881fffa0a00: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc [ 604.079238] ffff8881fffa0a80: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc [ 604.079299] >ffff8881fffa0b00: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc [ 604.079360] ^ [ 604.079401] ffff8881fffa0b80: 00 00 00 00 00 00 00 00 00 00 00 00 fc fc fc fc [ 604.079480] ffff8881fffa0c00: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc [ 604.079553] ================================================================== [ 604.079631] Disabling lock debugging due to kernel taint [ 604.079653] general protection fault, probably for non-canonical address 0xaf600177000016b5: 0000 [#1] PREEMPT SMP KASAN NOPTI [ 604.079675] CPU: 1 PID: 0 Comm: swapper/1 Kdump: loaded Tainted: G B E 5.14.0.g29fb75d-tip_debug #19 [ 604.079696] Hardware name: MEDION MS-7848/MS-7848, BIOS M7848W08.20C 09/23/2013 [ 604.079710] RIP: 0010:queue_work_on+0x2f/0x80 [ 604.079723] Code: 41 56 41 55 49 89 f5 41 54 49 89 d4 55 89 fd 53 9c 58 fa 25 00 02 00 00 48 89 c3 75 33 be 08 00 00 00 4c 89 e7 e8 c1 dc 5b 00 <f0> 49 0f ba 2c 24 00 41 be 00 00 00 00 73 1e 48 85 db 74 06 e8 58 [ 604.079752] RSP: 0018:ffff8883ce88fa88 EFLAGS: 00010002 [ 604.079767] RAX: 0000000000000001 RBX: 0000000000000000 RCX: ffffffff81190eff [ 604.079781] RDX: 0000000000000001 RSI: 0000000000000008 RDI: af600177000016b5 [ 604.079795] RBP: 0000000000000008 R08: 0000000000000001 R09: af600177000016bd [ 604.079809] R10: fffffbfff0723948 R11: 0000000000000001 R12: af600177000016b5 [ 604.079823] R13: ffff88810005b000 R14: 1ffff11079d11f58 R15: ffff8881fffa0580 [ 604.079837] FS: 0000000000000000(0000) GS:ffff8883ce880000(0000) knlGS:0000000000000000 [ 604.079853] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 604.079866] CR2: 00007fd91d12000b CR3: 000000000782a001 CR4: 00000000001706e0 [ 604.079880] Call Trace: [ 604.079888] <IRQ> [ 604.079897] dma_fence_signal_timestamp_locked+0x213/0x430 [ 604.079915] ? perf_trace_dma_fence+0x940/0x940 [ 604.079929] ? ktime_get+0x64/0x160 [ 604.079941] ? ktime_get+0x99/0x160 [ 604.079955] nouveau_fence_signal+0x11/0x210 [nouveau] [ 604.080091] nouveau_fence_wait_uevent_handler+0x116/0x220 [nouveau] [ 604.080248] ? __lock_release+0xec/0x4e0 [ 604.080263] nvif_notify+0x276/0x4f0 [nouveau] [ 604.080398] ? nvif_notify_get+0x170/0x170 [nouveau] [ 604.080533] ? nvkm_notify_send+0x195/0x510 [nouveau] [ 604.080671] ? do_raw_spin_unlock+0x55/0x1f0 [ 604.080684] nvkm_notify_send+0x238/0x510 [nouveau] [ 604.080788] ? do_raw_spin_unlock+0x55/0x1f0 [ 604.080813] nvkm_event_send+0x1e3/0x2d0 [nouveau] [ 604.080926] ? validate_chain+0x124/0xd50 [ 604.080939] nvkm_fifo_uevent+0x60/0x70 [nouveau] [ 604.081080] ? nvkm_fifo_cevent+0x20/0x20 [nouveau] [ 604.081228] ? check_prev_add+0x20c0/0x20c0 [ 604.081239] ? mark_lock+0xc3/0xac0 [ 604.081250] gk104_fifo_intr+0x627/0x960 [nouveau] [ 604.081394] nvkm_mc_intr+0x407/0x5e0 [nouveau] [ 604.081525] ? __lock_acquire+0xad9/0x17b0 [ 604.081539] nvkm_pci_intr+0x12b/0x190 [nouveau] [ 604.081667] ? nvkm_pci_init+0x1d0/0x1d0 [nouveau] [ 604.081793] ? nvkm_pci_init+0x1d0/0x1d0 [nouveau] [ 604.081926] __handle_irq_event_percpu+0x24a/0x640 [ 604.081942] handle_irq_event+0xef/0x230 [ 604.081954] ? handle_irq_event_percpu+0x100/0x100 [ 604.081968] handle_edge_irq+0x20d/0xb70 [ 604.081982] __common_interrupt+0x94/0x1e0 [ 604.081996] common_interrupt+0x9f/0xd0 [ 604.082009] </IRQ> [ 604.082017] asm_common_interrupt+0x1e/0x40 [ 604.082028] RIP: 0010:cpuidle_enter_state+0x1f8/0x8d0 [ 604.082043] Code: 00 41 8b 77 04 bf ff ff ff ff e8 43 ef ff ff 31 ff e8 0c 15 fe fe 80 7c 24 08 00 0f 85 9e 01 00 00 e8 bc aa 22 ff fb 45 85 e4 <0f> 88 8c 02 00 00 49 63 ec 48 8d 44 6d 00 48 8d 44 85 00 48 8d 7c [ 604.082070] RSP: 0018:ffff8881009bfdc8 EFLAGS: 00000206 [ 604.082083] RAX: 0000000000701531 RBX: ffffffff83a34520 RCX: 1ffffffff078ba21 [ 604.082097] RDX: 0000000000000000 RSI: ffffffff82e83020 RDI: ffffffff82fa1660 [ 604.082110] RBP: 0000000000000003 R08: 0000000000000001 R09: ffffffff83c5f617 [ 604.082123] R10: fffffbfff078bec2 R11: 0000000000000001 R12: 0000000000000003 [ 604.082137] R13: ffff8883ce8c564c R14: 0000008ca56ecfa2 R15: ffff8883ce8c5648 [ 604.082157] ? cpuidle_enter_state+0x1f4/0x8d0 [ 604.082172] cpuidle_enter+0x4a/0xa0 [ 604.082185] cpuidle_idle_call+0x255/0x3c0 [ 604.082198] ? arch_cpu_idle_exit+0x40/0x40 [ 604.082210] ? tsc_verify_tsc_adjust+0x9c/0x2e0 [ 604.082222] ? lockdep_hardirqs_off+0x90/0xd0 [ 604.082236] do_idle+0xd7/0x140 [ 604.082248] cpu_startup_entry+0x19/0x20 [ 604.082259] start_secondary+0x250/0x2f0 [ 604.082271] ? set_cpu_sibling_map+0x1c20/0x1c20 [ 604.082286] secondary_startup_64_no_verify+0xb0/0xbb [ 604.082305] Modules linked in: overlay(E) sr_mod(E) cdrom(E) btrfs(E) blake2b_generic(E) xor(E) raid6_pq(E) xfs(E) libcrc32c(E) loop(E) af_packet(E) ip6table_mangle(E) ip6table_raw(E) iptable_raw(E) nfnetlink(E) bridge(E) ebtable_filter(E) stp(E) llc(E) ebtables(E) iscsi_ibft(E) iscsi_boot_sysfs(E) ip6table_filter(E) ip6_tables(E) rfkill(E) iptable_filter(E) ip_tables(E) x_tables(E) bpfilter(E) nls_iso8859_1(E) nls_cp437(E) usblp(E) joydev(E) intel_rapl_msr(E) intel_rapl_common(E) x86_pkg_temp_thermal(E) intel_powerclamp(E) coretemp(E) kvm_intel(E) iTCO_wdt(E) intel_pmc_bxt(E) at24(E) mei_hdcp(E) regmap_i2c(E) iTCO_vendor_support(E) kvm(E) snd_hda_codec_realtek(E) snd_hda_codec_hdmi(E) snd_hda_codec_generic(E) ledtrig_audio(E) irqbypass(E) crct10dif_pclmul(E) crc32_pclmul(E) ghash_clmulni_intel(E) snd_hda_intel(E) snd_intel_dspcfg(E) aesni_intel(E) crypto_simd(E) cryptd(E) snd_hda_codec(E) r8169(E) snd_hwdep(E) i2c_i801(E) snd_hda_core(E) i2c_smbus(E) pcspkr(E) realtek(E) snd_pcm(E) [ 604.082429] mdio_devres(E) snd_timer(E) lpc_ich(E) snd(E) libphy(E) mei_me(E) mfd_core(E) mei(E) soundcore(E) fan(E) thermal(E) intel_smartconnect(E) sch_fq_codel(E) nfsd(E) auth_rpcgss(E) nfs_acl(E) lockd(E) grace(E) fuse(E) configfs(E) sunrpc(E) hid_logitech_hidpp(E) hid_logitech_dj(E) uas(E) usb_storage(E) hid_generic(E) usbhid(E) nouveau(E) drm_ttm_helper(E) ttm(E) wmi(E) i2c_algo_bit(E) drm_kms_helper(E) syscopyarea(E) sysfillrect(E) sysimgblt(E) fb_sys_fops(E) cec(E) rc_core(E) ahci(E) libahci(E) xhci_pci(E) drm(E) ehci_pci(E) libata(E) ehci_hcd(E) xhci_hcd(E) usbcore(E) video(E) button(E) sd_mod(E) t10_pi(E) vfat(E) fat(E) virtio_blk(E) virtio_mmio(E) virtio_ring(E) virtio(E) ext4(E) crc32c_intel(E) crc16(E) mbcache(E) jbd2(E) sg(E) dm_multipath(E) dm_mod(E) scsi_dh_rdac(E) scsi_dh_emc(E) scsi_dh_alua(E) scsi_mod(E) msr(E) efivarfs(E) autofs4(E) [ 604.082768] Dumping ftrace buffer: [ 604.082781] (ftrace buffer empty)

1 1

[drm-intel:drm-intel-next 14/14] drivers/gpu/drm/i915/display/intel_fb.c:1232:23: warning: unused parameter 'file'
by kernel test robot 28 Aug '21

28 Aug '21

tree: git://anongit.freedesktop.org/drm-intel drm-intel-next head: 705d4feeb269e22c4850ad66e2210b737b553236 commit: 705d4feeb269e22c4850ad66e2210b737b553236 [14/14] drm/i915/fb: move user framebuffer stuff to intel_fb.c config: i386-randconfig-a004-20210827 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 1076082a0d97bd5c16a25ee7cf3dbb6ee4b5a9fe) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add drm-intel git://anongit.freedesktop.org/drm-intel git fetch --no-tags drm-intel drm-intel-next git checkout 705d4feeb269e22c4850ad66e2210b737b553236 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): drivers/gpu/drm/i915/i915_gpu_error.h:299:65: warning: unused parameter 'ee' [-Wunused-parameter] intel_engine_coredump_add_request(struct intel_engine_coredump *ee, ^ drivers/gpu/drm/i915/i915_gpu_error.h:300:28: warning: unused parameter 'rq' [-Wunused-parameter] struct i915_request *rq, ^ drivers/gpu/drm/i915/i915_gpu_error.h:301:13: warning: unused parameter 'gfp' [-Wunused-parameter] gfp_t gfp) ^ drivers/gpu/drm/i915/i915_gpu_error.h:307:61: warning: unused parameter 'ee' [-Wunused-parameter] intel_engine_coredump_add_vma(struct intel_engine_coredump *ee, ^ drivers/gpu/drm/i915/i915_gpu_error.h:308:43: warning: unused parameter 'capture' [-Wunused-parameter] struct intel_engine_capture_vma *capture, ^ drivers/gpu/drm/i915/i915_gpu_error.h:309:36: warning: unused parameter 'compress' [-Wunused-parameter] struct i915_vma_compress *compress) ^ drivers/gpu/drm/i915/i915_gpu_error.h:314:52: warning: unused parameter 'gt' [-Wunused-parameter] i915_vma_capture_prepare(struct intel_gt_coredump *gt) ^ drivers/gpu/drm/i915/i915_gpu_error.h:320:51: warning: unused parameter 'gt' [-Wunused-parameter] i915_vma_capture_finish(struct intel_gt_coredump *gt, ^ drivers/gpu/drm/i915/i915_gpu_error.h:321:30: warning: unused parameter 'compress' [-Wunused-parameter] struct i915_vma_compress *compress) ^ drivers/gpu/drm/i915/i915_gpu_error.h:326:50: warning: unused parameter 'error' [-Wunused-parameter] i915_error_state_store(struct i915_gpu_coredump *error) ^ drivers/gpu/drm/i915/i915_gpu_error.h:330:68: warning: unused parameter 'gpu' [-Wunused-parameter] static inline void i915_gpu_coredump_put(struct i915_gpu_coredump *gpu) ^ drivers/gpu/drm/i915/i915_gpu_error.h:335:49: warning: unused parameter 'i915' [-Wunused-parameter] i915_first_error_state(struct drm_i915_private *i915) ^ drivers/gpu/drm/i915/i915_gpu_error.h:340:68: warning: unused parameter 'i915' [-Wunused-parameter] static inline void i915_reset_error_state(struct drm_i915_private *i915) ^ drivers/gpu/drm/i915/i915_gpu_error.h:344:70: warning: unused parameter 'i915' [-Wunused-parameter] static inline void i915_disable_error_state(struct drm_i915_private *i915, ^ drivers/gpu/drm/i915/i915_gpu_error.h:345:14: warning: unused parameter 'err' [-Wunused-parameter] int err) ^ In file included from drivers/gpu/drm/i915/display/intel_fb.c:10: drivers/gpu/drm/i915/display/intel_display_types.h:1757:8: warning: comparison of integers of different signs: 'enum pipe' and 'unsigned int' [-Wsign-compare] pipe < ARRAY_SIZE(i915->pipe_to_crtc_mapping) && ~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:715:61: warning: comparison of integers of different signs: 'int' and 'const unsigned int' [-Wsign-compare] (*x + plane_width) * fb->base.format->cpp[color_plane] > fb->base.pitches[color_plane]) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:763:69: warning: unused parameter 'color_plane' [-Wunused-parameter] plane_view_dst_stride_tiles(const struct intel_framebuffer *fb, int color_plane, ^ drivers/gpu/drm/i915/display/intel_fb.c:777:56: warning: unused parameter 'fb' [-Wunused-parameter] plane_view_width_tiles(const struct intel_framebuffer *fb, int color_plane, ^ drivers/gpu/drm/i915/display/intel_fb.c:777:64: warning: unused parameter 'color_plane' [-Wunused-parameter] plane_view_width_tiles(const struct intel_framebuffer *fb, int color_plane, ^ drivers/gpu/drm/i915/display/intel_fb.c:785:57: warning: unused parameter 'fb' [-Wunused-parameter] plane_view_height_tiles(const struct intel_framebuffer *fb, int color_plane, ^ drivers/gpu/drm/i915/display/intel_fb.c:785:65: warning: unused parameter 'color_plane' [-Wunused-parameter] plane_view_height_tiles(const struct intel_framebuffer *fb, int color_plane, ^ drivers/gpu/drm/i915/display/intel_fb.c:817:3: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare] check_array_bounds(i915, view->gtt.rotated.plane, color_plane); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:14:70: note: expanded from macro 'check_array_bounds' #define check_array_bounds(i915, a, i) drm_WARN_ON(&(i915)->drm, (i) >= ARRAY_SIZE(a)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ include/drm/drm_print.h:563:19: note: expanded from macro 'drm_WARN_ON' drm_WARN((drm), (x), "%s", \ ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:553:7: note: expanded from macro 'drm_WARN' WARN(condition, "%s %s: " format, \ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:130:25: note: expanded from macro 'WARN' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:841:3: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare] check_array_bounds(i915, view->gtt.remapped.plane, color_plane); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:14:70: note: expanded from macro 'check_array_bounds' #define check_array_bounds(i915, a, i) drm_WARN_ON(&(i915)->drm, (i) >= ARRAY_SIZE(a)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ include/drm/drm_print.h:563:19: note: expanded from macro 'drm_WARN_ON' drm_WARN((drm), (x), "%s", \ ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/drm/drm_print.h:553:7: note: expanded from macro 'drm_WARN' WARN(condition, "%s %s: " format, \ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:130:25: note: expanded from macro 'WARN' int __ret_warn_on = !!(condition); \ ^~~~~~~~~ drivers/gpu/drm/i915/display/intel_fb.c:937:16: warning: variable 'cpp' set but not used [-Wunused-but-set-variable] unsigned int cpp, size; ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1232:23: warning: unused parameter 'file' [-Wunused-parameter] struct drm_file *file, ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1233:19: warning: unused parameter 'flags' [-Wunused-parameter] unsigned int flags, unsigned int color, ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1233:39: warning: unused parameter 'color' [-Wunused-parameter] unsigned int flags, unsigned int color, ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1234:28: warning: unused parameter 'clips' [-Wunused-parameter] struct drm_clip_rect *clips, ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1235:19: warning: unused parameter 'num_clips' [-Wunused-parameter] unsigned int num_clips) ^ >> drivers/gpu/drm/i915/display/intel_fb.c:1364:23: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare] if (fb->pitches[i] != ccs_aux_stride) { ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ >> drivers/gpu/drm/i915/display/intel_fb.c:1417:50: warning: unused parameter 'dev' [-Wunused-parameter] intel_user_framebuffer_create(struct drm_device *dev, ^ 1713 warnings generated. vim +/file +1232 drivers/gpu/drm/i915/display/intel_fb.c 1230 1231 static int intel_user_framebuffer_dirty(struct drm_framebuffer *fb, > 1232 struct drm_file *file, > 1233 unsigned int flags, unsigned int color, > 1234 struct drm_clip_rect *clips, > 1235 unsigned int num_clips) 1236 { 1237 struct drm_i915_gem_object *obj = intel_fb_obj(fb); 1238 1239 i915_gem_object_flush_if_display(obj); 1240 intel_frontbuffer_flush(to_intel_frontbuffer(fb), ORIGIN_DIRTYFB); 1241 1242 return 0; 1243 } 1244 1245 static const struct drm_framebuffer_funcs intel_fb_funcs = { 1246 .destroy = intel_user_framebuffer_destroy, 1247 .create_handle = intel_user_framebuffer_create_handle, 1248 .dirty = intel_user_framebuffer_dirty, 1249 }; 1250 1251 int intel_framebuffer_init(struct intel_framebuffer *intel_fb, 1252 struct drm_i915_gem_object *obj, 1253 struct drm_mode_fb_cmd2 *mode_cmd) 1254 { 1255 struct drm_i915_private *dev_priv = to_i915(obj->base.dev); 1256 struct drm_framebuffer *fb = &intel_fb->base; 1257 u32 max_stride; 1258 unsigned int tiling, stride; 1259 int ret = -EINVAL; 1260 int i; 1261 1262 intel_fb->frontbuffer = intel_frontbuffer_get(obj); 1263 if (!intel_fb->frontbuffer) 1264 return -ENOMEM; 1265 1266 i915_gem_object_lock(obj, NULL); 1267 tiling = i915_gem_object_get_tiling(obj); 1268 stride = i915_gem_object_get_stride(obj); 1269 i915_gem_object_unlock(obj); 1270 1271 if (mode_cmd->flags & DRM_MODE_FB_MODIFIERS) { 1272 /* 1273 * If there's a fence, enforce that 1274 * the fb modifier and tiling mode match. 1275 */ 1276 if (tiling != I915_TILING_NONE && 1277 tiling != intel_fb_modifier_to_tiling(mode_cmd->modifier[0])) { 1278 drm_dbg_kms(&dev_priv->drm, 1279 "tiling_mode doesn't match fb modifier\n"); 1280 goto err; 1281 } 1282 } else { 1283 if (tiling == I915_TILING_X) { 1284 mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED; 1285 } else if (tiling == I915_TILING_Y) { 1286 drm_dbg_kms(&dev_priv->drm, 1287 "No Y tiling for legacy addfb\n"); 1288 goto err; 1289 } 1290 } 1291 1292 if (!drm_any_plane_has_format(&dev_priv->drm, 1293 mode_cmd->pixel_format, 1294 mode_cmd->modifier[0])) { 1295 drm_dbg_kms(&dev_priv->drm, 1296 "unsupported pixel format %p4cc / modifier 0x%llx\n", 1297 &mode_cmd->pixel_format, mode_cmd->modifier[0]); 1298 goto err; 1299 } 1300 1301 /* 1302 * gen2/3 display engine uses the fence if present, 1303 * so the tiling mode must match the fb modifier exactly. 1304 */ 1305 if (DISPLAY_VER(dev_priv) < 4 && 1306 tiling != intel_fb_modifier_to_tiling(mode_cmd->modifier[0])) { 1307 drm_dbg_kms(&dev_priv->drm, 1308 "tiling_mode must match fb modifier exactly on gen2/3\n"); 1309 goto err; 1310 } 1311 1312 max_stride = intel_fb_max_stride(dev_priv, mode_cmd->pixel_format, 1313 mode_cmd->modifier[0]); 1314 if (mode_cmd->pitches[0] > max_stride) { 1315 drm_dbg_kms(&dev_priv->drm, 1316 "%s pitch (%u) must be at most %d\n", 1317 mode_cmd->modifier[0] != DRM_FORMAT_MOD_LINEAR ? 1318 "tiled" : "linear", 1319 mode_cmd->pitches[0], max_stride); 1320 goto err; 1321 } 1322 1323 /* 1324 * If there's a fence, enforce that 1325 * the fb pitch and fence stride match. 1326 */ 1327 if (tiling != I915_TILING_NONE && mode_cmd->pitches[0] != stride) { 1328 drm_dbg_kms(&dev_priv->drm, 1329 "pitch (%d) must match tiling stride (%d)\n", 1330 mode_cmd->pitches[0], stride); 1331 goto err; 1332 } 1333 1334 /* FIXME need to adjust LINOFF/TILEOFF accordingly. */ 1335 if (mode_cmd->offsets[0] != 0) { 1336 drm_dbg_kms(&dev_priv->drm, 1337 "plane 0 offset (0x%08x) must be 0\n", 1338 mode_cmd->offsets[0]); 1339 goto err; 1340 } 1341 1342 drm_helper_mode_fill_fb_struct(&dev_priv->drm, fb, mode_cmd); 1343 1344 for (i = 0; i < fb->format->num_planes; i++) { 1345 u32 stride_alignment; 1346 1347 if (mode_cmd->handles[i] != mode_cmd->handles[0]) { 1348 drm_dbg_kms(&dev_priv->drm, "bad plane %d handle\n", 1349 i); 1350 goto err; 1351 } 1352 1353 stride_alignment = intel_fb_stride_alignment(fb, i); 1354 if (fb->pitches[i] & (stride_alignment - 1)) { 1355 drm_dbg_kms(&dev_priv->drm, 1356 "plane %d pitch (%d) must be at least %u byte aligned\n", 1357 i, fb->pitches[i], stride_alignment); 1358 goto err; 1359 } 1360 1361 if (is_gen12_ccs_plane(fb, i) && !is_gen12_ccs_cc_plane(fb, i)) { 1362 int ccs_aux_stride = gen12_ccs_aux_stride(fb, i); 1363 > 1364 if (fb->pitches[i] != ccs_aux_stride) { 1365 drm_dbg_kms(&dev_priv->drm, 1366 "ccs aux plane %d pitch (%d) must be %d\n", 1367 i, 1368 fb->pitches[i], ccs_aux_stride); 1369 goto err; 1370 } 1371 } 1372 1373 /* TODO: Add POT stride remapping support for CCS formats as well. */ 1374 if (IS_ALDERLAKE_P(dev_priv) && 1375 mode_cmd->modifier[i] != DRM_FORMAT_MOD_LINEAR && 1376 !intel_fb_needs_pot_stride_remap(intel_fb) && 1377 !is_power_of_2(mode_cmd->pitches[i])) { 1378 drm_dbg_kms(&dev_priv->drm, 1379 "plane %d pitch (%d) must be power of two for tiled buffers\n", 1380 i, mode_cmd->pitches[i]); 1381 goto err; 1382 } 1383 1384 fb->obj[i] = &obj->base; 1385 } 1386 1387 ret = intel_fill_fb_info(dev_priv, intel_fb); 1388 if (ret) 1389 goto err; 1390 1391 if (intel_fb_uses_dpt(fb)) { 1392 struct i915_address_space *vm; 1393 1394 vm = intel_dpt_create(intel_fb); 1395 if (IS_ERR(vm)) { 1396 ret = PTR_ERR(vm); 1397 goto err; 1398 } 1399 1400 intel_fb->dpt_vm = vm; 1401 } 1402 1403 ret = drm_framebuffer_init(&dev_priv->drm, fb, &intel_fb_funcs); 1404 if (ret) { 1405 drm_err(&dev_priv->drm, "framebuffer init failed %d\n", ret); 1406 goto err; 1407 } 1408 1409 return 0; 1410 1411 err: 1412 intel_frontbuffer_put(intel_fb->frontbuffer); 1413 return ret; 1414 } 1415 1416 struct drm_framebuffer * > 1417 intel_user_framebuffer_create(struct drm_device *dev, 1418 struct drm_file *filp, 1419 const struct drm_mode_fb_cmd2 *user_mode_cmd) 1420 { 1421 struct drm_framebuffer *fb; 1422 struct drm_i915_gem_object *obj; 1423 struct drm_mode_fb_cmd2 mode_cmd = *user_mode_cmd; 1424 struct drm_i915_private *i915; 1425 1426 obj = i915_gem_object_lookup(filp, mode_cmd.handles[0]); 1427 if (!obj) 1428 return ERR_PTR(-ENOENT); 1429 1430 /* object is backed with LMEM for discrete */ 1431 i915 = to_i915(obj->base.dev); 1432 if (HAS_LMEM(i915) && !i915_gem_object_can_migrate(obj, INTEL_REGION_LMEM)) { 1433 /* object is "remote", not in local memory */ 1434 i915_gem_object_put(obj); 1435 return ERR_PTR(-EREMOTE); 1436 } 1437 1438 fb = intel_framebuffer_create(obj, &mode_cmd); 1439 i915_gem_object_put(obj); 1440 1441 return fb; 1442 } 1443 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH] GPU: drm: fix style errors
by F.A.Sulaiman 28 Aug '21

28 Aug '21

This patch fixes style issues in drm_ioctl.c Signed-off-by: F.A. SULAIMAN <asha.16(a)itfac.mrt.ac.lk> --- drivers/gpu/drm/drm_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index be4a52dc4d6f..1355879ab809 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -725,7 +725,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = { DRM_IOCTL_DEF(DRM_IOCTL_MODE_REVOKE_LEASE, drm_mode_revoke_lease_ioctl, DRM_MASTER), }; -#define DRM_CORE_IOCTL_COUNT ARRAY_SIZE( drm_ioctls ) +#define DRM_CORE_IOCTL_COUNT ARRAY_SIZE(drm_ioctls) /** * DOC: driver specific ioctls @@ -834,8 +834,8 @@ long drm_ioctl(struct file *filp, if (drm_dev_is_unplugged(dev)) return -ENODEV; - if (DRM_IOCTL_TYPE(cmd) != DRM_IOCTL_BASE) - return -ENOTTY; + if (DRM_IOCTL_TYPE(cmd) != DRM_IOCTL_BASE) + return -ENOTTY; is_driver_ioctl = nr >= DRM_COMMAND_BASE && nr < DRM_COMMAND_END; -- 2.17.1

2 1

[PATCH] virtio-gpu: fix possible memory allocation failure
by liuyuntao 28 Aug '21

28 Aug '21

When kmem_cache_zalloc in virtio_gpu_get_vbuf fails, it will return an error code. But none of its callers checks this error code, and a core dump will take place. Considering many of its callers can't handle such error, I add a __GFP_NOFAIL flag when calling kmem_cache_zalloc to make sure it won't fail, and delete those unused error handlings. Fixes: dc5698e80cf724 ("Add virtio gpu driver.") Signed-off-by: Yuntao Liu <liuyuntao10(a)huawei.com> --- drivers/gpu/drm/virtio/virtgpu_vq.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index cf84d382dd41..5286cf110208 100644 --- a/drivers/gpu/drm/virtio/virtgpu_vq.c +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c @@ -91,9 +91,7 @@ virtio_gpu_get_vbuf(struct virtio_gpu_device *vgdev, { struct virtio_gpu_vbuffer *vbuf; - vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL); - if (!vbuf) - return ERR_PTR(-ENOMEM); + vbuf = kmem_cache_zalloc(vgdev->vbufs, GFP_KERNEL | __GFP_NOFAIL); BUG_ON(size > MAX_INLINE_CMD_SIZE || size < sizeof(struct virtio_gpu_ctrl_hdr)); @@ -147,10 +145,6 @@ static void *virtio_gpu_alloc_cmd_resp(struct virtio_gpu_device *vgdev, vbuf = virtio_gpu_get_vbuf(vgdev, cmd_size, resp_size, resp_buf, cb); - if (IS_ERR(vbuf)) { - *vbuffer_p = NULL; - return ERR_CAST(vbuf); - } *vbuffer_p = vbuf; return (struct virtio_gpu_command *)vbuf->buf; } -- 2.23.0

1 0

[PATCH] drm/omap: dss: Make use of the helper macro SET_RUNTIME_PM_OPS()
by Cai Huoqing 28 Aug '21

28 Aug '21

Use the helper macro SET_RUNTIME_PM_OPS() instead of the verbose operators ".runtime_suspend/.runtime_resume", because the SET_RUNTIME_PM_OPS() is a nice helper macro that could be brought in to make code a little clearer, a little more concise. Signed-off-by: Cai Huoqing <caihuoqing(a)baidu.com> --- drivers/gpu/drm/omapdrm/dss/dispc.c | 3 +-- drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +-- drivers/gpu/drm/omapdrm/dss/dss.c | 3 +-- drivers/gpu/drm/omapdrm/dss/venc.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c index 5619420cc2cc..a23587c58555 100644 --- a/drivers/gpu/drm/omapdrm/dss/dispc.c +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c @@ -4887,8 +4887,7 @@ static int dispc_runtime_resume(struct device *dev) } static const struct dev_pm_ops dispc_pm_ops = { - .runtime_suspend = dispc_runtime_suspend, - .runtime_resume = dispc_runtime_resume, + SET_RUNTIME_PM_OPS(dispc_runtime_suspend, dispc_runtime_resume, NULL) SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 5f1722b040f4..c22b2b4eae4f 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -5086,8 +5086,7 @@ static int dsi_runtime_resume(struct device *dev) } static const struct dev_pm_ops dsi_pm_ops = { - .runtime_suspend = dsi_runtime_suspend, - .runtime_resume = dsi_runtime_resume, + SET_RUNTIME_PM_OPS(dsi_runtime_suspend, dsi_runtime_resume, NULL) SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c index d6a5862b4dbf..7a4581bf63e6 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.c +++ b/drivers/gpu/drm/omapdrm/dss/dss.c @@ -1606,8 +1606,7 @@ static int dss_runtime_resume(struct device *dev) } static const struct dev_pm_ops dss_pm_ops = { - .runtime_suspend = dss_runtime_suspend, - .runtime_resume = dss_runtime_resume, + SET_RUNTIME_PM_OPS(dss_runtime_suspend, dss_runtime_resume, NULL) SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c index e522c17955d0..37d9cf876c27 100644 --- a/drivers/gpu/drm/omapdrm/dss/venc.c +++ b/drivers/gpu/drm/omapdrm/dss/venc.c @@ -902,8 +902,7 @@ static int venc_runtime_resume(struct device *dev) } static const struct dev_pm_ops venc_pm_ops = { - .runtime_suspend = venc_runtime_suspend, - .runtime_resume = venc_runtime_resume, + SET_RUNTIME_PM_OPS(venc_runtime_suspend, venc_runtime_resume, NULL) SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; -- 2.25.1

1 0

[PATCH] drm/nouveau: Make use of the helper macro SET_RUNTIME_PM_OPS()
by Cai Huoqing 28 Aug '21

28 Aug '21

Use the helper macro SET_RUNTIME_PM_OPS() instead of the verbose operators ".runtime_suspend/.runtime_resume/.runtime_idle", because the SET_RUNTIME_PM_OPS() is a nice helper macro that could be brought in to make code a little clearer, a little more concise. Signed-off-by: Cai Huoqing <caihuoqing(a)baidu.com> --- drivers/gpu/drm/nouveau/nouveau_drm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 1f828c9f691c..ba81645b4f2a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -1258,15 +1258,14 @@ static void nouveau_display_options(void) } static const struct dev_pm_ops nouveau_pm_ops = { + SET_RUNTIME_PM_OPS(nouveau_pmops_runtime_suspend, + nouveau_pmops_runtime_resume, nouveau_pmops_runtime_idle) .suspend = nouveau_pmops_suspend, .resume = nouveau_pmops_resume, .freeze = nouveau_pmops_freeze, .thaw = nouveau_pmops_thaw, .poweroff = nouveau_pmops_freeze, .restore = nouveau_pmops_resume, - .runtime_suspend = nouveau_pmops_runtime_suspend, - .runtime_resume = nouveau_pmops_runtime_resume, - .runtime_idle = nouveau_pmops_runtime_idle, }; static struct pci_driver -- 2.25.1

1 0

[PATCH] drm/gma500: Make use of the helper macro SET_RUNTIME_PM_OPS()
by Cai Huoqing 28 Aug '21

28 Aug '21

Use the helper macro SET_RUNTIME_PM_OPS() instead of the verbose operators ".runtime_suspend/.runtime_resume/.runtime_idle", because the SET_RUNTIME_PM_OPS() is a nice helper macro that could be brought in to make code a little clearer, a little more concise. Signed-off-by: Cai Huoqing <caihuoqing(a)baidu.com> --- drivers/gpu/drm/gma500/psb_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 58bce1a60a4d..d5bfa1d5c074 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -489,14 +489,12 @@ static void psb_pci_remove(struct pci_dev *pdev) } static const struct dev_pm_ops psb_pm_ops = { + SET_RUNTIME_PM_OPS(psb_runtime_suspend, psb_runtime_resume, psb_runtime_idle) .resume = gma_power_resume, .suspend = gma_power_suspend, .thaw = gma_power_thaw, .freeze = gma_power_freeze, .restore = gma_power_restore, - .runtime_suspend = psb_runtime_suspend, - .runtime_resume = psb_runtime_resume, - .runtime_idle = psb_runtime_idle, }; static const struct file_operations psb_gem_fops = { -- 2.25.1

1 0

← Newer
1
...
24
25
26
27
28
29
30
...
77
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2021