dri-devel August 2021

dri-devel@lists.freedesktop.org

324 participants
762 discussions

[Bug 214209] New: WARNING: CPU: 5 PID: 0 at drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c:284
by bugzilla-daemon＠bugzilla.kernel.org 28 Aug '21

28 Aug '21

https://bugzilla.kernel.org/show_bug.cgi?id=214209 Bug ID: 214209 Summary: WARNING: CPU: 5 PID: 0 at drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c:284 Product: Drivers Version: 2.5 Kernel Version: 5.12.8-arch1-1 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: ne-vlezay80(a)yandex.ru Regression: No 2344.383186] WARNING: CPU: 5 PID: 0 at drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c:284 gk104_fifo_engine_id+0x33/0x50 [nouveau] [ 2344.383293] Modules linked in: cfg80211 rfkill ccm algif_aead cbc des_generic libdes ecb algif_skcipher cmac md4 algif_hash af_alg edac_mce_amd kvm_amd ccp rng_core snd_hda_codec_realtek snd_hda_codec_generic pktcdvd kvm ledtrig_audio snd_hda_codec_hdmi snd_hda_intel irqbypass snd_intel_dspcfg snd_intel_sdw_acpi ppdev snd_hda_codec crct10dif_pclmul ghash_clmulni_intel pcspkr wmi_bmof fam15h_power snd_hda_core k10temp snd_hwdep snd_pcm joydev snd_timer mousedev parport_pc snd asus_atk0110 parport soundcore sp5100_tco i2c_piix4 mac_hid acpi_cpufreq pkcs8_key_parser speakup_soft speakup fuse bpf_preload ip_tables x_tables overlay squashfs loop nfsv3 nfs_acl nfs lockd grace sunrpc nfs_ssc fscache ata_generic pata_acpi nouveau mxm_wmi video i2c_algo_bit drm_ttm_helper ttm drm_kms_helper crc32_pclmul crc32c_intel syscopyarea sysfillrect sysimgblt fb_sys_fops cec aesni_intel r8169 realtek drm mdio_devres crypto_simd sr_mod xhci_pci cryptd pata_atiixp e1000e usbhid libphy cdrom xhci_pci_renesas [ 2344.383369] agpgart wmi [ 2344.383373] CPU: 5 PID: 0 Comm: swapper/5 Not tainted 5.12.8-arch1-1 #1 [ 2344.383375] Hardware name: System manufacturer System Product Name/M5A78L-M PLUS/USB3, BIOS 0502 11/18/2016 [ 2344.383377] RIP: 0010:gk104_fifo_engine_id+0x33/0x50 [nouveau] [ 2344.383463] Code: 74 30 8b 97 98 04 00 00 48 85 f6 74 1d 85 d2 7e 19 48 81 c7 98 03 00 00 31 c0 48 39 37 74 18 83 c0 01 48 83 c7 10 39 d0 7c f0 <0f> 0b b8 ff ff ff ff c3 b8 0f 00 00 00 c3 66 66 2e 0f 1f 84 00 00 [ 2344.383465] RSP: 0018:ffffb91cc021cd80 EFLAGS: 00010046 [ 2344.383468] RAX: 0000000000000007 RBX: ffff8e2ed6ffb030 RCX: 0000000000000007 [ 2344.383470] RDX: 0000000000000007 RSI: ffff8e2ed6ffb010 RDI: ffff8e2ed6ffb410 [ 2344.383472] RBP: 0000000000000007 R08: 0000000000000000 R09: 0000000000000007 [ 2344.383473] R10: ffffb91cc021c9b0 R11: ffffffffa20cc468 R12: 0000000000000046 [ 2344.383475] R13: ffff8e2ed6ffb010 R14: ffff8e2ed6ffb008 R15: ffff8e2ed6ffb2b8 [ 2344.383476] FS: 0000000000000000(0000) GS:ffff8e33c7d40000(0000) knlGS:0000000000000000 [ 2344.383478] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 2344.383480] CR2: 00007fd842690ff0 CR3: 0000000103834000 CR4: 00000000000406e0 [ 2344.383482] Call Trace: [ 2344.383485] <IRQ> [ 2344.383487] gk104_fifo_fault+0x10a/0x230 [nouveau] [ 2344.383576] gf100_fifo_intr_fault+0x109/0x130 [nouveau] [ 2344.383662] gk104_fifo_intr+0x2aa/0x500 [nouveau] [ 2344.383751] nvkm_mc_intr+0x129/0x170 [nouveau] [ 2344.383826] nvkm_pci_intr+0x4d/0x90 [nouveau] [ 2344.383905] __handle_irq_event_percpu+0x40/0x190 [ 2344.383911] handle_irq_event+0x58/0xb0 [ 2344.383914] handle_edge_irq+0x96/0x260 [ 2344.383917] __common_interrupt+0x41/0xa0 [ 2344.383921] common_interrupt+0x7e/0xa0 [ 2344.383925] </IRQ> [ 2344.383926] asm_common_interrupt+0x1e/0x40 [ 2344.383929] RIP: 0010:cpuidle_enter_state+0xc7/0x380 [ 2344.383934] Code: 8b 3d 75 e0 20 5f e8 c8 b8 8c ff 49 89 c5 0f 1f 44 00 00 31 ff e8 e9 c5 8c ff 45 84 ff 0f 85 da 01 00 00 fb 66 0f 1f 44 00 00 <45> 85 f6 0f 88 11 01 00 00 49 63 d6 4c 2b 2c 24 48 8d 04 52 48 8d [ 2344.383936] RSP: 0018:ffffb91cc00d7ea8 EFLAGS: 00000246 [ 2344.383938] RAX: ffff8e33c7d6c7c0 RBX: 0000000000000001 RCX: 000000000000001f [ 2344.383940] RDX: 0000000000000000 RSI: 000000001f41d11b RDI: 0000000000000000 [ 2344.383942] RBP: ffff8e2ec22c8800 R08: 00000221d81f1a05 R09: 0000000000000018 [ 2344.383943] R10: 0000000000000058 R11: 00000000000000a8 R12: ffffffffa2149f00 [ 2344.383945] R13: 00000221d81f1a05 R14: 0000000000000001 R15: 0000000000000000 [ 2344.383948] ? cpuidle_enter_state+0xb7/0x380 [ 2344.383952] cpuidle_enter+0x29/0x40 [ 2344.383955] do_idle+0x1da/0x270 [ 2344.383958] cpu_startup_entry+0x19/0x20 [ 2344.383961] secondary_startup_64_no_verify+0xc2/0xcb [ 2344.383966] ---[ end trace 27bba26894ac92fb ]--- -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 1

[Bug 214207] New: Nouveau crash after play youtube video from surf browser
by bugzilla-daemon＠bugzilla.kernel.org 28 Aug '21

28 Aug '21

https://bugzilla.kernel.org/show_bug.cgi?id=214207 Bug ID: 214207 Summary: Nouveau crash after play youtube video from surf browser Product: Drivers Version: 2.5 Kernel Version: 5.10.0-8-amd64 Hardware: x86-64 OS: Linux Tree: Mainline Status: NEW Severity: high Priority: P1 Component: Video(DRI - non Intel) Assignee: drivers_video-dri(a)kernel-bugs.osdl.org Reporter: ne-vlezay80(a)yandex.ru Regression: No Log: [ 796.192899] nouveau 0000:01:00.0: fifo: PBDMA0: 00040000 [PBENTRY] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0000 data 00000000 [ 796.192919] nouveau 0000:01:00.0: gr: DATA_ERROR 0000000d [BEGIN_END_ACTIVE] ch 7 [003f8f9000 Xorg[1301]] subc 0 class a197 mthd 1614 data 00000000 [ 796.391497] nouveau 0000:01:00.0: gr: DATA_ERROR 0000000c [INVALID_BITFIELD] ch 7 [003f8f9000 Xorg[1301]] subc 0 class a197 mthd 2384 data 02580000 [ 796.391511] nouveau 0000:01:00.0: fifo: PBDMA0: 00040000 [PBENTRY] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0000 data 00000000 [ 796.391524] nouveau 0000:01:00.0: gr: TRAP ch 7 [003f8f9000 Xorg[1301]] [ 796.391528] nouveau 0000:01:00.0: gr: DISPATCH 80000002 [CLASS_SUBCH_MISMATCH] [ 796.391536] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 000c data 00000040 [ 796.391548] nouveau 0000:01:00.0: fifo: PBDMA0: 02000000 [SEMAPHORE] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 001c data 200503f8 [ 796.391564] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0030 data 00000000 [ 796.391580] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0034 data 2001054e [ 796.391595] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0038 data 00000001 [ 796.391610] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 003c data 2003048a [ 796.391625] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0040 data 00000320 [ 796.391638] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0044 data 00000258 [ 796.391652] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0048 data 00010001 [ 796.391664] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 004c data 200105e7 [ 796.391820] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0054 data 20010487 [ 796.391833] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0058 data 0fac6881 [ 796.391847] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 005c data 80000574 [ 796.391859] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0060 data 80000671 [ 796.391872] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0064 data 800004b9 [ 796.391883] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0068 data 80000e04 [ 796.391896] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 006c data 800103e4 [ 796.391910] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0070 data 20010680 [ 796.391923] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0074 data 00001111 [ 796.391935] nouveau 0000:01:00.0: fifo: PBDMA0: 00400000 [METHODCRC] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 007c data 00000000 [ 796.391948] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0084 data 8000066f [ 796.391960] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0088 data 800004e0 [ 796.391973] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 008c data 800004bb [ 796.391985] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0090 data 20024062 [ 796.391999] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0094 data 00000000 [ 796.392011] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 0098 data 008e19c0 [ 796.392024] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 009c data 20024060 [ 796.392037] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 00a0 data 00000020 [ 796.392049] nouveau 0000:01:00.0: fifo: PBDMA0: 00200000 [METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 00a4 data 800105a1 [ 796.392062] nouveau 0000:01:00.0: fifo: PBDMA0: 00240000 [PBENTRY METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 00a8 data 800005a2 [ 796.392075] nouveau 0000:01:00.0: fifo: PBDMA0: 00240000 [PBENTRY METHOD] ch 7 [003f8f9000 Xorg[1301]] subc 0 mthd 00ac data 80000980 [ 796.392098] nouveau 0000:01:00.0: gr: ILLEGAL_CLASS ch 7 [003f8f9000 Xorg[1301]] subc 0 class 0320 mthd 13a8 data 02a20000 -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

1 1

[pull] amdgpu, amdkfd drm-next-5.15
by Alex Deucher 27 Aug '21

27 Aug '21

Hi Dave, Daniel, Fixes for 5.15. The following changes since commit 90a9266269eb9f71af1f323c33e1dca53527bd22: drm/amdgpu: Cancel delayed work when GFXOFF is disabled (2021-08-20 12:09:44 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-next-5.15-2021-08-27 for you to fetch changes up to 61d861cf478576d85d6032f864360a34b26084b1: drm/amd/display: Move AllowDRAMSelfRefreshOrDRAMClockChangeInVblank to bounding box (2021-08-26 13:57:33 -0400) ---------------------------------------------------------------- amd-drm-next-5.15-2021-08-27: amdgpu: - PLL fix for SI - Misc code cleanups - RAS fixes - PSP cleanups - Polaris UVD/VCE suspend fixes - aldebaran fixes - DCN3.x mclk fixes amdkfd: - CWSR fixes for arcturus and aldebaran - SVM fixes ---------------------------------------------------------------- Aurabindo Pillai (2): drm/amd/display: Update number of DCN3 clock states drm/amd/display: Remove duplicate dml init Borislav Petkov (1): drm/amdgpu: Fix build with missing pm_suspend_target_state module export Candice Li (2): drm/amd/amdgpu: add name field back to ras_common_if drm/amd/amdgpu: consolidate PSP TA init shared buf functions Christophe JAILLET (2): drm/amdgpu: switch from 'pci_' to 'dma_' API drm/radeon: switch from 'pci_' to 'dma_' API Eric Yang (1): drm/amd/display: refactor riommu invalidation wa Evan Quan (3): drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend drm/amdgpu: add missing cleanups for more ASICs on UVD/VCE suspend drm/amdgpu: drop redundant cancel_delayed_work_sync call Hawking Zhang (1): drm/amdgpu: disable GFX CGCG in aldebaran Jerry (Fangzhi) Zuo (1): drm/amd/display: Update bounding box states (v2) John Clements (4): drm/amdgpu: Add driver infrastructure for MCA RAS drm/amdgpu: Update RAS XGMI Error Query drm/amdgpu: Add support for RAS XGMI err query drm/amdgpu: Clear RAS interrupt status on aldebaran Mukul Joshi (1): drm/amdkfd: CWSR with sw scheduler on Aldebaran and Arcturus Nicholas Kazlauskas (1): drm/amd/display: Move AllowDRAMSelfRefreshOrDRAMClockChangeInVblank to bounding box Philip Yang (2): drm/amdkfd: check access permisson to restore retry fault drm/amdkfd: map SVM range with correct access permission Praful Swarnakar (1): drm/amd/display: Add Logging for HDMI color depth information Sean Keely (1): drm/amdkfd: Account for SH/SE count when setting up cu masks. Shashank Sharma (1): drm/amdgpu/OLAND: clip the ref divider max value Yifan Zhang (1): drm/amdgpu: rename amdgpu_bo_get_preferred_pin_domain drivers/gpu/drm/amd/amdgpu/Makefile | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 + drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +- .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c | 1 + .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.h | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 21 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 117 +++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_mca.h | 72 +++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 20 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_pll.h | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 142 ++++++------------ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 69 ++++++++- drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 19 ++- drivers/gpu/drm/amd/amdgpu/mca_v3_0.c | 125 ++++++++++++++++ drivers/gpu/drm/amd/amdgpu/mca_v3_0.h | 26 ++++ drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 34 ++++- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 - drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 24 +++ drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 24 +++ drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 25 +++- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 24 +++ drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 24 +++ drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 25 ++++ drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 23 +++ drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 23 +++ drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.c | 84 ++++++++--- drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager.h | 1 + drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 163 ++++++++++++++------- drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 5 +- .../amd/display/dc/dcn10/dcn10_stream_encoder.c | 11 ++ .../gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 49 +++++-- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hwseq.c | 17 --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 2 +- .../gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 - .../amd/display/dc/dml/dcn30/display_mode_vba_30.c | 7 +- .../gpu/drm/amd/display/dc/dml/display_mode_vba.c | 4 +- .../drm/amd/display/dc/inc/hw_sequencer_private.h | 1 - drivers/gpu/drm/radeon/radeon_device.c | 6 +- 53 files changed, 997 insertions(+), 258 deletions(-) create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.h create mode 100644 drivers/gpu/drm/amd/amdgpu/mca_v3_0.c create mode 100644 drivers/gpu/drm/amd/amdgpu/mca_v3_0.h

1 0

[PATCH] drm: i810: Fix spelling mistake "constext" -> "context"
by Colin King 27 Aug '21

27 Aug '21

From: Colin Ian King <colin.king(a)canonical.com> There is a spelling mistake in a printk message. Fix it. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- drivers/gpu/drm/i810/i810_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c index 9fb4dd63342f..ef141d217a72 100644 --- a/drivers/gpu/drm/i810/i810_dma.c +++ b/drivers/gpu/drm/i810/i810_dma.c @@ -479,7 +479,7 @@ static void i810EmitContextVerified(struct drm_device *dev, OUT_RING(tmp); j++; } else - printk("constext state dropped!!!\n"); + printk("context state dropped!!!\n"); } if (j & 1) -- 2.32.0

1 0

[PATCH v3] drm/amd/pm: And destination bounds checking to struct copy
by Kees Cook 27 Aug '21

27 Aug '21

In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid intentionally writing across neighboring fields. The "Board Parameters" members of the structs: struct atom_smc_dpm_info_v4_5 struct atom_smc_dpm_info_v4_6 struct atom_smc_dpm_info_v4_7 struct atom_smc_dpm_info_v4_10 are written to the corresponding members of the corresponding PPTable_t variables, but they lack destination size bounds checking, which means the compiler cannot verify at compile time that this is an intended and safe memcpy(). Since the header files are effectively immutable[1] and a struct_group() cannot be used, nor a common struct referenced by both sides of the memcpy() arguments, add a new helper, amdgpu_memcpy_trailing(), to perform the bounds checking at compile time. Replace the open-coded memcpy()s with amdgpu_memcpy_trailing() which includes enough context for the bounds checking. "objdump -d" shows no object code changes. [1] https://lore.kernel.org/lkml/e56aad3c-a06f-da07-f491-a894a570d78f@amd.com Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)linux.ie> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Hawking Zhang <Hawking.Zhang(a)amd.com> Cc: Feifei Xu <Feifei.Xu(a)amd.com> Cc: Likun Gao <Likun.Gao(a)amd.com> Cc: Jiawei Gu <Jiawei.Gu(a)amd.com> Cc: Evan Quan <evan.quan(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Reviewed-by: Lijo Lazar <lijo.lazar(a)amd.com> Acked-by: Alex Deucher <alexander.deucher(a)amd.com> Signed-off-by: Kees Cook <keescook(a)chromium.org> --- v3: rename amdgpu_memcpy_trailing() to smu_memcpy_trailing() v2: https://lore.kernel.org/lkml/20210825161957.3904130-1-keescook@chromium.org v1: https://lore.kernel.org/lkml/20210819201441.3545027-1-keescook@chromium.org --- drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h | 24 +++++++++++++++++++ .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 6 ++--- .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 8 +++---- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 5 ++-- 4 files changed, 32 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h index 715b4225f5ee..8156729c370b 100644 --- a/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h +++ b/drivers/gpu/drm/amd/pm/inc/amdgpu_smu.h @@ -1335,6 +1335,30 @@ enum smu_cmn2asic_mapping_type { #define WORKLOAD_MAP(profile, workload) \ [profile] = {1, (workload)} +/** + * smu_memcpy_trailing - Copy the end of one structure into the middle of another + * + * @dst: Pointer to destination struct + * @first_dst_member: The member name in @dst where the overwrite begins + * @last_dst_member: The member name in @dst where the overwrite ends after + * @src: Pointer to the source struct + * @first_src_member: The member name in @src where the copy begins + * + */ +#define smu_memcpy_trailing(dst, first_dst_member, last_dst_member, \ + src, first_src_member) \ +({ \ + size_t __src_offset = offsetof(typeof(*(src)), first_src_member); \ + size_t __src_size = sizeof(*(src)) - __src_offset; \ + size_t __dst_offset = offsetof(typeof(*(dst)), first_dst_member); \ + size_t __dst_size = offsetofend(typeof(*(dst)), last_dst_member) - \ + __dst_offset; \ + BUILD_BUG_ON(__src_size != __dst_size); \ + __builtin_memcpy((u8 *)(dst) + __dst_offset, \ + (u8 *)(src) + __src_offset, \ + __dst_size); \ +}) + #if !defined(SWSMU_CODE_LAYER_L2) && !defined(SWSMU_CODE_LAYER_L3) && !defined(SWSMU_CODE_LAYER_L4) int smu_get_power_limit(void *handle, uint32_t *limit, diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c index 273df66cac14..e343cc218990 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c @@ -483,10 +483,8 @@ static int arcturus_append_powerplay_table(struct smu_context *smu) if ((smc_dpm_table->table_header.format_revision == 4) && (smc_dpm_table->table_header.content_revision == 6)) - memcpy(&smc_pptable->MaxVoltageStepGfx, - &smc_dpm_table->maxvoltagestepgfx, - sizeof(*smc_dpm_table) - offsetof(struct atom_smc_dpm_info_v4_6, maxvoltagestepgfx)); - + smu_memcpy_trailing(smc_pptable, MaxVoltageStepGfx, BoardReserved, + smc_dpm_table, maxvoltagestepgfx); return 0; } diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c index f96681700c41..a5fc5d7cb6c7 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c @@ -431,16 +431,16 @@ static int navi10_append_powerplay_table(struct smu_context *smu) switch (smc_dpm_table->table_header.content_revision) { case 5: /* nv10 and nv14 */ - memcpy(smc_pptable->I2cControllers, smc_dpm_table->I2cControllers, - sizeof(*smc_dpm_table) - sizeof(smc_dpm_table->table_header)); + smu_memcpy_trailing(smc_pptable, I2cControllers, BoardReserved, + smc_dpm_table, I2cControllers); break; case 7: /* nv12 */ ret = amdgpu_atombios_get_data_table(adev, index, NULL, NULL, NULL, (uint8_t **)&smc_dpm_table_v4_7); if (ret) return ret; - memcpy(smc_pptable->I2cControllers, smc_dpm_table_v4_7->I2cControllers, - sizeof(*smc_dpm_table_v4_7) - sizeof(smc_dpm_table_v4_7->table_header)); + smu_memcpy_trailing(smc_pptable, I2cControllers, BoardReserved, + smc_dpm_table_v4_7, I2cControllers); break; default: dev_err(smu->adev->dev, "smc_dpm_info with unsupported content revision %d!\n", diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c index ec8c30daf31c..ab652028e003 100644 --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c @@ -409,9 +409,8 @@ static int aldebaran_append_powerplay_table(struct smu_context *smu) if ((smc_dpm_table->table_header.format_revision == 4) && (smc_dpm_table->table_header.content_revision == 10)) - memcpy(&smc_pptable->GfxMaxCurrent, - &smc_dpm_table->GfxMaxCurrent, - sizeof(*smc_dpm_table) - offsetof(struct atom_smc_dpm_info_v4_10, GfxMaxCurrent)); + smu_memcpy_trailing(smc_pptable, GfxMaxCurrent, reserved, + smc_dpm_table, GfxMaxCurrent); return 0; } -- 2.30.2

2 1

[PATCH v2 0/4] Various fixes to pass libdrm hotunplug tests
by Andrey Grodzovsky 27 Aug '21

27 Aug '21

Bunch of fixes to enable passing hotplug tests i previosly added here[1] with latest code. Once accepted I will enable the tests on libdrm side. [1] - https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/172 v2: Dropping VCE patch since relevant function already fixed in latest code. Moving IOMMU hnadling to TTM layer. Andrey Grodzovsky (4): drm/ttm: Create pinned list drm/ttm: Clear all DMA mappings on demand drm/amdgpu: drm/amdgpu: Handle IOMMU enabled case drm/amdgpu: Add a UAPI flag for hot plug/unplug drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- drivers/gpu/drm/ttm/ttm_bo.c | 30 +++++++++++++-- drivers/gpu/drm/ttm/ttm_device.c | 45 ++++++++++++++++++++++ drivers/gpu/drm/ttm/ttm_resource.c | 1 + include/drm/ttm/ttm_device.h | 1 + include/drm/ttm/ttm_resource.h | 1 + 7 files changed, 78 insertions(+), 5 deletions(-) -- 2.25.1

2 7

[PATCH v6 00/11] use DYNAMIC_DEBUG to implement DRM.debug
by Jim Cromie 27 Aug '21

27 Aug '21

This patchset does 3 main things. Adds DEFINE_DYNAMIC_DEBUG_CATEGORIES to define bitmap => category control of pr_debugs, and to create their sysfs entries. Uses it in amdgpu, i915 to control existing pr_debugs according to their ad-hoc categorizations. Plugs dyndbg into drm-debug framework, in a configurable manner. v6: cleans up per v5 feedback, and adds RFC stuff: - test_dynamic_debug.ko: uses tracer facility added in v5:8/9 - prototype print-once & rate-limiting Hopefully adding RFC stuff doesnt distract too much. Jim Cromie (11): moduleparam: add data member to struct kernel_param dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes i915/gvt: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to create "gvt:core:" etc categories amdgpu: use DEFINE_DYNAMIC_DEBUG_CATEGORIES to control categorized pr_debugs drm_print: add choice to use dynamic debug in drm-debug drm_print: instrument drm_debug_enabled amdgpu_ucode: reduce number of pr_debug calls nouveau: fold multiple DRM_DEBUG_DRIVERs together dyndbg: RFC add debug-trace callback, selftest with it. RFC dyndbg: RFC add print-once and print-ratelimited features. RFC. drivers/gpu/drm/Kconfig | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 293 ++++++++------- .../gpu/drm/amd/display/dc/core/dc_debug.c | 44 ++- drivers/gpu/drm/drm_print.c | 49 ++- drivers/gpu/drm/i915/gvt/Makefile | 4 + drivers/gpu/drm/i915/gvt/debug.h | 18 +- drivers/gpu/drm/i915/i915_params.c | 35 ++ drivers/gpu/drm/nouveau/nouveau_drm.c | 36 +- include/drm/drm_print.h | 148 ++++++-- include/linux/dynamic_debug.h | 81 ++++- include/linux/moduleparam.h | 11 +- lib/Kconfig.debug | 11 + lib/Makefile | 1 + lib/dynamic_debug.c | 336 ++++++++++++++++-- lib/test_dynamic_debug.c | 279 +++++++++++++++ 15 files changed, 1117 insertions(+), 242 deletions(-) create mode 100644 lib/test_dynamic_debug.c -- 2.31.1

4 17

TTM tt size larger than buffer object?
by Thomas Hellström 27 Aug '21

27 Aug '21

Hi, Christian. We have a use-case with i915 where the data representation of a buffer object is larger in system memory than in LMEM/VRAM. Hence we'd like to create a ttm_tt that is larger than the buffer object itself. Quickly auditing the TTM code it looks like that should be pretty safe, as ttm->num_pages is not really much accessed outside the tt code and the pool code where we're doing the right thing. The additional data will really only be accessed by the blitter so when cpu-mapping, mapping just the original buffer object size is correct. However with swapping the additional data needs to be swapped out and the code is doing that correctly as well. Do you think this is an acceptable solution? /Thomas

2 1

[v2 0/2] Add driver for BOE tv110c9m-ll3 panel
by yangcong 27 Aug '21

27 Aug '21

Documentation/devicetree/bindings/display/panel/boe,tv110c9m-ll3.yaml: Compared with v1, add a space in the required list. yangcong (2): drm/panel: support for BOE tv1110c9m-ll3 wuxga dsi video mode panel dt-bindngs: display: panel: Add BOE tv110c9m-ll3 panel bindings .../display/panel/boe,tv110c9m-ll3.yaml | 83 ++ drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-boe-tv110c9m.c | 1303 +++++++++++++++++ 4 files changed, 1397 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv110c9m-ll3.yaml create mode 100644 drivers/gpu/drm/panel/panel-boe-tv110c9m.c -- 2.25.1

4 7

[PATCH] MAINTAINERS: Add dri-devel for component.[hc]
by Daniel Vetter 27 Aug '21

27 Aug '21

dri-devel is the main user, and somehow there's been the assumption that component stuff is unmaintained. References: https://lore.kernel.org/dri-devel/CAAEAJfDWOzCJxZFNtxeT7Cvr2pWbYrfz-YnA81sV… Cc: Ezequiel Garcia <ezequiel(a)vanguardiasur.com.ar> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael(a)kernel.org> Signed-off-by: Daniel Vetter <daniel.vetter(a)intel.com> --- MAINTAINERS | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ac58d0032abd..7cdc19815ec4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5707,6 +5707,11 @@ F: Documentation/admin-guide/blockdev/ F: drivers/block/drbd/ F: lib/lru_cache.c +DRIVER COMPONENT FRAMEWORK +L: dri-devel(a)lists.freedesktop.org +F: drivers/base/component.c +F: include/linux/component.h + DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS M: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> R: "Rafael J. Wysocki" <rafael(a)kernel.org> -- 2.32.0

4 4

← Newer
1
...
25
26
27
28
29
30
31
...
77
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel August 2021