dri-devel January 2022

dri-devel@lists.freedesktop.org

373 participants
842 discussions

Enforce dma_fence container rules
by Christian König 21 Jan '22

21 Jan '22

Hi Daniel, second version of this set. I've kept the fence ops exported for now since there are indeed valid uses in the drm_syncobj implementation which needs a more wider rework. But quite a bunch of cases in i915, one in amdgpu and another one in vmwgfx are cleaned up at the end of this series now. Please review and comment, Christian.

3 14

linux-next: build warning after merge of the drm-misc tree
by Stephen Rothwell 21 Jan '22

21 Jan '22

Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms-helpers:451: /home/sfr/next/next/drivers/gpu/drm/drm_privacy_screen.c:270: WARNING: Inline emphasis start-string without end-string. Introduced by commit 8a12b170558a ("drm/privacy-screen: Add notifier support (v2)") -- Cheers, Stephen Rothwell

2 2

[GIT PULL] fbdev updates & fixes for v5.17-rc1
by Helge Deller 21 Jan '22

21 Jan '22

The following changes since commit 0c947b893d69231a9add855939da7c66237ab44f: Merge tag '5.17-rc-part1-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6 (2022-01-17 09:53:21 +0200) are available in the Git repository at: http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git tags/fbdev-5.17-2 for you to fetch changes up to 842086bc7262a36f002e0361f9dc351556cae3f3: video: fbdev: controlfb: Fix COMPILE_TEST build (2022-01-17 22:39:37 +0100) ---------------------------------------------------------------- fbdev updates for v5.17-rc1 A first bunch of updates and fixes for the following fbdev & backlight drivers: ocfb, aty128fb, mb862xx, omapfb, qcom-wled, dt-bindings, hyperv_fb, lm3630a_bl, omap2, controlfb, matroxfb Nothing really important, mostly cleanups, const conversions, added null pointer/boundary checks and build fixes. Signed-off-by: Helge Deller <deller(a)gmx.de> ---------------------------------------------------------------- Chunyang Zhong (1): video: ocfb: add const to of_device_id Colin Ian King (2): fbdev: aty128fb: make some arrays static const video: fbdev: mb862xx: remove redundant assignment to pointer ptr Greg Kroah-Hartman (1): omapfb: use default_groups in kobj_type Jiasheng Jiang (1): video: fbdev: Check for null res pointer Luca Weiss (2): backlight: qcom-wled: Add PM6150L compatible dt-bindings: simple-framebuffer: allow standalone compatible Michael Kelley (1): video: hyperv_fb: Fix validation of screen resolution Minghao Chi (1): drivers/video: remove redundant res variable Xu Wang (2): backlight: lm3630a_bl: Remove redundant 'flush_workqueue()' calls fbdev: omap2: omapfb: Remove redundant 'flush_workqueue()' calls Yang Guang (1): video: fbdev: use swap() to make code cleaner YueHaibing (1): video: fbdev: controlfb: Fix COMPILE_TEST build Z. Liu (1): matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen .../devicetree/bindings/display/simple-framebuffer.yaml | 12 +++++++----- drivers/video/backlight/lm3630a_bl.c | 1 - drivers/video/backlight/qcom-wled.c | 1 + drivers/video/fbdev/aty/aty128fb.c | 10 ++++++---- drivers/video/fbdev/aty/mach64_ct.c | 4 +--- drivers/video/fbdev/controlfb.c | 2 ++ drivers/video/fbdev/hyperv_fb.c | 16 +++------------- drivers/video/fbdev/imxfb.c | 2 ++ drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 +- drivers/video/fbdev/ocfb.c | 2 +- drivers/video/fbdev/omap2/omapfb/dss/display-sysfs.c | 3 ++- drivers/video/fbdev/omap2/omapfb/dss/manager-sysfs.c | 3 ++- drivers/video/fbdev/omap2/omapfb/dss/overlay-sysfs.c | 3 ++- drivers/video/fbdev/omap2/omapfb/omapfb-main.c | 1 - drivers/video/fbdev/sis/sis_main.c | 2 +- 16 files changed, 32 insertions(+), 34 deletions(-)

4 7

[PATCH] drm: Update docs after moving DisplayPort helpers around
by Thomas Zimmermann 21 Jan '22

21 Jan '22

DRM's DisplayPort helpers moved into the subdirectory dp/. Change the documentation accordingly. Signed-off-by: Thomas Zimmermann <tzimmermann(a)suse.de> Fixes: adb9d5a2cc77 ("drm/dp: Move DisplayPort helpers into separate helper module") Reported-by: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Thomas Zimmermann <tzimmermann(a)suse.de> Cc: Lyude Paul <lyude(a)redhat.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com> Cc: Maxime Ripard <mripard(a)kernel.org> Cc: dri-devel(a)lists.freedesktop.org --- Documentation/gpu/drm-kms-helpers.rst | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms-helpers.rst index 5bb55ec1b9b5..c3ce91eecbc1 100644 --- a/Documentation/gpu/drm-kms-helpers.rst +++ b/Documentation/gpu/drm-kms-helpers.rst @@ -232,34 +232,34 @@ HDCP Helper Functions Reference Display Port Helper Functions Reference ======================================= -.. kernel-doc:: drivers/gpu/drm/drm_dp_helper.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp.c :doc: dp helpers -.. kernel-doc:: include/drm/drm_dp_helper.h +.. kernel-doc:: include/drm/dp/drm_dp_helper.h :internal: -.. kernel-doc:: drivers/gpu/drm/drm_dp_helper.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp.c :export: Display Port CEC Helper Functions Reference =========================================== -.. kernel-doc:: drivers/gpu/drm/drm_dp_cec.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_cec.c :doc: dp cec helpers -.. kernel-doc:: drivers/gpu/drm/drm_dp_cec.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_cec.c :export: Display Port Dual Mode Adaptor Helper Functions Reference ========================================================= -.. kernel-doc:: drivers/gpu/drm/drm_dp_dual_mode_helper.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_dual_mode_helper.c :doc: dp dual mode helpers -.. kernel-doc:: include/drm/drm_dp_dual_mode_helper.h +.. kernel-doc:: include/drm/dp/drm_dp_dual_mode_helper.h :internal: -.. kernel-doc:: drivers/gpu/drm/drm_dp_dual_mode_helper.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_dual_mode_helper.c :export: Display Port MST Helpers @@ -268,19 +268,19 @@ Display Port MST Helpers Overview -------- -.. kernel-doc:: drivers/gpu/drm/drm_dp_mst_topology.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_mst_topology.c :doc: dp mst helper -.. kernel-doc:: drivers/gpu/drm/drm_dp_mst_topology.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_mst_topology.c :doc: Branch device and port refcounting Functions Reference ------------------- -.. kernel-doc:: include/drm/drm_dp_mst_helper.h +.. kernel-doc:: include/drm/dp/drm_dp_mst_helper.h :internal: -.. kernel-doc:: drivers/gpu/drm/drm_dp_mst_topology.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_mst_topology.c :export: Topology Lifetime Internals @@ -289,7 +289,7 @@ Topology Lifetime Internals These functions aren't exported to drivers, but are documented here to help make the MST topology helpers easier to understand -.. kernel-doc:: drivers/gpu/drm/drm_dp_mst_topology.c +.. kernel-doc:: drivers/gpu/drm/dp/drm_dp_mst_topology.c :functions: drm_dp_mst_topology_try_get_mstb drm_dp_mst_topology_get_mstb drm_dp_mst_topology_put_mstb drm_dp_mst_topology_try_get_port drm_dp_mst_topology_get_port -- 2.34.1

3 2

[PATCH] drm/vmwgfx: Stop requesting the pci regions
by Zack Rusin 21 Jan '22

21 Jan '22

From: Zack Rusin <zackr(a)vmware.com> When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove_conflicting*_framebuffers only removes the simplefb but not the regions held by sysfb. Like the other drm drivers we need to stop requesting all the pci regions to let the driver load with platform code enabled. This allows vmwgfx to load correctly on systems with sysfb_simple enabled. Signed-off-by: Zack Rusin <zackr(a)vmware.com> Fixes: 523375c943e5 ("drm/vmwgfx: Port vmwgfx to arm64") Cc: dri-devel(a)lists.freedesktop.org Cc: <stable(a)vger.kernel.org> Reviewed-by: Martin Krastev <krastevm(a)vmware.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index fe36efdb7ff5..27feb19f3324 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -724,10 +724,6 @@ static int vmw_setup_pci_resources(struct vmw_private *dev, pci_set_master(pdev); - ret = pci_request_regions(pdev, "vmwgfx probe"); - if (ret) - return ret; - dev->pci_id = pci_id; if (pci_id == VMWGFX_PCI_ID_SVGA3) { rmmio_start = pci_resource_start(pdev, 0); -- 2.32.0

4 17

PSA: drm-misc-next-fixes is closed
by Thomas Zimmermann 21 Jan '22

21 Jan '22

Hi, I'm just letting you know that drm-misc-next-fixes is closed. -rc1 will presumably be tagged this weekend and drm-next will be open for features and bugfixes until -rc6 comes out. The transition from/to drm-misc-fixes-next often results in patches that are applied to the wrong tree and get stuck there for a long time. Some rules of thumb for the next weeks: * if your patch fixes a bug in upstream, please put it into drm-misc-fixes, * anything else should go into drm-misc-next. The flow chart is at [1]. Best regards Thomas [1] https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#… -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev

1 0

[PULL] drm-misc-next-fixes
by Thomas Zimmermann 21 Jan '22

21 Jan '22

Hi Dave and Daniel, here's this week's PR for drm-misc-next-fixes. Probably the final PR before the next -rc1. Best regards Thomas drm-misc-next-fixes-2022-01-21: * vc4: Fix potential deadlock in DSI code * panel: Add orientation quirk for 1Netbook OneXPlayer The following changes since commit 5d474cc501b90b82c182b5d00439eb6790a82e21: drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy (2022-01-14 14:43:02 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-misc tags/drm-misc-next-fixes-2022-01-21 for you to fetch changes up to d3cbc6e323c9299d10c8d2e4127c77c7d05d07b1: drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer (2022-01-19 16:31:29 +0100) ---------------------------------------------------------------- * vc4: Fix potential deadlock in DSI code * panel: Add orientation quirk for 1Netbook OneXPlayer ---------------------------------------------------------------- Padmanabha Srinivasaiah (1): drm/vc4: Fix deadlock on DSI device attach error Raymond Jay Golo (1): drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++ drivers/gpu/drm/vc4/vc4_dsi.c | 14 ++++---------- 2 files changed, 16 insertions(+), 10 deletions(-) -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer

1 0

[PATCH] drm/i915: Add needs_compact_pt flag
by Ramalingam C 21 Jan '22

21 Jan '22

Add a new platform flag, needs_compact_pt, to mark the requirement of compact pt layout support for the ppGTT when using 64K GTT pages. With this flag has_64k_pages will only indicate requirement of 64K GTT page sizes or larger for device local memory access. Suggested-by: Matthew Auld <matthew.auld(a)intel.com> Signed-off-by: Ramalingam C <ramalingam.c(a)intel.com> cc: Robert Beckett <bob.beckett(a)collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 10 +++++++--- drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 890f1f6fbc49..23f4713005bb 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -1512,12 +1512,16 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, /* * Set this flag, when platform requires 64K GTT page sizes or larger for - * device local memory access. Also this flag implies that we require or - * at least support the compact PT layout for the ppGTT when using the 64K - * GTT pages. + * device local memory access. */ #define HAS_64K_PAGES(dev_priv) (INTEL_INFO(dev_priv)->has_64k_pages) +/* Set this flag when platform doesn't allow both 64k pages and 4k pages in + * the same PT. this flag means we need to support compact PT layout for the + * ppGTT when using the 64K GTT pages. + */ +#define NEEDS_COMPACT_PT(dev_priv) (INTEL_INFO(dev_priv)->needs_compact_pt) + #define HAS_IPC(dev_priv) (INTEL_INFO(dev_priv)->display.has_ipc) #define HAS_REGION(i915, i) (INTEL_INFO(i915)->memory_regions & (i)) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 8261b6455747..3e7555ce6894 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1028,6 +1028,7 @@ static const struct intel_device_info xehpsdv_info = { PLATFORM(INTEL_XEHPSDV), .display = { }, .has_64k_pages = 1, + .needs_compact_pt = 1, .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VECS1) | BIT(VECS2) | BIT(VECS3) | @@ -1046,6 +1047,7 @@ static const struct intel_device_info dg2_info = { .media.rel = 55, PLATFORM(INTEL_DG2), .has_64k_pages = 1, + .needs_compact_pt = 1, .platform_engine_mask = BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VECS1) | diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h index 3699b1c539ea..8ff676f49471 100644 --- a/drivers/gpu/drm/i915/intel_device_info.h +++ b/drivers/gpu/drm/i915/intel_device_info.h @@ -130,6 +130,7 @@ enum intel_ppgtt_type { /* Keep has_* in alphabetical order */ \ func(has_64bit_reloc); \ func(has_64k_pages); \ + func(needs_compact_pt; \ func(gpu_reset_clobbers_display); \ func(has_reset_engine); \ func(has_global_mocs); \ -- 2.20.1

3 4

[git pull] drm fixes for 5.17-rc1
by Dave Airlie 21 Jan '22

21 Jan '22

Hi Linus, Thanks to Daniel for taking care of things while I was out, just a set of merge window fixes that came in this week, two i915 display fixes and a bunch of misc amdgpu, along with a radeon regression fix. Regards, Dave. drm-next-2022-01-21: drm fixes for 5.17-rc1 amdgpu: - SR-IOV fix - VCN harvest fix - Suspend/resume fixes - Tahiti fix - Enable GPU recovery on yellow carp radeon: - Fix error handling regression in radeon_driver_open_kms i915: - Update EHL display voltage swing table - Fix programming the ADL-P display TC voltage swing The following changes since commit 4efdddbce7c1329f00c458e85dcaf105aebdc0ed: Merge tag 'amd-drm-next-5.17-2022-01-12' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-01-14 15:42:28 +0100) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-01-21 for you to fetch changes up to ccf34586758cf00c0934e48f6ef6d688f01d7b19: Merge tag 'amd-drm-fixes-5.17-2022-01-19' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2022-01-21 08:37:56 +1000) ---------------------------------------------------------------- drm fixes for 5.17-rc1 amdgpu: - SR-IOV fix - VCN harvest fix - Suspend/resume fixes - Tahiti fix - Enable GPU recovery on yellow carp radeon: - Fix error handling regression in radeon_driver_open_kms i915: - Update EHL display voltage swing table - Fix programming the ADL-P display TC voltage swing ---------------------------------------------------------------- Alex Deucher (3): drm/amdgpu: invert the logic in amdgpu_device_should_recover_gpu() drm/amdgpu: don't do resets on APUs which don't support it drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY CHANDAN VURDIGERE NATARAJ (1): drm/amdgpu: Enable recovery on yellow carp Christian König (1): drm/radeon: fix error handling in radeon_driver_open_kms Dave Airlie (2): Merge tag 'drm-intel-next-fixes-2022-01-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-next Merge tag 'amd-drm-fixes-5.17-2022-01-19' of https://gitlab.freedesktop.org/agd5f/linux into drm-next Guchun Chen (1): drm/amdgpu: apply vcn harvest quirk Jingwen Chen (1): drm/amd/amdgpu: fixing read wrong pf2vf data in SRIOV José Roberto de Souza (2): drm/i915/display/ehl: Update voltage swing table drm/i915/display/adlp: Implement new step in the TC voltage swing prog sequence Lukas Fink (1): drm/amdgpu: Fix rejecting Tahiti GPUs Mario Limonciello (1): drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 45 +++++++++------------- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 32 ++++++++++++--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 20 ++++------ drivers/gpu/drm/amd/amdgpu/cik.c | 4 ++ drivers/gpu/drm/amd/amdgpu/vi.c | 4 ++ .../amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 11 +----- .../drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 11 +----- .../amd/display/dc/irq/dcn20/irq_service_dcn20.c | 25 ------------ .../amd/display/dc/irq/dcn20/irq_service_dcn20.h | 2 - .../amd/display/dc/irq/dcn21/irq_service_dcn21.c | 25 ------------ .../amd/display/dc/irq/dcn21/irq_service_dcn21.h | 2 - drivers/gpu/drm/amd/display/dc/irq/irq_service.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/irq_service.h | 4 -- drivers/gpu/drm/i915/display/intel_ddi.c | 22 +++++++++++ drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 10 ++--- drivers/gpu/drm/i915/i915_reg.h | 8 +++- drivers/gpu/drm/radeon/radeon_kms.c | 22 ++++++----- 18 files changed, 108 insertions(+), 146 deletions(-)

2 1

[PATCH] drm/i915/guc: Don't check CT descriptor status before CT write / read
by Matthew Brost 21 Jan '22

21 Jan '22

Don't check CT descriptor status, unless CONFIG_DRM_I915_DEBUG_GUC is set, before CT write / read as this could result in a read across the PCIe bus thus adding latency to every CT write / read. On well behavied systems this vaue should always read as zero. For some reason it doesn't the CT channel is broken and will eventually recover from a GT reset, albeit the GT reset will not be triggered immediately by seeing that descriptor status is non-zero. Signed-off-by: Matthew Brost <matthew.brost(a)intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index de89d40abd38d..18af99a802f64 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -379,8 +379,10 @@ static int ct_write(struct intel_guc_ct *ct, u32 *cmds = ctb->cmds; unsigned int i; +#ifdef CONFIG_DRM_I915_DEBUG_GUC if (unlikely(desc->status)) goto corrupted; +#endif GEM_BUG_ON(tail > size); @@ -815,8 +817,10 @@ static int ct_read(struct intel_guc_ct *ct, struct ct_incoming_msg **msg) if (unlikely(ctb->broken)) return -EPIPE; +#ifdef CONFIG_DRM_I915_DEBUG_GUC if (unlikely(desc->status)) goto corrupted; +#endif GEM_BUG_ON(head > size); -- 2.34.1

2 3

← Newer
1
...
37
38
39
40
41
42
43
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel January 2022