dri-devel June 2022

dri-devel@lists.freedesktop.org

332 participants
697 discussions

[PATCH 1/4] video: fbdev: offb: Include missing linux/platform_device.h
by Christophe Leroy 20 Jun '22

20 Jun '22

A lot of drivers were getting platform and of headers indirectly via headers like asm/pci.h or asm/prom.h Most of them were fixed during 5.19 cycle but a newissue was introduced by commit 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Include missing platform_device.h to allow cleaning asm/pci.h Cc: Thomas Zimmermann <tzimmermann(a)suse.de> Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers") Signed-off-by: Christophe Leroy <christophe.leroy(a)csgroup.eu> --- drivers/video/fbdev/offb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/fbdev/offb.c b/drivers/video/fbdev/offb.c index b1acb1ebebe9..91001990e351 100644 --- a/drivers/video/fbdev/offb.c +++ b/drivers/video/fbdev/offb.c @@ -26,6 +26,7 @@ #include <linux/init.h> #include <linux/ioport.h> #include <linux/pci.h> +#include <linux/platform_device.h> #include <asm/io.h> #ifdef CONFIG_PPC32 -- 2.35.3

2 4

[pull] drm/msm: drm-msm-fixes-2022-06-20 for v5.19-rc4
by Rob Clark 20 Jun '22

20 Jun '22

Hi Dave, Here are fixes for v5.19, summary below (and in tag msg) The following changes since commit 24df12013853ac59c52cc726e9cbe51e38d09eda: MAINTAINERS: Add Dmitry as MSM DRM driver co-maintainer (2022-05-07 12:02:29 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tags/drm-msm-fixes-2022-06-20 for you to fetch changes up to a6e2af64a79afa7f1b29375b5231e840a84bb845: drm/msm/dp: force link training for display resolution change (2022-06-18 09:14:06 -0700) ---------------------------------------------------------------- Fixes for v5.19-rc4 - Workaround for parade DSI bridge power sequencing - Fix for multi-planar YUV format offsets - Limiting WB modes to max sspp linewidth - Fixing the supported rotations to add 180 back for IGT - Fix to handle pm_runtime_get_sync() errors to avoid unclocked access in the bind() path for dpu driver - Fix the irq_free() without request issue which was being hit frequently in CI. - Fix to add minimum ICC vote in the msm_mdss pm_resume path to address bootup splats - Fix to avoid dereferencing without checking in WB encoder - Fix to avoid crash during suspend in DP driver by ensuring interrupt mask bits are updated - Remove unused code from dpu_encoder_virt_atomic_check() - Fix to remove redundant init of dsc variable - Fix to ensure mmap offset is initialized to avoid memory corruption from unpin/evict - Fix double runpm disable in probe-defer path - VMA fenced-unpin fixes - Fix for WB max-width - Fix for rare dp resolution change issue ---------------------------------------------------------------- Abhinav Kumar (4): drm/msm/dpu: limit writeback modes according to max_linewidth drm/msm/dpu: add DRM_MODE_ROTATE_180 back to supported rotations drm/msm/dpu: handle pm_runtime_get_sync() errors in bind path drm/msm/dpu: limit wb modes based on max_mixer_width Dmitry Baryshkov (1): drm/msm: don't free the IRQ if it was not requested Douglas Anderson (2): drm/msm/dsi: don't powerup at modeset time for parade-ps8640 drm/msm/dpu: Move min BW request and full BW disable back to mdss Hangyu Hua (1): drm: msm: fix possible memory leak in mdp5_crtc_cursor_set() Haowen Bai (1): drm/msm/dpu: Fix pointer dereferenced before checking Jiapeng Chong (1): drm/msm/dpu: Remove unused code Jonathan Marek (1): drm/msm: use for_each_sgtable_sg to iterate over scatterlist Kuogee Hsieh (3): drm/msm/dp: Always clear mask bits to disable interrupts at dp_ctrl_reset_irq_ctrl() drm/msm/dp: check core_initialized before disable interrupts at dp_display_unbind() drm/msm/dp: force link training for display resolution change Maximilian Luz (1): drm/msm: Fix double pm_runtime_disable() call Miaoqian Lin (2): drm/msm/a6xx: Fix refcount leak in a6xx_gpu_init drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf Rob Clark (9): drm/msm: Fix fb plane offset calculation Merge tag 'msm-next-5.19-fixes' of https://gitlab.freedesktop.org/abhinavk/msm into msm-fixes-staging Merge tag 'msm-next-5.19-fixes-06-01' of https://gitlab.freedesktop.org/abhinavk/msm into msm-fixes-staging drm/msm: Ensure mmap offset is initialized drm/msm: Switch ordering of runpm put vs devfreq_idle drm/msm/gem: Separate object and vma unpin drm/msm/gem: Drop early returns in close/purge vma drm/msm: Drop update_fences() drm/msm: Don't overwrite hw fence in hw_init Vinod Koul (1): drm/msm/disp/dpu1: remove superfluous init drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 ++++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 -- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 12 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 13 ++++- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 +- drivers/gpu/drm/msm/dp/dp_ctrl.c | 42 ++++++++++++---- drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 +- drivers/gpu/drm/msm/dp/dp_display.c | 16 +++--- drivers/gpu/drm/msm/dsi/dsi_manager.c | 32 +++++++++++- drivers/gpu/drm/msm/msm_drv.c | 9 +++- drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/msm_fb.c | 2 +- drivers/gpu/drm/msm/msm_fence.c | 8 +-- drivers/gpu/drm/msm/msm_gem.c | 7 ++- drivers/gpu/drm/msm/msm_gem.h | 11 +++-- drivers/gpu/drm/msm/msm_gem_prime.c | 15 ++++++ drivers/gpu/drm/msm/msm_gem_submit.c | 18 ++++--- drivers/gpu/drm/msm/msm_gem_vma.c | 6 +-- drivers/gpu/drm/msm/msm_gpu.c | 27 ++-------- drivers/gpu/drm/msm/msm_iommu.c | 2 +- drivers/gpu/drm/msm/msm_kms.h | 1 + drivers/gpu/drm/msm/msm_mdss.c | 57 ++++++++++++++++++++++ drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +- 27 files changed, 222 insertions(+), 91 deletions(-)

1 0

[PATCH] drm/i915/display: Re-add check for low voltage sku for max dp source rate
by Jason A. Donenfeld 20 Jun '22

20 Jun '22

This reverts commit 73867c8709b569cdd7fda67f01dfe02c8d055521, which, on an i7-11850H iGPU with a Thinkpad X1 Extreme Gen 4, attached to a LG LP160UQ1-SPB1 embedded panel, causes wild flickering glitching technicolor pyrotechnics on resumption from suspend. The display shows strobing colors in an utter disaster explosion of pantone, as though bombs were dropped on the leprechauns at the base of the rainbow. Rebooting the machine fixes the issue, presumably because the display is initialized by firmware rather than by i915. Otherwise, the GPU appears to work fine. Bisection traced it back to this commit, which makes sense given the issues. Fixes: 73867c8709b5 ("drm/i915/display: Remove check for low voltage sku for max dp source rate") Cc: Ankit Nautiyal <ankit.k.nautiyal(a)intel.com> Cc: Imre Deak <imre.deak(a)intel.com> Cc: Jani Nikula <jani.nikula(a)intel.com> Cc: Uma Shankar <uma.shankar(a)intel.com> Cc: Animesh Manna <animesh.manna(a)intel.com> Cc: Jani Saarinen <jani.saarinen(a)intel.com> Signed-off-by: Jason A. Donenfeld <Jason(a)zx2c4.com> --- drivers/gpu/drm/i915/display/intel_dp.c | 32 ++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index e4a79c11fd25..ff67899522cf 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -388,13 +388,23 @@ static int dg2_max_source_rate(struct intel_dp *intel_dp) return intel_dp_is_edp(intel_dp) ? 810000 : 1350000; } +static bool is_low_voltage_sku(struct drm_i915_private *i915, enum phy phy) +{ + u32 voltage; + + voltage = intel_de_read(i915, ICL_PORT_COMP_DW3(phy)) & VOLTAGE_INFO_MASK; + + return voltage == VOLTAGE_INFO_0_85V; +} + static int icl_max_source_rate(struct intel_dp *intel_dp) { struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev); enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port); - if (intel_phy_is_combo(dev_priv, phy) && !intel_dp_is_edp(intel_dp)) + if (intel_phy_is_combo(dev_priv, phy) && + (is_low_voltage_sku(dev_priv, phy) || !intel_dp_is_edp(intel_dp))) return 540000; return 810000; @@ -402,7 +412,23 @@ static int icl_max_source_rate(struct intel_dp *intel_dp) static int ehl_max_source_rate(struct intel_dp *intel_dp) { - if (intel_dp_is_edp(intel_dp)) + struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); + struct drm_i915_private *dev_priv = to_i915(dig_port->base.base.dev); + enum phy phy = intel_port_to_phy(dev_priv, dig_port->base.port); + + if (intel_dp_is_edp(intel_dp) || is_low_voltage_sku(dev_priv, phy)) + return 540000; + + return 810000; +} + +static int dg1_max_source_rate(struct intel_dp *intel_dp) +{ + struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp); + struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev); + enum phy phy = intel_port_to_phy(i915, dig_port->base.port); + + if (intel_phy_is_combo(i915, phy) && is_low_voltage_sku(i915, phy)) return 540000; return 810000; @@ -445,7 +471,7 @@ intel_dp_set_source_rates(struct intel_dp *intel_dp) max_rate = dg2_max_source_rate(intel_dp); else if (IS_ALDERLAKE_P(dev_priv) || IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv)) - max_rate = 810000; + max_rate = dg1_max_source_rate(intel_dp); else if (IS_JSL_EHL(dev_priv)) max_rate = ehl_max_source_rate(intel_dp); else -- 2.35.1

2 6

[PATCH v2] drm/i915: Fix vm use-after-free in vma destruction
by Thomas Hellström 20 Jun '22

20 Jun '22

In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex); __i915_vm_release(); release_references(); And in release_reference() we dereference vma->vm to get to the vm gt pointer, leading to a use-after free. However, __i915_vm_release() grabs the vm->mutex so the vm won't be destroyed before vma->vm->mutex is released, so extract the gt pointer under the vm->mutex to avoid the vma->vm dereference in release_references(). v2: Fix a typo in the commit message (Andi Shyti) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5944 Fixes: e1a7ab4fca ("drm/i915: Remove the vm open count") Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura(a)intel.com> Cc: Matthew Auld <matthew.auld(a)intel.com> Signed-off-by: Thomas Hellström <thomas.hellstrom(a)linux.intel.com> --- drivers/gpu/drm/i915/i915_vma.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 0bffb70b3c5f..04d12f278f57 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -1637,10 +1637,10 @@ static void force_unbind(struct i915_vma *vma) GEM_BUG_ON(drm_mm_node_allocated(&vma->node)); } -static void release_references(struct i915_vma *vma, bool vm_ddestroy) +static void release_references(struct i915_vma *vma, struct intel_gt *gt, + bool vm_ddestroy) { struct drm_i915_gem_object *obj = vma->obj; - struct intel_gt *gt = vma->vm->gt; GEM_BUG_ON(i915_vma_is_active(vma)); @@ -1695,11 +1695,12 @@ void i915_vma_destroy_locked(struct i915_vma *vma) force_unbind(vma); list_del_init(&vma->vm_link); - release_references(vma, false); + release_references(vma, vma->vm->gt, false); } void i915_vma_destroy(struct i915_vma *vma) { + struct intel_gt *gt; bool vm_ddestroy; mutex_lock(&vma->vm->mutex); @@ -1707,8 +1708,11 @@ void i915_vma_destroy(struct i915_vma *vma) list_del_init(&vma->vm_link); vm_ddestroy = vma->vm_ddestroy; vma->vm_ddestroy = false; + + /* vma->vm may be freed when releasing vma->vm->mutex. */ + gt = vma->vm->gt; mutex_unlock(&vma->vm->mutex); - release_references(vma, vm_ddestroy); + release_references(vma, gt, vm_ddestroy); } void i915_vma_parked(struct intel_gt *gt) -- 2.34.3

3 2

Re: [RFT][PATCH v1 5/6] vfio/ccw: Add kmap_local_page() for memcpy
by Jason Gunthorpe 20 Jun '22

20 Jun '22

On Sun, Jun 19, 2022 at 11:32:07PM -0700, Christoph Hellwig wrote: > > This helps because we now block io memory from ever getting into these > > call paths. I'm pretty sure this is a serious security bug, but would > > let the IBM folks remark as I don't know it all that well.. > > Prevent as in crash when trying to convert it to a page? That or when calling memcpy() on an IO memory PFN that the guest passed into the dma s/g list the ccw driver is processing. Jason

1 0

Re: FW: [PATCH 1/7] dt-bindings: display: mediatek: dpi: add power-domains property
by xinlei.lee 20 Jun '22

20 Jun '22

> -----Original Message----- > From: Linux-mediatek <linux-mediatek-bounces(a)lists.infradead.org> On > Behalf Of CK Hu > Sent: Friday, June 17, 2022 1:31 PM > To: Fabien Parent <fparent(a)baylibre.com>; matthias.bgg(a)gmail.com; > Jitao Shi (石记涛) <jitao.shi(a)mediatek.com>; > krzysztof.kozlowski+dt(a)linaro.org; robh+dt(a)kernel.org > Cc: chunkuang.hu(a)kernel.org; p.zabel(a)pengutronix.de; airlied(a)linux.ie > ; daniel(a)ffwll.ch; dri-devel(a)lists.freedesktop.org; > linux-mediatek(a)lists.infradead.org; devicetree(a)vger.kernel.org; > linux-kernel(a)vger.kernel.org; linux-arm-kernel(a)lists.infradead.org > Subject: Re: [PATCH 1/7] dt-bindings: display: mediatek: dpi: add > power-domains property > > Hi, Fabien: > > On Mon, 2022-05-30 at 22:14 +0200, Fabien Parent wrote: > > DPI is part of the display / multimedia block in MediaTek SoCs, > > and > > always have a power-domain (at least in the upstream device-trees). > > Add the power-domains property to the binding documentation. > > > > Signed-off-by: Fabien Parent <fparent(a)baylibre.com> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 6 > > ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > index 77ee1b923991..caf4c88708f4 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y > > am > > l > > @@ -57,6 +57,9 @@ properties: > > Output port node. This port should be connected to the > > input > > port of an > > attached HDMI or LVDS encoder chip. > > > > + power-domains: > > + maxItems: 1 > > + > > required: > > - compatible > > - reg > > @@ -64,6 +67,7 @@ required: > > - clocks > > - clock-names > > - port > > + - power-domains > > > > additionalProperties: false > > > > @@ -71,11 +75,13 @@ examples: > > - | > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > #include <dt-bindings/clock/mt8173-clk.h> > > + #include <dt-bindings/power/mt8183-power.h> > > Why do you include mt8183 power header file for mt8173 dpi node? > > Regards, > CK > > > > > dpi0: dpi@1401d000 { > > compatible = "mediatek,mt8173-dpi"; > > reg = <0x1401d000 0x1000>; > > interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > > + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; > > clocks = <&mmsys CLK_MM_DPI_PIXEL>, > > <&mmsys CLK_MM_DPI_ENGINE>, > > <&apmixedsys CLK_APMIXED_TVDPLL>; > > Hi fparent: I think CK's suggestion, probably because you included the wrong header file for power. Because I did not find the definition of MT8173_POWER_DOMAIN_MM in the path of dt-bindings/power/mt8183-power.h, it was defined in dt- bindings/power/mt8173-power.h. Please discuss if you have different opinions. Best Regards! xinlei

1 0

[PATCH 0/2] video: fbdev: Convert from PCI to generic power management
by Bjorn Helgaas 20 Jun '22

20 Jun '22

From: Bjorn Helgaas <bhelgaas(a)google.com> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is deprecated. If drivers implement power management, they should use the generic power management framework, not the PCI-specific hooks. No fbdev drivers actually implement PCI power management, but there are a cirrusfb has some commented-out references to it and skeletonfb has examples of it. Remove these. Bjorn Helgaas (2): video: fbdev: cirrusfb: Remove useless reference to PCI power management video: fbdev: skeletonfb: Convert to generic power management drivers/video/fbdev/cirrusfb.c | 6 ------ drivers/video/fbdev/skeletonfb.c | 13 +++++++------ 2 files changed, 7 insertions(+), 12 deletions(-) -- 2.25.1

3 5

[PATCH] fbdev: Fix syntax errors in comments
by Xiang wangx 20 Jun '22

20 Jun '22

Delete the redundant word 'its'. Signed-off-by: Xiang wangx <wangxiang(a)cdjrlc.com> --- drivers/video/fbdev/skeletonfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/skeletonfb.c b/drivers/video/fbdev/skeletonfb.c index bcacfb6934fa..3d4d78362ede 100644 --- a/drivers/video/fbdev/skeletonfb.c +++ b/drivers/video/fbdev/skeletonfb.c @@ -96,7 +96,7 @@ static const struct fb_fix_screeninfo xxxfb_fix = { /* * Modern graphical hardware not only supports pipelines but some - * also support multiple monitors where each display can have its + * also support multiple monitors where each display can have * its own unique data. In this case each display could be * represented by a separate framebuffer device thus a separate * struct fb_info. Now the struct xxx_par represents the graphics -- 2.36.1

2 1

[PATCH] drm/i915: Fix vm use-after-free in vma destruction
by Thomas Hellström 20 Jun '22

20 Jun '22

In vma destruction, the following race may occur: Thread 1: Thread 2: i915_vma_destroy(); ... list_del_init(vma->vm_link); ... mutex_unlock(vma->vm->mutex); __i915_vm_release(); release_references(); And in release_reference() we dereference vma->vm to get to the vm gt pointer, leadin go a use-after free. However, __i915_vm_release() grabs the vm->mutex so the vm won't be destroyed before vma->vm->mutex is released, so extract the gt pointer under the vm->mutex to avoid the vma->vm dereference in release_references(). Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5944 Fixes: e1a7ab4fca ("drm/i915: Remove the vm open count") Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura(a)intel.com> Cc: Matthew Auld <matthew.auld(a)intel.com> Signed-off-by: Thomas Hellström <thomas.hellstrom(a)linux.intel.com> --- drivers/gpu/drm/i915/i915_vma.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index 4f6db539571a..5d6850a91a69 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -1636,10 +1636,10 @@ static void force_unbind(struct i915_vma *vma) GEM_BUG_ON(drm_mm_node_allocated(&vma->node)); } -static void release_references(struct i915_vma *vma, bool vm_ddestroy) +static void release_references(struct i915_vma *vma, struct intel_gt *gt, + bool vm_ddestroy) { struct drm_i915_gem_object *obj = vma->obj; - struct intel_gt *gt = vma->vm->gt; GEM_BUG_ON(i915_vma_is_active(vma)); @@ -1694,11 +1694,12 @@ void i915_vma_destroy_locked(struct i915_vma *vma) force_unbind(vma); list_del_init(&vma->vm_link); - release_references(vma, false); + release_references(vma, vma->vm->gt, false); } void i915_vma_destroy(struct i915_vma *vma) { + struct intel_gt *gt; bool vm_ddestroy; mutex_lock(&vma->vm->mutex); @@ -1706,8 +1707,11 @@ void i915_vma_destroy(struct i915_vma *vma) list_del_init(&vma->vm_link); vm_ddestroy = vma->vm_ddestroy; vma->vm_ddestroy = false; + + /* vma->vm may be freed when releasing vma->vm->mutex. */ + gt = vma->vm->gt; mutex_unlock(&vma->vm->mutex); - release_references(vma, vm_ddestroy); + release_references(vma, gt, vm_ddestroy); } void i915_vma_parked(struct intel_gt *gt) -- 2.34.1

2 2

[PATCH v2] drm/i915/gem: add missing else
by zys.zljxml＠gmail.com 20 Jun '22

20 Jun '22

From: katrinzhou <katrinzhou(a)tencent.com> Add missing else in set_proto_ctx_param() to fix coverity issue. Addresses-Coverity: ("Unused value") Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)") Suggested-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Signed-off-by: katrinzhou <katrinzhou(a)tencent.com> --- Update from v1: Fixed the code logic as suggested by Tvrtko Ursulin. drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index ab4c5ab28e4d..1099a383e55a 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -933,7 +933,8 @@ static int set_proto_ctx_param(struct drm_i915_file_private *fpriv, case I915_CONTEXT_PARAM_PERSISTENCE: if (args->size) ret = -EINVAL; - ret = proto_context_set_persistence(fpriv->dev_priv, pc, + else + ret = proto_context_set_persistence(fpriv->dev_priv, pc, args->value); break; -- 2.27.0

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
70
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2022