dri-devel June 2022

dri-devel@lists.freedesktop.org

332 participants
697 discussions

Re: Re: [PATCH] drm: bridge: adv7511: Add check for mipi_dsi_driver_register
by Jiasheng Jiang 02 Jun '22

02 Jun '22

On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote: >> Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue. >> Therefore, it might not be necessary to add another mipi_dsi_driver_unregister(). > > The issue is that adv7511_exit() is not called if adv7511_init() fails. Sorry, I can not find the caller of adv7511_init(). Please give me more detail. Thanks, Jiang

2 1

[PATCH] drm/gma500: Clean up some inconsistent indenting
by Jiapeng Chong 02 Jun '22

02 Jun '22

Eliminate the follow smatch warning: drivers/gpu/drm/gma500/cdv_device.c:250 cdv_errata() warn: inconsistent indenting. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- drivers/gpu/drm/gma500/cdv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/cdv_device.c b/drivers/gpu/drm/gma500/cdv_device.c index dd32b484dd82..09684c42cbf6 100644 --- a/drivers/gpu/drm/gma500/cdv_device.c +++ b/drivers/gpu/drm/gma500/cdv_device.c @@ -247,7 +247,7 @@ static void cdv_errata(struct drm_device *dev) * Bonus Launch to work around the issue, by degrading * performance. */ - CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108); + CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108); } /** -- 2.20.1.7.g153144c

2 1

[PATCH] drm/i915/gvt: Fix kernel-doc
by Jiapeng Chong 02 Jun '22

02 Jun '22

Fix the following W=1 kernel warnings: drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype for inte_gvt_free_vgpu_resource(). Prototype was for intel_vgpu_free_resource() instead. drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: expecting prototype for intel_alloc_vgpu_resource(). Prototype was for intel_vgpu_alloc_resource() instead. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- drivers/gpu/drm/i915/gvt/aperture_gm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/aperture_gm.c b/drivers/gpu/drm/i915/gvt/aperture_gm.c index 557f3314291a..3b81a6d35a7b 100644 --- a/drivers/gpu/drm/i915/gvt/aperture_gm.c +++ b/drivers/gpu/drm/i915/gvt/aperture_gm.c @@ -298,7 +298,7 @@ static int alloc_resource(struct intel_vgpu *vgpu, } /** - * inte_gvt_free_vgpu_resource - free HW resource owned by a vGPU + * intel_vgpu_free_resource() - free HW resource owned by a vGPU * @vgpu: a vGPU * * This function is used to free the HW resource owned by a vGPU. @@ -328,7 +328,7 @@ void intel_vgpu_reset_resource(struct intel_vgpu *vgpu) } /** - * intel_alloc_vgpu_resource - allocate HW resource for a vGPU + * intel_vgpu_alloc_resource() - allocate HW resource for a vGPU * @vgpu: vGPU * @param: vGPU creation params * -- 2.20.1.7.g153144c

1 0

[PATCH] drm/i915/gt: Fix kernel-doc
by Jiapeng Chong 02 Jun '22

02 Jun '22

Fix the following W=1 kernel warnings: drivers/gpu/drm/i915/gt/intel_engine_cs.c:1117: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead. drivers/gpu/drm/i915/gt/intel_engine_cs.c:1194: warning: expecting prototype for intel_engines_cleanup_common(). Prototype was for intel_engine_cleanup_common() instead. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 14c6ddbbfde8..81cec920ab05 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1103,7 +1103,7 @@ create_kernel_context(struct intel_engine_cs *engine) } /** - * intel_engines_init_common - initialize cengine state which might require hw access + * engine_init_common() - initialize engine state which might require hw access * @engine: Engine to initialize. * * Initializes @engine@ structure members shared between legacy and execlists @@ -1184,7 +1184,7 @@ int intel_engines_init(struct intel_gt *gt) } /** - * intel_engines_cleanup_common - cleans up the engine state created by + * intel_engine_cleanup_common() - cleans up the engine state created by * the common initiailizers. * @engine: Engine to cleanup. * -- 2.20.1.7.g153144c

1 0

[PATCH 0/8] Cleanup use of ddc i2c buses
by Patrik Jakobsson 02 Jun '22

02 Jun '22

The various chips have slight differences in how they handle and store ddc i2c buses. This series tries to put the main i2c adapter for ddc into the drm_connector->ddc pointer. This makes it easier to unify the code for the different encoders in upcoming series. Oaktrail HDMI and PSB SDVO are not included. Patrik Jakobsson (8): drm/gma500: Use gma_ prefix for our i2c abstraction drm/gma500: Make gma_i2c_chan a subclass of i2c_adapter drm/gma500: Make cdv lvds use ddc adapter from drm_connector drm/gma500: Make cdv hdmi use ddc adapter from drm_connector drm/gma500: Make psb lvds use ddc adapter from drm_connector drm/gma500: Make cdv crt use ddc adapter from drm_connector drm/gma500: Make oaktrail lvds use ddc adapter from drm_connector drm/gma500: Read EDID from the correct i2c adapter drivers/gpu/drm/gma500/cdv_intel_crt.c | 47 ++++++----- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 98 +++++++++++----------- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 80 ++++++++---------- drivers/gpu/drm/gma500/intel_i2c.c | 36 ++++---- drivers/gpu/drm/gma500/oaktrail_lvds.c | 50 ++++++----- drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c | 36 ++++---- drivers/gpu/drm/gma500/psb_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_drv.h | 24 +++--- drivers/gpu/drm/gma500/psb_intel_lvds.c | 86 +++++++++---------- 9 files changed, 237 insertions(+), 222 deletions(-) -- 2.36.1

2 10

[PATCH] drm/tegra: Remove redundant NULL check before kfree
by cgel.zte＠gmail.com 02 Jun '22

02 Jun '22

From: Minghao Chi <chi.minghao(a)zte.com.cn> kfree on NULL pointer is a no-op. Reported-by: Zeal Robot <zealci(a)zte.com.cn> Signed-off-by: Minghao Chi <chi.minghao(a)zte.com.cn> --- drivers/gpu/drm/tegra/submit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c index 6d6dd8c35475..54ac31bc80f6 100644 --- a/drivers/gpu/drm/tegra/submit.c +++ b/drivers/gpu/drm/tegra/submit.c @@ -639,8 +639,7 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data, kfree(job_data->used_mappings); } - if (job_data) - kfree(job_data); + kfree(job_data); put_bo: gather_bo_put(&bo->base); unlock: -- 2.25.1

1 0

[RESEND PATCH] drm/mipi-dsi: Fix error handling in mipi_dsi_device_register_full
by Miaoqian Lin 02 Jun '22

02 Jun '22

In mipi_dsi_device_alloc(), it calls device_initialize(&dsi->dev); We need to use put_device() instead freeing directly. Fixes: 068a002 ("drm: Add MIPI DSI bus support") Signed-off-by: Miaoqian Lin <linmq006(a)gmail.com> --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index c40bde96cfdf..8cc8deca006f 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -228,7 +228,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, ret = mipi_dsi_device_add(dsi); if (ret) { drm_err(host, "failed to add DSI device %d\n", ret); - kfree(dsi); + put_device(&dsi->dev); return ERR_PTR(ret); } -- 2.25.1

2 1

[PATCH v2 0/3] MediaTek MT8195 display binding
by Rex-BC Chen 02 Jun '22

02 Jun '22

Add this series to present MediaTek display binding for MT8195. The reason I send this series is Jason and Nancy's binding patches are never received by devicetree mail server. Therefore, I help them to resend binding patches. Changes for v2: 1. This patch is based on linux next-20220506. 2. Jason's patches are accepted and I drop them. [1]: https://lore.kernel.org/all/20220504091440.2052-2-nancy.lin@mediatek.com/ Nancy.Lin (3): dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195 dt-bindings: reset: mt8195: add vdosys1 reset control bit dt-bindings: mediatek: add ethdr definition for mt8195 .../display/mediatek/mediatek,ethdr.yaml | 191 ++++++++++++++++++ .../display/mediatek/mediatek,mdp-rdma.yaml | 94 +++++++++ include/dt-bindings/reset/mt8195-resets.h | 45 +++++ 3 files changed, 330 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml -- 2.18.0

6 22

[PATCH 0/3] Introduce ClockworkPi CWD686 DRM panel driver
by Max Fierke 02 Jun '22

02 Jun '22

The ClockworkPi DevTerm (all models) uses a 6.86" IPS display of unknown provenance, which uses the Chipone ICNL9707 IC driver[1]. The display panel I have has two model numbers: TXW686001 and WTL068601G, but cannot find any manufacturer associated with either, so opting for the ClockworkPi model number. This driver is based on the GPL-licensed driver released by ClockworkPi[1], authored by Pinfan Zhu, with some additional cleanup, rotation support, and display sleep re-enabling done by me. [1] https://github.com/clockworkpi/DevTerm/blob/main/Schematics/ICNL9707_Datash… [2] https://github.com/clockworkpi/DevTerm/blob/main/Code/patch/armbian_build_a… Signed-off-by: Max Fierke <max(a)maxfierke.com> Max Fierke (3): dt-bindings: vendor-prefixes: Add prefix for ClockworkPi dt-bindings: display: Add bindings for ClockworkPi CWD686 drm: panel: Add driver for ClockworkPi cwd686 panel .../display/panel/clockworkpi,cwd686.yaml | 60 +++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/panel/Kconfig | 12 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-clockworkpi-cwd686.c | 458 ++++++++++++++++++ 5 files changed, 533 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml create mode 100644 drivers/gpu/drm/panel/panel-clockworkpi-cwd686.c -- 2.36.1

3 7

[PATCH v4] drm/v3d/v3d_drv: Fix PM disable depth imbalance
by Miaoqian Lin 02 Jun '22

02 Jun '22

The pm_runtime_enable will increase power disable depth. We need to call pm_runtime_disable() to balance it when needed use devm_pm_runtime_enable() and handle it automatically/ Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Miaoqian Lin <linmq006(a)gmail.com> --- Changes in v4: - use devm_pm_runtime_enable() Changes in v3: - call pm_runtime_disable() in v3d_platform_drm_remove - update commit message Changes in v2 - put pm_runtime_disable before dma_free_wc - rename dma_free to pm_disable v1: https://lore.kernel.org/r/20220105120442.14418-1-linmq006@gmail.com v2: https://lore.kernel.org/r/20220106124657.32737-1-linmq006@gmail.com v3: https://lore.kernel.org/all/20220601122050.1822-1-linmq006@gmail.com --- drivers/gpu/drm/v3d/v3d_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 1afcd54fbbd5..563ad4b9c2e8 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -282,7 +282,9 @@ static int v3d_platform_drm_probe(struct platform_device *pdev) pm_runtime_use_autosuspend(dev); pm_runtime_set_autosuspend_delay(dev, 50); - pm_runtime_enable(dev); + ret = devm_pm_runtime_enable(dev); + if (ret) + goto dma_free; ret = v3d_gem_init(drm); if (ret) -- 2.25.1

1 0

← Newer
1
...
63
64
65
66
67
68
69
70
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel June 2022