[Mesa-dev] [PATCH 06/12] glsl: Add lowering pass for ir_triop_vector_insert

Eric Anholt eric at anholt.net
Tue May 7 09:53:02 PDT 2013


Ian Romanick <idr at freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> This will eventually replace do_vec_index_to_cond_assign.  This lowering
> pass is called in all the places where do_vec_index_to_cond_assign or
> do_vec_index_to_swizzle is called.
>
> v2: Use WRITEMASK_* instead of integer literals.  Use a more concise
> method of generating broadcast_index.  Both suggested by Eric.

I still object to using a vec4 cmp_result.  It's awful for code
generation.  Just compare in the if statements.

IFs vs cond assigns I don't care about -- that's something the driver
should be deciding.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130507/d4f00e63/attachment.pgp>


More information about the mesa-dev mailing list