[Mesa-dev] [PATCH 06/12] glsl: Add lowering pass for ir_triop_vector_insert

[Eric Anholt]

Ian Romanick <idr at freedesktop.org> writes:

> On 05/07/2013 09:53 AM, Eric Anholt wrote:
>> Ian Romanick <idr at freedesktop.org> writes:
>>
>>> From: Ian Romanick <ian.d.romanick at intel.com>
>>>
>>> This will eventually replace do_vec_index_to_cond_assign.  This lowering
>>> pass is called in all the places where do_vec_index_to_cond_assign or
>>> do_vec_index_to_swizzle is called.
>>>
>>> v2: Use WRITEMASK_* instead of integer literals.  Use a more concise
>>> method of generating broadcast_index.  Both suggested by Eric.
>>
>> I still object to using a vec4 cmp_result.  It's awful for code
>> generation.  Just compare in the if statements.
>
> So you're telling me that it's unacceptable to continue generating the 
> same code that we currently generate?  ...for a case that happens is how 
> many real shaders?

I was just looking at the code in this patch, and saying that it's bad
for drivers, and there's extra complexity in it in order to be bad for
drivers like that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130507/ee2c1e34/attachment.pgp>