tinderbox information.

[John Dennis]

> Well, the log file it is checking is the tinderclient.log file,
> which will be the same even in different modules.  So I don't
> think it is tied to a given module, though it is depending on a
> "feature" of make.

The upper level has file handles for the log, it controls the log
file, this is not a feature of make. The log files can and should be per
process, this keeps a lot more flexibility.

I think something along these lines is much more robust and efficent, it
uses exactly the file handle tied to the build and it doesn't require an
external process to scan the log.

sub TestLogFile
{
  my $this = shift;

  if (defined($this->{LOG_IN})) {
    my $log_in = $this->{LOG_IN};
    while (<$log_in>) {
      return 1 if /SOME-ERROR-STRING-WRITTEN-AS-A-PERL-REGEX/;
      return 1 if /SOME-OTHER-ERROR-STRING-WRITTEN-AS-A-PERL-REGEX/;
    }
    return 0;
  } else {
    # Hmm... no log file?
    return 1;
  }
}
-- 
John Dennis <jdennis@redhat.com>