[Libreoffice] [REVIEW] Fixing layout breakage in pivot table dialog

Jan Holesovsky kendy at suse.cz
Thu Sep 1 02:59:54 PDT 2011


Hi Kohei,

On 2011-08-30 at 16:55 -0400, Kohei Yoshida wrote:

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=8bf60230255e0e8da66cafff578f148858cee4ca
> 
> cherry-picked to the 3.4 branch.  A patch for this commit is attached as
> well for convenience.
> 
> This fixes a slight layout problem in the main pivot table dialog, where
> the text "Drag the fields from the right into the desired position"
> appeared overlapping the row and data field areas on Windows XP.  This
> commit fixes it.  On platforms other than Windows XP there is no such
> issue.
> 
> Apparently our dialogs get vertically compressed on Windows XP (for
> whatever reason).  And because the size and position of the
> page/row/column/data field areas are absolute, this caused the layout
> breakage on XP.

The patch generally looks fine - I just wonder, why there is the
vertical compression, and why only on XP?  Isn't the root cause
something in vcl?

Regards,
Kendy



More information about the LibreOffice mailing list