Mesa (master): radeonsi: Add parentheses around '|' operands.
Vinson Lee
vlee at kemper.freedesktop.org
Tue Sep 10 17:44:29 UTC 2013
Module: Mesa
Branch: master
Commit: 49f2ba2cb07202b93955d15bc2bce2d4ae77bbf9
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=49f2ba2cb07202b93955d15bc2bce2d4ae77bbf9
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Sep 9 20:14:28 2013 -0700
radeonsi: Add parentheses around '|' operands.
Fixes GCC parentheses warning.
r600_texture.c: In function 'si_texture_create':
r600_texture.c:518:20: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
!(templ->bind & PIPE_BIND_CURSOR | PIPE_BIND_LINEAR)) {
^
Fixes "Wrong operator used" defect reported by Coverity.
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/gallium/drivers/radeonsi/r600_texture.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/r600_texture.c b/src/gallium/drivers/radeonsi/r600_texture.c
index ef4e865..e6e8e20 100644
--- a/src/gallium/drivers/radeonsi/r600_texture.c
+++ b/src/gallium/drivers/radeonsi/r600_texture.c
@@ -515,7 +515,7 @@ struct pipe_resource *si_texture_create(struct pipe_screen *screen,
int r;
if (!(templ->flags & R600_RESOURCE_FLAG_TRANSFER) &&
- !(templ->bind & PIPE_BIND_CURSOR | PIPE_BIND_LINEAR)) {
+ !(templ->bind & (PIPE_BIND_CURSOR | PIPE_BIND_LINEAR))) {
if (templ->flags & R600_RESOURCE_FLAG_FORCE_TILING ||
templ->nr_samples > 1) {
array_mode = V_009910_ARRAY_2D_TILED_THIN1;
More information about the mesa-commit
mailing list