Mesa (master): mesa: Ensure gl_sync_object is fully initialized.

Vinson Lee vlee at kemper.freedesktop.org
Tue Sep 10 17:54:37 UTC 2013


Module: Mesa
Branch: master
Commit: fd66a85f6bd974150e112c0f7275190c1f55bf8f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd66a85f6bd974150e112c0f7275190c1f55bf8f

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Sep  9 17:28:35 2013 -0700

mesa: Ensure gl_sync_object is fully initialized.

278372b47e4db8a022d57f60302eec74819e9341 added the uninitialized pointer
field gl_sync_object:Label. A free of this pointer, added in commit
6d8dd59cf53d2f47b817d79204a52bb3a46e8c77, resulted in a crash.

This patch fixes piglit ARB_sync regressions with swrast introduced by
6d8dd59cf53d2f47b817d79204a52bb3a46e8c77.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/mesa/main/syncobj.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/main/syncobj.c b/src/mesa/main/syncobj.c
index 92c7cb0..987d4f5 100644
--- a/src/mesa/main/syncobj.c
+++ b/src/mesa/main/syncobj.c
@@ -71,7 +71,7 @@
 static struct gl_sync_object *
 _mesa_new_sync_object(struct gl_context *ctx, GLenum type)
 {
-   struct gl_sync_object *s = MALLOC_STRUCT(gl_sync_object);
+   struct gl_sync_object *s = CALLOC_STRUCT(gl_sync_object);
    (void) ctx;
    (void) type;
 




More information about the mesa-commit mailing list