VRAM manager

[Felix Kuehling]

Thanks for the explanation (and the one on patch 1). The whole series is

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


On 16-10-11 05:34 AM, Christian König wrote:
> Hi Felix,
>
> the pfn (mem->start) is set by the address space manager to
> AMDGPU_BO_INVALID_OFFSET which is a very high number.
>
> So setting the lpfn to an explicit value for the validation will
> result in reallocation of the backing store because
> AMDGPU_BO_INVALID_OFFSET will always be larger than lpfn.
>
> Regards,
> Christian.
>
> Am 08.10.2016 um 00:11 schrieb Felix Kuehling:
>> Hi Christian,
>>
>> I'm back from vacation and finally caught up with my email and
>> code-review backlog.
>>
>> I added a comment on patch 1.
>>
>> I don't understand patch 2. I couldn't find where a non-0 lpfn would
>> trigger any reallocation. I think this would have to be somewhere in
>> ttm_bo_validate or ttm_bo_mem_compat. I also grepped for all uses of
>> lpfn in TTM and AMDGPU. Maybe I'm looking for the wrong thing in the
>> wrong place.
>>
>> Patches 3-6 look good to me (other than the copyright date pointed out
>> by David). Please add my Reviewed-by.
>>
>> Regards,
>>    Felix
>>
>>
>> On 16-09-27 05:49 AM, Christian König wrote:
>>> Hi guys,
>>>
>>> after fixing all those nasty little bugs this seems to be stable now.
>>>
>>> Anybody brave enough to give it an review?
>>>
>>> Cheers,
>>> Christian.
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>