[patch] ras fix patch set

[Zhang, Hawking]

Okay, Thanks for the clarifying. Yes, we will need the interrupt handler. So let’s just keep the set function as is.

Regards,
Hawking
From: Pan, Xinhui <Xinhui.Pan at amd.com>
Sent: 2019年3月1日 16:18
To: Zhang, Hawking <Hawking.Zhang at amd.com>; brahma_sw_dev <brahma_sw_dev at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: RE: [patch] ras fix patch set

#1 can’t drop it, Need install irq handler. irq_get will fail it ->set is empty.

#4,  move all codes in the {}… I did not notice it too….

From: Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Sent: 2019年3月1日 14:57
To: Pan, Xinhui <Xinhui.Pan at amd.com<mailto:Xinhui.Pan at amd.com>>; brahma_sw_dev <brahma_sw_dev at amd.com<mailto:brahma_sw_dev at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com<mailto:Alexander.Deucher at amd.com>>
Subject: RE: [patch] ras fix patch set

Patch #1

Can you just drop the whole function (sdma_v4_0_ecc_irq_funcs) ?

Patch #4

What the patch actually do seems doesn’t match with the description. I only see you adjust some code alignment in patch #4, anything I missed?

From: Pan, Xinhui <Xinhui.Pan at amd.com<mailto:Xinhui.Pan at amd.com>>
Sent: 2019年3月1日 14:06
To: brahma_sw_dev <brahma_sw_dev at amd.com<mailto:brahma_sw_dev at amd.com>>; amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
Cc: Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>; Deucher, Alexander <Alexander.Deucher at amd.com<mailto:Alexander.Deucher at amd.com>>
Subject: [patch] ras fix patch set

Hi,
This is to fix some issues reported recently.
1) no need to do sdma irq setting. Ras ta do it.
2) gpu reset is not stable on some boards, so make amdgpu_ras_reset_gpu  a empty function.
3) fix build warnings.
4) ta might be missing, in such case, hit null pointer.

xinhui pan (4):
  drm/amdgpu: do not set sdma ecc interrupt
  drm/amdgpu: skip gpu reset when ras error occured
  drm/amdgpu: fix compile warning
  drm/amdgpu: fix NULL pointer when ta is missing

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c |  2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c |  1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c |  5 +++--
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h |  3 +++
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c   |  2 +-
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c  | 12 ++++++------
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c  | 11 -----------
7 files changed, 14 insertions(+), 22 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20190301/894168dc/attachment-0001.html>