[Beignet] [PATCH] runtime: silent some error messages.

[Zhigang Gong]

use something like DEBUG_PRINT is better. Need to cleanup the whole library
to fix this type of things.

Thanks,
Zhigang Gong

On Tue, Nov 17, 2015 at 10:11 AM, Song, Ruiling <ruiling.song at intel.com>
wrote:

> Hi Zhigang,
>
> Directly remove the output message may be not proper.
> The output message is very useful for us to debug if some application run
> into these kind of issues.
> Although we return the error code to application. But it is still hard to
> know exactly what's wrong if application just receives a CL_OUT_OF_RESOURCE.
> Maybe we can add a simple DEBUG_PRINT() macro to print some message under
> debug mode.
> What do you think?
>
> Thanks!
> Ruiling
>
> > -----Original Message-----
> > From: Beignet [mailto:beignet-bounces at lists.freedesktop.org] On Behalf
> Of
> > Zhigang Gong
> > Sent: Friday, November 13, 2015 7:32 AM
> > To: beignet at lists.freedesktop.org
> > Cc: Gong, Zhigang <zhigang.gong at intel.com>
> > Subject: [Beignet] [PATCH] runtime: silent some error messages.
> >
> > We already set corresponding error code and return it to the caller.
> > Don't bother to print the error messages in beignet internal.
> >
> > Signed-off-by: Zhigang Gong <zhigang.gong at intel.com>
> > ---
> >  src/cl_command_queue_gen7.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/src/cl_command_queue_gen7.c
> > b/src/cl_command_queue_gen7.c
> > index f0ee20a..96b23fb 100644
> > --- a/src/cl_command_queue_gen7.c
> > +++ b/src/cl_command_queue_gen7.c
> > @@ -329,21 +329,18 @@
> > cl_command_queue_ND_range_gen7(cl_command_queue queue,
> >
> >    /* Compute the number of HW threads we need */
> >    if(UNLIKELY(err = cl_kernel_work_group_sz(ker, local_wk_sz, 3,
> > &local_sz) != CL_SUCCESS)) {
> > -    fprintf(stderr, "Beignet: Work group size exceed Kernel's work group
> > size.\n");
> >      return err;
> >    }
> >    kernel.thread_n = thread_n = (local_sz + simd_sz - 1) / simd_sz;
> >    kernel.curbe_sz = cst_sz;
> >
> >    if (scratch_sz > ker->program->ctx->device->scratch_mem_size) {
> > -    fprintf(stderr, "Beignet: Out of scratch memory %d.\n", scratch_sz);
> >      return CL_OUT_OF_RESOURCES;
> >    }
> >    /* Curbe step 1: fill the constant urb buffer data shared by all
> threads */
> >    if (ker->curbe) {
> >      kernel.slm_sz = cl_curbe_fill(ker, work_dim, global_wk_off,
> global_wk_sz,
> > local_wk_sz, thread_n);
> >      if (kernel.slm_sz > ker->program->ctx->device->local_mem_size) {
> > -      fprintf(stderr, "Beignet: Out of shared local memory %d.\n",
> > kernel.slm_sz);
> >        return CL_OUT_OF_RESOURCES;
> >      }
> >    }
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Beignet mailing list
> > Beignet at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/beignet
> _______________________________________________
> Beignet mailing list
> Beignet at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/beignet
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/beignet/attachments/20151119/c4e8f0f3/attachment.html>