Unix FD Passing

Havoc Pennington havoc.pennington at gmail.com
Sat Apr 25 18:44:34 PDT 2009


On Fri, Apr 24, 2009 at 12:55 PM, Lennart Poettering <mzqohf at 0pointer.de> wrote:
> One more thing: git is only half as much fun if sources use
> inconsistent white space rules. Some files in dbus include tabs for
> indenting. And about every file has trailing whitespace on the
> lines. This makes rebasing and preparing patches needlessly
> painful. Would you accept a patch that cleans this up by replacing all
> tabs by spaces and by dropping all trailing whitespaces? That would be
> a huge patch and of course breaks all outstanding patches from
> folks. And it would only make sense to merge if from then on a
> stronger whitespace regime is upheld.

It makes sense, but would be quite a nightmare while any large patch
is outstanding (such as yours, or the windbus patch, are two I know

It would also make more sense I think if either the fd.org git server,
or at least 'make check', enforced the policy going forward. Otherwise
whitespace will creep in again (it's quite hard to see in patch
review, and git offers no way to force people to have a pre-commit
hook, or even give them one by default when they clone).


More information about the dbus mailing list