Bug in uninorth-agp.c parsing of module parameter uninorth_agp.aperture

[Jochen Rollwagen]

Hi,

i found a bug in uninorth-agp.c, function uninorth_fetch_size.

the line

size  <http://lxr.free-electrons.com/ident?i=size>  =memparse  <http://lxr.free-electrons.com/ident?i=memparse>(aperture  <http://lxr.free-electrons.com/ident?i=aperture>, &aperture  <http://lxr.free-electrons.com/ident?i=aperture>) >> 20;

always sets size to zero which makes the driver allocate the default size of 256 MB which is obviously too large for older uninorth revisions.

I split the line into memparse and shifting and inserted diagnostic messages, output with uninorth_agp.aperture = 32 as boot parameter:

Feb 15 19:12:44 mac-mini kernel: [    2.568636] agpgart-uninorth 0000:00:0b.0: size in uninorth_fetch_size after memparse: 32
Feb 15 19:12:44 mac-mini kernel: [    2.568642] agpgart-uninorth 0000:00:0b.0: size after >> 20: 0

It would be nice if a patch could be produced so i can experiment with 
different aperture sizes without having to rebuild the kernel every time :-)

Cheers

Jochen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20150215/1072b103/attachment.html>