[PATCHv4] drm/sun4i: validate modes for HDMI

[Maxime Ripard]

Hi Daniel,

On Tue, Dec 19, 2017 at 11:05:04AM +0100, Daniel Vetter wrote:
> On Mon, Dec 18, 2017 at 08:50:46AM +0100, Maxime Ripard wrote:
> > Hi,
> > 
> > On Fri, Dec 15, 2017 at 06:06:32PM +0100, Daniel Vetter wrote:
> > > On Fri, Dec 15, 2017 at 05:46:19PM +0100, Hans Verkuil wrote:
> > > > When I connected my cubieboard running 4.15-rc1 to my 4k display I got no picture. Some
> > > > digging found that there is no check against the upper pixelclock limit of the HDMI
> > > > output, so X selects a 4kp60 format at 594 MHz, which obviously won't work.
> > > > 
> > > > The patch below adds a check for the upper bound of what this hardware can do, and
> > > > it checks if the requested tmds clock can be obtained.
> > > > 
> > > > It also allows for the ± 0.5% pixel clock variation that the HDMI spec permits.
> > > > 
> > > > That code is based on commit 22d0be2a557e53a22feb484e8fce255fe09e6ad5 from
> > > > Jose Abreu for drm/arc.
> > > > 
> > > > Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com>
> > > > ---
> > > > Changes since v3:
> > > > - Move the mode_valid callback to struct drm_encoder_helper_funcs.
> > > >   I'm assuming this is the correct struct, since this check is specific to the
> > > >   hdmi encoder.
> > > 
> > > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > 
> > > I think sun4i is in drm-misc, so feel free to push.
> > 
> > I already pushed the v3. Hans, can you provide an additional patch? on top of your v3?
> 
> Pretty sure I reviewed before you pushed, why should I bother?

Yeah, sorry. My mailer didn't fetch your mail until monday morning, so
your review went unnoticed :/

I just pushed a patch to bring the changes to the v4, with your
Acked-by as you told on IRC.

Sorry again,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171220/39363400/attachment.sig>