[Freedreno] [[RFC]DPU PATCH 0/4] Add suppport for sn65dsi86 bridge chip and Innolux 2k edp panel driver

spanda at codeaurora.org spanda at codeaurora.org
Wed Apr 18 18:36:43 UTC 2018


On 2018-04-18 19:42, Sean Paul wrote:
> On Wed, Apr 18, 2018 at 05:49:58PM +0530, Sandeep Panda wrote:
>> Changelog:
>> 
>> v3 -> v4:
> 
> I didn't really bother to do a thorough review given that there are 
> obvious
> mistakes and ignored feedback, it's a waste of time, tbh. Please go 
> through
> the previous reviews and resend a more polished version.

I have replied to your review comments. Please review the edp driver, so 
that
i can address all the comments together while uploading next patchset.
> 
> Sean
> 
>> Current patchset separates out eDP panel specific resources from 
>> sn65dsi86
>> bridge driver and creates a separate driver for the innloux edp panel.
>> 
>> Now bridge driver check if any panel is attached or not to get the 
>> supported
>> modes. If any panel is attached then query from panel driver to get 
>> the modes,
>> or else probe the provided i2c adapter to read the modes from EDID.
>> 
>> Removed hardcoding of bridge init sequence. With this patchset bridge 
>> driver now
>> will program the init sequence based on the current mode set by drm 
>> framework.
>> 
>> Current patchset is not tested on actual bridge chip/panel.
>> 
>> Sandeep Panda (4):
>>   drm/bridge: add support for sn65dsi86 bridge driver
>>   dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings
>>   drm/panel: add Innolux TV123WAM eDP panel driver
>>   dt-bindings: Add Innolux TV123WAM panel bindings
>> 
>>  .../bindings/display/bridge/ti,sn65dsi86.txt       |  60 ++
>>  .../display/panel/innolux,edp-2k-panel.txt         |  21 +
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c              | 742 
>> +++++++++++++++++++++
>>  drivers/gpu/drm/panel/panel-innolux-tv123wam.c     | 299 +++++++++
>>  4 files changed, 1122 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.txt
>>  create mode 100644 
>> Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
>>  create mode 100644 drivers/gpu/drm/bridge/ti-sn65dsi86.c
>>  create mode 100644 drivers/gpu/drm/panel/panel-innolux-tv123wam.c
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>> 


More information about the Freedreno mailing list