[Bug 653137] Warnings in Gstreamer (core) with Clang compiler

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=653137
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Version|0.11.x                      |git
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.36

--- Comment #14 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2011-09-13 22:10:16 UTC ---
Let's try this then:

 commit 46e401b6d940c99bf1b5b0a3ba33f7a29a6a29b3
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Tue Sep 13 23:04:09 2011 +0100

    lfocontrolsource: fix clang compiler warning

    Cast enum to int before checking for negative values, which are
    impossible according to the enum list.

    gstlfocontrolsource.c:652:45: error: comparison of unsigned enum expression
< 0
          is always false [-Werror,-Wtautological-compare]
      if (waveform >= num_waveforms || waveform < 0) {
                                       ~~~~~~~~ ^ ~

    https://bugzilla.gnome.org/show_bug.cgi?id=653137


If that doesn't work, I'd just remove the < 0 check.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.