[gst-devel] gstreamer documentation

[Andy Wingo]

On Fri, 30 Aug 2002, Cameron Hutchison wrote:

> I've got the cvs version checked out. I'll generate some patches soon
> and mail them to this list for checking.

Great!

> How should I generate patches?
> Currently I'm doing "cvs diff -u gstreamer/docs/manual" which generates
> filenames relative to the cvs root.

That's right. As long as it's a diff -u it's fine; the patchlevel
argument to patch (-pN) can strip off dirs.

> Since I'm new to glib too I've got a question about that. I've noticed
> some slight inconsistency in the manual with signal functions. One
> function takes the data pointer as a gpointer and cast it to the correct
> type, and another takes it as the actual type (GstElement * in this case
> think). What is the correct or best way to define signal functions?

It doesn't really matter. If you declare it as a gpointer and cast it,
you can take advantage of gobject's type checking; this can be good if
you mix up your signal arguments somehow (happens to me more often than
I'd like to admit ;). If you go ahead and declare it, you save yourself
some typing. It adds up to the same thing, though, as all pointers are
of course the same size.

cheers,

wingo.