building bad plugins

[Chuck Crisler]

I don't understand the error either. Here is a snippet of the output from
Make yesterday:

make -C vp8
make[3]: Entering directory
`/home/ccrisler/GStreamer/gst-plugins-bad-0.10.20/ext/vp8'
  CC     libgstvp8_la-gstvp8dec.lo
  CC     libgstvp8_la-gstvp8enc.lo
In file included from gstvp8utils.h:24,
                 from gstvp8enc.c:56:
/usr/include/vpx/vpx_codec.h:45:26: error: vpx_config.h: No such file or
directory
make[3]: *** [libgstvp8_la-gstvp8enc.lo] Error 1
make[3]: Leaving directory
`/home/ccrisler/GStreamer/gst-plugins-bad-0.10.20/ext/vp8'
make[2]: *** [vp8] Error 2
make[2]: Leaving directory
`/home/ccrisler/GStreamer/gst-plugins-bad-0.10.20/ext'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/home/ccrisler/GStreamer/gst-plugins-bad-0.10.20'
make: *** [all] Error 2

Here is a snippet of gstvp8enc.c

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

#ifdef HAVE_VP8_ENCODER

#include <gst/tag/tag.h>
#include <string.h>

#include "gstvp8utils.h"
#include "gstvp8enc.h"

And here is gstvp8utils.h

#include <gst/gst.h>
#include <vpx/vpx_codec.h>

Clearly it is not protected. However, today it builds without error.

Thank you Tim.



On Mon, Apr 15, 2013 at 6:07 PM, Tim-Philipp Müller <t.i.m at zen.co.uk> wrote:

> On Mon, 2013-04-15 at 16:54 -0400, Chuck Crisler wrote:
>
> > I am getting a compile error when trying to completely build
> > plugins-bad-0.10.20.
>
> 0.10.20 is from September 2010, is there any reason why you're building
> such an ancient version? It's not even the last 0.10 release..
>
> > The problem seems to be that HAVE_CONFIG_H is defined in the project
> > seemingly to mean that there is a config.h in the bad plugin root
> > directory that the gstreamer modules should include. Unfortunately in
> > VP8 the file vpx_codec.h also uses #ifdef HAVE_CONFIG_H to include
> > vpx_config.h, which looks like a generated file that isn't generated,
> > hence the error. What is the accepted way to get around this?
>
> This is a bug in libvpx, pretty rookie mistake really, I would be
> surprised if it wasn't fixed yet.
>
> But this has also been fixed in gst-plugins-bad by the following commit
> from May 2010:
>
> commit fd77b419a4cffab6f96c6228870693789ed30c12
> Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
> Date:   Thu May 20 09:56:25 2010 +0200
>
>     vp8: Undef HAVE_CONFIG_H before including libvpx headers
>
>     A public libvpx header includes private headers if this is
>     defined, causing compilation failures because the private headers
>     are not installed of course.
>
>
> which should be even in -bad 0.10.20 so I don't know what's going on.
>
> Cheers
>  -Tim
>
>
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20130416/9e461a42/attachment-0001.html>