Use of "on-sending-rtcp" signal

[Matthew Waters]

On Sun., 20 Jan. 2019, 10:28 Nicolas Dufresne <nicolas at ndufresne.ca wrote:

>
>
> Le sam. 19 janv. 2019 14 h 27, Sebastian Dröge <sebastian at centricular.com>
> a écrit :
>
>> On Sat, 2019-01-19 at 11:38 -0500, Nicolas Dufresne wrote:
>> > Le samedi 19 janvier 2019 à 17:06 +0100, Philippe Lalevée a écrit :
>> > > Hello I still have problems when using on-sending-rtcp/on-receiving
>> > > signals (I would like to send RTCP packets of APP type).
>> >
>> > The RTPSession API isn't public, I'm not sure it is correct to use
>> > this from an application. I believe you should better describe what
>> > you are trying to do.
>>
>
> I don't agree. The API being public would mean we install the appropriate
> header. These things are not event in GST namespace. As we expose the
> opaque object as a GObject, yes, we have made public the properties and
> signal, but we don't document it. I totally disagree with having to
> maintain API stability here for our internal RTP helpers.
>

What makes you think the internal API as exposed through the GObject
properties and signals is not public?  My understanding is that it is
public API.  Just because there is no header, doesn't mean the API is not
public.  How do you explain element properties then or even GObject
properties in general which require no headers for use.

Documentation of the internal rtpsession isn't exposed presumably due to
limitations in gtk-doc however it is written for public use.


>> The rtpsession API is public, i.e. the signals and properties on the
>> "internal-session" object of the rtpsession GStreamer element. People
>> are using these in their applications for various things :)
>>
>> And the signals Philippe are mentioned can be used for including custom
>> RTCP packets or receiving them. Not sure what the problem is he's
>> running into though, a testcase (with code) to run and show the problem
>> would probably help. But it seems he solved it already if I understand
>> the last message correctly.
>>
>> --
>> Sebastian Dröge, Centricular Ltd · https://www.centricular.com
>>
>> _______________________________________________
>> gstreamer-devel mailing list
>> gstreamer-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>>
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20190120/272afe02/attachment.html>